core/go-mlx
8
0
Fork 0
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions 1

[agent/claude:opus] DX audit and fix. 1) Review CLAUDE.md — update any outdate... #3

Closed
Virgil wants to merge 0 commits from agent/dx-audit-and-fix--1--review-claude-md into dev
pull from: agent/dx-audit-and-fix--1--review-claude-md
merge into: core:dev
Conversation 1 Commits - Files changed - +9 -12
Virgil commented 2026-03-17 08:36:03 +00:00
Member
Copy link

Task

DX audit and fix. 1) Review CLAUDE.md — update any outdated commands. 2) Run go test -cover ./... — report coverage, add tests for untested critical paths. 3) Check error handling: all errors must use coreerr.E() from go-log, not fmt.Errorf. Fix violations. 4) Check file I/O uses go-io not os.ReadFile/os.WriteFile. Fix violations. 5) Run tests to confirm. Commit fixes.

Agent: claude:opus
Commits: 1
Branch: agent/dx-audit-and-fix--1--review-claude-md

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task DX audit and fix. 1) Review CLAUDE.md — update any outdated commands. 2) Run `go test -cover ./...` — report coverage, add tests for untested critical paths. 3) Check error handling: all errors must use coreerr.E() from go-log, not fmt.Errorf. Fix violations. 4) Check file I/O uses go-io not os.ReadFile/os.WriteFile. Fix violations. 5) Run tests to confirm. Commit fixes. **Agent:** claude:opus **Commits:** 1 **Branch:** `agent/dx-audit-and-fix--1--review-claude-md` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>
fix(api): DX audit — fix Discover API, replace os.RemoveAll, update docs
All checks were successful
Security Scan / security (pull_request) Successful in 11s
Details
Test / Vet & Build (pull_request) Successful in 29s
Details
4374c22a7e 
- Update TestDiscover to use iter.Seq return from inference.Discover
- Replace os.RemoveAll with coreio.Local.DeleteAll in mlxlm backend
- Correct CLAUDE.md: dist/include/ is committed, only libs are gitignored

Co-Authored-By: Virgil <virgil@lethean.io>
Virgil commented 2026-03-17 08:36:06 +00:00
Author
Member
Copy link

Verification Failed

Command: go test ./...

# forge.lthn.ai/core/go-mlx.test
/opt/homebrew/opt/go/libexec/pkg/tool/darwin_arm64/link: running c++ failed: exit status 1
/usr/bin/c++ -arch arm64 -Wl,-S -Wl,-x -o $WORK/b001/go-mlx.test -Qunused-arguments /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/go.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000000.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000001.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000002.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000003.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000004.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000005.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000006.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000007.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000008.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000009.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000010.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000011.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000012.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000013.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000014.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000015.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000016.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000017.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000018.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000019.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000020.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000021.o /var/folders/k6/c05lqf4j1...

Exit code: 1

PR will not be auto-merged.

## Verification Failed **Command:** `go test ./...` ``` # forge.lthn.ai/core/go-mlx.test /opt/homebrew/opt/go/libexec/pkg/tool/darwin_arm64/link: running c++ failed: exit status 1 /usr/bin/c++ -arch arm64 -Wl,-S -Wl,-x -o $WORK/b001/go-mlx.test -Qunused-arguments /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/go.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000000.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000001.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000002.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000003.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000004.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000005.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000006.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000007.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000008.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000009.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000010.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000011.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000012.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000013.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000014.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000015.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000016.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000017.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000018.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000019.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000020.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-3348173699/000021.o /var/folders/k6/c05lqf4j1... ``` **Exit code:** 1 PR will not be auto-merged.
Virgil changed target branch from main to dev 2026-03-24 11:12:18 +00:00
Virgil closed this pull request 2026-03-24 11:19:13 +00:00
All checks were successful
Security Scan / security (pull_request) Successful in 11s
Details
Test / Vet & Build (pull_request) Successful in 29s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
needs-review
  
athena
Assign to Athena AI agent (M3 Ultra)

  
athena-gemini
Dispatch to Gemini CLI on M3 Ultra

  
audit
Code audit task

  
clotho
Assign to Clotho AI agent for processing

  
clotho-gemini
Dispatch to Gemini CLI on darbs (AU)

  
codex
Dispatch to Codex CLI on gateway for analysis

  
darbs-claude
Dispatch to Claude on darbs (AU)

  
security
Security review task

  
wiki
Documentation/wiki update

No labels
needs-review
athena
athena-gemini
audit
clotho
clotho-gemini
codex
darbs-claude
security
wiki
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
core/go-mlx!3
No description provided.