From 84d07daf199ea23d0815557315c19564e50b545b Mon Sep 17 00:00:00 2001 From: Virgil Date: Sat, 4 Apr 2026 00:07:48 +0000 Subject: [PATCH] feat(process): relax runner success semantics --- runner.go | 2 +- runner_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/runner.go b/runner.go index 3a5bf2e..3687369 100644 --- a/runner.go +++ b/runner.go @@ -66,7 +66,7 @@ type RunAllResult struct { // Success returns true if all non-skipped specs passed. func (r RunAllResult) Success() bool { - return r.Failed == 0 && r.Skipped == 0 + return r.Failed == 0 } // RunAll executes specs respecting dependencies, parallelising where possible. diff --git a/runner_test.go b/runner_test.go index 473545c..1f160db 100644 --- a/runner_test.go +++ b/runner_test.go @@ -178,7 +178,7 @@ func TestRunner_RunAll_CircularDeps(t *testing.T) { }) require.NoError(t, err) - assert.False(t, result.Success()) + assert.True(t, result.Success()) assert.Equal(t, 0, result.Failed) assert.Equal(t, 2, result.Skipped) for _, res := range result.Results { @@ -196,7 +196,7 @@ func TestRunner_RunAll_CircularDeps(t *testing.T) { }) require.NoError(t, err) - assert.False(t, result.Success()) + assert.True(t, result.Success()) assert.Equal(t, 0, result.Failed) assert.Equal(t, 1, result.Skipped) require.Len(t, result.Results, 1)