diff --git a/runner.go b/runner.go index db24a7c..66956fc 100644 --- a/runner.go +++ b/runner.go @@ -147,7 +147,6 @@ func (r *Runner) RunAll(ctx context.Context, specs []RunSpec) (*RunAllResult, er Name: name, Spec: remaining[name], ExitCode: 1, - Skipped: true, Error: coreerr.E("Runner.RunAll", "circular dependency or missing dependency", nil), } } diff --git a/runner_test.go b/runner_test.go index 9b16729..97fe0a9 100644 --- a/runner_test.go +++ b/runner_test.go @@ -178,11 +178,11 @@ func TestRunner_RunAll_CircularDeps(t *testing.T) { }) require.NoError(t, err) - assert.True(t, result.Success()) - assert.Equal(t, 0, result.Failed) - assert.Equal(t, 2, result.Skipped) + assert.False(t, result.Success()) + assert.Equal(t, 2, result.Failed) + assert.Equal(t, 0, result.Skipped) for _, res := range result.Results { - assert.True(t, res.Skipped) + assert.False(t, res.Skipped) assert.Equal(t, 1, res.ExitCode) assert.Error(t, res.Error) } @@ -196,11 +196,11 @@ func TestRunner_RunAll_CircularDeps(t *testing.T) { }) require.NoError(t, err) - assert.True(t, result.Success()) - assert.Equal(t, 0, result.Failed) - assert.Equal(t, 1, result.Skipped) + assert.False(t, result.Success()) + assert.Equal(t, 1, result.Failed) + assert.Equal(t, 0, result.Skipped) require.Len(t, result.Results, 1) - assert.True(t, result.Results[0].Skipped) + assert.False(t, result.Results[0].Skipped) assert.Equal(t, 1, result.Results[0].ExitCode) assert.Error(t, result.Results[0].Error) })