core/go-process
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

fix(process): allow standalone service usage

Browse source
This commit is contained in:
Virgil 2026-04-04 00:55:49 +00:00
parent 0e299e5349
commit dfa97f2112
2 changed files with 54 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

58
service.go
View file

@ -38,6 +38,14 @@ type Service struct {
registrations sync.Once
}
// coreApp returns the attached Core runtime, if one exists.
func (s *Service) coreApp() *core.Core {
if s == nil || s.ServiceRuntime == nil {
return nil
}
return s.ServiceRuntime.Core()
}
// Options configures the process service.
//
// Example:
@ -79,8 +87,8 @@ func NewService(opts Options) func(*core.Core) (any, error) {
// _ = svc.OnStartup(ctx)
func (s *Service) OnStartup(ctx context.Context) error {
s.registrations.Do(func() {
if s.Core() != nil {
s.Core().RegisterTask(s.handleTask)
if c := s.coreApp(); c != nil {
c.RegisterTask(s.handleTask)
}
})
return nil
@ -204,8 +212,8 @@ func (s *Service) StartWithOptions(ctx context.Context, opts RunOptions) (*Proce
// Start the process
if err := cmd.Start(); err != nil {
cancel()
if s.Core() != nil {
_ = s.Core().ACTION(ActionProcessExited{
if c := s.coreApp(); c != nil {
_ = c.ACTION(ActionProcessExited{
ID: id,
ExitCode: -1,
Duration: time.Since(startedAt),
@ -233,13 +241,15 @@ func (s *Service) StartWithOptions(ctx context.Context, opts RunOptions) (*Proce
}
// Broadcast start
_ = s.Core().ACTION(ActionProcessStarted{
ID: id,
Command: opts.Command,
Args: opts.Args,
Dir: opts.Dir,
PID: cmd.Process.Pid,
})
if c := s.coreApp(); c != nil {
_ = c.ACTION(ActionProcessStarted{
ID: id,
Command: opts.Command,
Args: opts.Args,
Dir: opts.Dir,
PID: cmd.Process.Pid,
})
}
// Stream output in goroutines
var wg sync.WaitGroup
@ -280,13 +290,17 @@ func (s *Service) StartWithOptions(ctx context.Context, opts RunOptions) (*Proce
}
if status == StatusKilled {
exitAction.Error = coreerr.E("Service.StartWithOptions", "process was killed", nil)
_ = s.Core().ACTION(ActionProcessKilled{
ID: id,
Signal: signalName,
})
if c := s.coreApp(); c != nil {
_ = c.ACTION(ActionProcessKilled{
ID: id,
Signal: signalName,
})
}
}
_ = s.Core().ACTION(exitAction)
if c := s.coreApp(); c != nil {
_ = c.ACTION(exitAction)
}
}()
return proc, nil
@ -307,11 +321,13 @@ func (s *Service) streamOutput(proc *Process, r io.Reader, stream Stream) {
}
// Broadcast output
_ = s.Core().ACTION(ActionProcessOutput{
ID: proc.ID,
Line: line,
Stream: stream,
})
if c := s.coreApp(); c != nil {
_ = c.ACTION(ActionProcessOutput{
ID: proc.ID,
Line: line,
Stream: stream,
})
}
}
}

17
service_test.go
View file

@ -44,6 +44,23 @@ func TestService_Start(t *testing.T) {
assert.Contains(t, proc.Output(), "hello")
})
t.Run("works without core runtime", func(t *testing.T) {
svc := &Service{
processes: make(map[string]*Process),
bufSize: 1024,
}
proc, err := svc.Start(context.Background(), "echo", "standalone")
require.NoError(t, err)
require.NotNil(t, proc)
<-proc.Done()
assert.Equal(t, StatusExited, proc.Status)
assert.Equal(t, 0, proc.ExitCode)
assert.Contains(t, proc.Output(), "standalone")
})
t.Run("failing command", func(t *testing.T) {
svc, _ := newTestService(t)