[agent/claude:opus] DX audit and fix. 1) Review CLAUDE.md — update any outdate... #1

Merged

Virgil merged 1 commit from agent/dx-audit-and-fix--1--review-claude-md into main

2026-03-17 08:43:18 +00:00

Virgil commented

2026-03-17 08:43:15 +00:00

Member

Task

DX audit and fix. 1) Review CLAUDE.md — update any outdated commands, document new Timeout/GracePeriod/KillGroup/Shutdown features. 2) Run go test -cover ./... — report coverage, add tests for untested critical paths. 3) Check error handling: all errors must use coreerr.E() from go-log, not fmt.Errorf. Fix violations. 4) Run tests to confirm. Commit fixes.

Agent: claude:opus
Commits: 1
Branch: agent/dx-audit-and-fix--1--review-claude-md

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task DX audit and fix. 1) Review CLAUDE.md — update any outdated commands, document new Timeout/GracePeriod/KillGroup/Shutdown features. 2) Run `go test -cover ./...` — report coverage, add tests for untested critical paths. 3) Check error handling: all errors must use coreerr.E() from go-log, not fmt.Errorf. Fix violations. 4) Run tests to confirm. Commit fixes. **Agent:** claude:opus **Commits:** 1 **Branch:** `agent/dx-audit-and-fix--1--review-claude-md` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>

Virgil added 1 commit 2026-03-17 08:43:15 +00:00

fix(dx): audit CLAUDE.md, error handling, and test coverage 87ef2dbe16

- Update CLAUDE.md: document Detach, DisableCapture, ShutdownTimeout,
  auto-registration, graceful shutdown, and error handling conventions;
  add missing go-log and go-io dependencies
- Replace ServiceError type in process_global.go with coreerr.E()
  sentinel errors for consistency with the rest of the package
- Wrap raw error returns in Registry.Register, Registry.Unregister,
  and PIDFile.Release with coreerr.E() for proper context
- Add tests for Service.Kill, Service.Output, Service.OnShutdown,
  Service.OnStartup, Service.RunWithOptions, Service.Running,
  Process.Signal, Daemon.Run (context cancellation),
  Daemon.Stop (idempotent), DisableCapture, Detach, env vars,
  exec.WithDir, exec.WithEnv, exec.WithStdin/Stdout/Stderr,
  exec.RunQuiet
- Coverage: root 82.7% → 88.3%, exec/ 61.9% → 87.3%

Co-Authored-By: Virgil <virgil@lethean.io>