package process import ( "context" "testing" framework "dappco.re/go/core" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" ) func newTestRunner(t *testing.T) *Runner { t.Helper() c := framework.New() factory := NewService(Options{}) raw, err := factory(c) require.NoError(t, err) return NewRunner(raw.(*Service)) } func TestRunner_RunSequential(t *testing.T) { t.Run("all pass", func(t *testing.T) { runner := newTestRunner(t) result, err := runner.RunSequential(context.Background(), []RunSpec{ {Name: "first", Command: "echo", Args: []string{"1"}}, {Name: "second", Command: "echo", Args: []string{"2"}}, {Name: "third", Command: "echo", Args: []string{"3"}}, }) require.NoError(t, err) assert.True(t, result.Success()) assert.Equal(t, 3, result.Passed) assert.Equal(t, 0, result.Failed) assert.Equal(t, 0, result.Skipped) }) t.Run("stops on failure", func(t *testing.T) { runner := newTestRunner(t) result, err := runner.RunSequential(context.Background(), []RunSpec{ {Name: "first", Command: "echo", Args: []string{"1"}}, {Name: "fails", Command: "sh", Args: []string{"-c", "exit 1"}}, {Name: "third", Command: "echo", Args: []string{"3"}}, }) require.NoError(t, err) assert.False(t, result.Success()) assert.Equal(t, 1, result.Passed) assert.Equal(t, 1, result.Failed) assert.Equal(t, 1, result.Skipped) require.Len(t, result.Results, 3) assert.Equal(t, 0, result.Results[0].ExitCode) assert.NoError(t, result.Results[0].Error) assert.Equal(t, 1, result.Results[1].ExitCode) assert.NoError(t, result.Results[1].Error) assert.True(t, result.Results[2].Skipped) }) t.Run("allow failure continues", func(t *testing.T) { runner := newTestRunner(t) result, err := runner.RunSequential(context.Background(), []RunSpec{ {Name: "first", Command: "echo", Args: []string{"1"}}, {Name: "fails", Command: "sh", Args: []string{"-c", "exit 1"}, AllowFailure: true}, {Name: "third", Command: "echo", Args: []string{"3"}}, }) require.NoError(t, err) // Still counts as failed but pipeline continues assert.Equal(t, 2, result.Passed) assert.Equal(t, 1, result.Failed) assert.Equal(t, 0, result.Skipped) }) } func TestRunner_RunParallel(t *testing.T) { t.Run("all run concurrently", func(t *testing.T) { runner := newTestRunner(t) result, err := runner.RunParallel(context.Background(), []RunSpec{ {Name: "first", Command: "echo", Args: []string{"1"}}, {Name: "second", Command: "echo", Args: []string{"2"}}, {Name: "third", Command: "echo", Args: []string{"3"}}, }) require.NoError(t, err) assert.True(t, result.Success()) assert.Equal(t, 3, result.Passed) assert.Len(t, result.Results, 3) }) t.Run("failure doesnt stop others", func(t *testing.T) { runner := newTestRunner(t) result, err := runner.RunParallel(context.Background(), []RunSpec{ {Name: "first", Command: "echo", Args: []string{"1"}}, {Name: "fails", Command: "sh", Args: []string{"-c", "exit 1"}}, {Name: "third", Command: "echo", Args: []string{"3"}}, }) require.NoError(t, err) assert.False(t, result.Success()) assert.Equal(t, 2, result.Passed) assert.Equal(t, 1, result.Failed) }) } func TestRunner_RunAll(t *testing.T) { t.Run("respects dependencies", func(t *testing.T) { runner := newTestRunner(t) result, err := runner.RunAll(context.Background(), []RunSpec{ {Name: "third", Command: "echo", Args: []string{"3"}, After: []string{"second"}}, {Name: "first", Command: "echo", Args: []string{"1"}}, {Name: "second", Command: "echo", Args: []string{"2"}, After: []string{"first"}}, }) require.NoError(t, err) assert.True(t, result.Success()) assert.Equal(t, 3, result.Passed) }) t.Run("skips dependents on failure", func(t *testing.T) { runner := newTestRunner(t) result, err := runner.RunAll(context.Background(), []RunSpec{ {Name: "first", Command: "sh", Args: []string{"-c", "exit 1"}}, {Name: "second", Command: "echo", Args: []string{"2"}, After: []string{"first"}}, {Name: "third", Command: "echo", Args: []string{"3"}, After: []string{"second"}}, }) require.NoError(t, err) assert.False(t, result.Success()) assert.Equal(t, 0, result.Passed) assert.Equal(t, 1, result.Failed) assert.Equal(t, 2, result.Skipped) }) t.Run("parallel independent specs", func(t *testing.T) { runner := newTestRunner(t) // These should run in parallel since they have no dependencies result, err := runner.RunAll(context.Background(), []RunSpec{ {Name: "a", Command: "echo", Args: []string{"a"}}, {Name: "b", Command: "echo", Args: []string{"b"}}, {Name: "c", Command: "echo", Args: []string{"c"}}, {Name: "final", Command: "echo", Args: []string{"done"}, After: []string{"a", "b", "c"}}, }) require.NoError(t, err) assert.True(t, result.Success()) assert.Equal(t, 4, result.Passed) }) t.Run("preserves input order", func(t *testing.T) { runner := newTestRunner(t) specs := []RunSpec{ {Name: "third", Command: "echo", Args: []string{"3"}, After: []string{"second"}}, {Name: "first", Command: "echo", Args: []string{"1"}}, {Name: "second", Command: "echo", Args: []string{"2"}, After: []string{"first"}}, } result, err := runner.RunAll(context.Background(), specs) require.NoError(t, err) require.Len(t, result.Results, len(specs)) for i, res := range result.Results { assert.Equal(t, specs[i].Name, res.Name) } }) } func TestRunner_RunAll_CircularDeps(t *testing.T) { t.Run("circular dependency is skipped with error", func(t *testing.T) { runner := newTestRunner(t) result, err := runner.RunAll(context.Background(), []RunSpec{ {Name: "a", Command: "echo", Args: []string{"a"}, After: []string{"b"}}, {Name: "b", Command: "echo", Args: []string{"b"}, After: []string{"a"}}, }) require.NoError(t, err) assert.True(t, result.Success()) assert.Equal(t, 0, result.Failed) assert.Equal(t, 2, result.Skipped) for _, res := range result.Results { assert.True(t, res.Skipped) assert.Equal(t, 0, res.ExitCode) assert.Error(t, res.Error) } }) t.Run("missing dependency is skipped with error", func(t *testing.T) { runner := newTestRunner(t) result, err := runner.RunAll(context.Background(), []RunSpec{ {Name: "a", Command: "echo", Args: []string{"a"}, After: []string{"missing"}}, }) require.NoError(t, err) assert.True(t, result.Success()) assert.Equal(t, 0, result.Failed) assert.Equal(t, 1, result.Skipped) require.Len(t, result.Results, 1) assert.True(t, result.Results[0].Skipped) assert.Equal(t, 0, result.Results[0].ExitCode) assert.Error(t, result.Results[0].Error) }) } func TestRunner_ContextCancellation(t *testing.T) { t.Run("run sequential skips pending specs", func(t *testing.T) { runner := newTestRunner(t) ctx, cancel := context.WithCancel(context.Background()) cancel() result, err := runner.RunSequential(ctx, []RunSpec{ {Name: "first", Command: "echo", Args: []string{"1"}}, {Name: "second", Command: "echo", Args: []string{"2"}}, }) require.NoError(t, err) assert.Equal(t, 0, result.Passed) assert.Equal(t, 0, result.Failed) assert.Equal(t, 2, result.Skipped) require.Len(t, result.Results, 2) for _, res := range result.Results { assert.True(t, res.Skipped) assert.Equal(t, 1, res.ExitCode) assert.Error(t, res.Error) assert.Contains(t, res.Error.Error(), "context canceled") } }) t.Run("run all skips pending specs", func(t *testing.T) { runner := newTestRunner(t) ctx, cancel := context.WithCancel(context.Background()) cancel() result, err := runner.RunAll(ctx, []RunSpec{ {Name: "first", Command: "echo", Args: []string{"1"}}, {Name: "second", Command: "echo", Args: []string{"2"}, After: []string{"first"}}, }) require.NoError(t, err) assert.Equal(t, 0, result.Passed) assert.Equal(t, 0, result.Failed) assert.Equal(t, 2, result.Skipped) require.Len(t, result.Results, 2) for _, res := range result.Results { assert.True(t, res.Skipped) assert.Equal(t, 1, res.ExitCode) assert.Error(t, res.Error) assert.Contains(t, res.Error.Error(), "context canceled") } }) } func TestRunResult_Passed(t *testing.T) { t.Run("success", func(t *testing.T) { r := RunResult{ExitCode: 0} assert.True(t, r.Passed()) }) t.Run("non-zero exit", func(t *testing.T) { r := RunResult{ExitCode: 1} assert.False(t, r.Passed()) }) t.Run("skipped", func(t *testing.T) { r := RunResult{ExitCode: 0, Skipped: true} assert.False(t, r.Passed()) }) t.Run("error", func(t *testing.T) { r := RunResult{ExitCode: 0, Error: assert.AnError} assert.False(t, r.Passed()) }) } func TestRunner_NilService(t *testing.T) { runner := NewRunner(nil) _, err := runner.RunAll(context.Background(), nil) require.Error(t, err) assert.ErrorIs(t, err, ErrRunnerNoService) _, err = runner.RunSequential(context.Background(), nil) require.Error(t, err) assert.ErrorIs(t, err, ErrRunnerNoService) _, err = runner.RunParallel(context.Background(), nil) require.Error(t, err) assert.ErrorIs(t, err, ErrRunnerNoService) } func TestRunner_NilContext(t *testing.T) { runner := newTestRunner(t) _, err := runner.RunAll(nil, nil) require.Error(t, err) assert.ErrorIs(t, err, ErrRunnerContextRequired) _, err = runner.RunSequential(nil, nil) require.Error(t, err) assert.ErrorIs(t, err, ErrRunnerContextRequired) _, err = runner.RunParallel(nil, nil) require.Error(t, err) assert.ErrorIs(t, err, ErrRunnerContextRequired) } func TestRunner_InvalidSpecNames(t *testing.T) { runner := newTestRunner(t) t.Run("rejects empty names", func(t *testing.T) { _, err := runner.RunSequential(context.Background(), []RunSpec{ {Name: "", Command: "echo", Args: []string{"a"}}, }) require.Error(t, err) assert.ErrorIs(t, err, ErrRunnerInvalidSpecName) }) t.Run("rejects empty dependency names", func(t *testing.T) { _, err := runner.RunAll(context.Background(), []RunSpec{ {Name: "one", Command: "echo", Args: []string{"a"}, After: []string{""}}, }) require.Error(t, err) assert.ErrorIs(t, err, ErrRunnerInvalidDependencyName) }) t.Run("rejects duplicated dependency names", func(t *testing.T) { _, err := runner.RunAll(context.Background(), []RunSpec{ {Name: "one", Command: "echo", Args: []string{"a"}, After: []string{"two", "two"}}, }) require.Error(t, err) assert.ErrorIs(t, err, ErrRunnerInvalidDependencyName) }) t.Run("rejects self dependency", func(t *testing.T) { _, err := runner.RunAll(context.Background(), []RunSpec{ {Name: "one", Command: "echo", Args: []string{"a"}, After: []string{"one"}}, }) require.Error(t, err) assert.ErrorIs(t, err, ErrRunnerInvalidDependencyName) }) t.Run("rejects duplicate names", func(t *testing.T) { _, err := runner.RunAll(context.Background(), []RunSpec{ {Name: "same", Command: "echo", Args: []string{"a"}}, {Name: "same", Command: "echo", Args: []string{"b"}}, }) require.Error(t, err) assert.ErrorIs(t, err, ErrRunnerInvalidSpecName) }) t.Run("rejects duplicate names in parallel mode", func(t *testing.T) { _, err := runner.RunParallel(context.Background(), []RunSpec{ {Name: "one", Command: "echo", Args: []string{"a"}}, {Name: "one", Command: "echo", Args: []string{"b"}}, }) require.Error(t, err) assert.ErrorIs(t, err, ErrRunnerInvalidSpecName) }) }