From 75d151b4e5345cd93d3fd5862673bf62cd6b3845 Mon Sep 17 00:00:00 2001 From: Virgil Date: Sun, 5 Apr 2026 03:07:41 +0000 Subject: [PATCH] refactor(proxy): clarify miner login callback naming Co-Authored-By: Virgil --- miner.go | 2 +- miner_login_test.go | 2 +- state_impl.go | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/miner.go b/miner.go index 982bbae..75b6ff1 100644 --- a/miner.go +++ b/miner.go @@ -57,7 +57,7 @@ type Miner struct { sendMu sync.Mutex // serialises writes to conn buf [16384]byte // per-miner send buffer; avoids per-write allocations onLogin func(*Miner) - onLoginAccepted func(*Miner) + onLoginReady func(*Miner) onSubmit func(*Miner, *SubmitEvent) onClose func(*Miner) closeOnce sync.Once diff --git a/miner_login_test.go b/miner_login_test.go index 72e10dc..ef9331b 100644 --- a/miner_login_test.go +++ b/miner_login_test.go @@ -198,7 +198,7 @@ func TestMiner_HandleLogin_FailedAssignmentDoesNotDispatchLoginEvent(t *testing. miner := NewMiner(minerConn, 3333, nil) miner.extNH = true miner.onLogin = func(*Miner) {} - miner.onLoginAccepted = func(m *Miner) { + miner.onLoginReady = func(m *Miner) { proxyInstance.events.Dispatch(Event{Type: EventLogin, Miner: m}) } proxyInstance.miners[miner.ID()] = miner diff --git a/state_impl.go b/state_impl.go index 396a5c0..dccfa22 100644 --- a/state_impl.go +++ b/state_impl.go @@ -456,7 +456,7 @@ func (p *Proxy) acceptMiner(conn net.Conn, localPort uint16) { p.splitter.OnLogin(&LoginEvent{Miner: m}) } } - miner.onLoginAccepted = func(m *Miner) { + miner.onLoginReady = func(m *Miner) { if p.events != nil { p.events.Dispatch(Event{Type: EventLogin, Miner: m}) } @@ -1032,8 +1032,8 @@ func (m *Miner) handleLogin(request stratumRequest) { m.ReplyWithError(requestID(request.ID), "Proxy is unavailable, try again later") return } - if m.onLoginAccepted != nil { - m.onLoginAccepted(m) + if m.onLoginReady != nil { + m.onLoginReady(m) } m.replyLoginSuccess(requestID(request.ID)) }