core/go-proxy
8
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(nicehash): avoid double-counting expired submissions

Browse source 
Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Virgil 2026-04-04 21:45:57 +00:00
parent 8b47e6a11b
commit c74f62e6d7
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
splitter/nicehash/impl.go
View file

@ -299,7 +299,6 @@ func (m *NonceMapper) OnResultAccepted(sequence int64, accepted bool, errorMessa
job := m.storage.job
prevJob := m.storage.prevJob
m.storage.mu.Unlock()
_ = m.storage.IsValidJobID(ctx.JobID)
job, expired := resolveSubmissionJob(ctx.JobID, job, prevJob)
m.mu.Unlock()
if !ok || miner == nil {

7
splitter/nicehash/mapper_start_test.go
View file

@ -137,6 +137,9 @@ func TestMapper_OnResultAccepted_ExpiredUsesPreviousJob(t *testing.T) {
mapper.storage.job = proxy.Job{JobID: "job-new", Blob: "blob-new", Target: "b88d0600"}
mapper.storage.prevJob = proxy.Job{JobID: "job-old", Blob: "blob-old", Target: "b88d0600"}
mapper.storage.miners[miner.ID()] = miner
if !mapper.storage.IsValidJobID("job-old") {
t.Fatal("expected previous job to validate before result handling")
}
mapper.pending[9] = SubmitContext{
RequestID: 42,
MinerID: miner.ID(),
@ -146,6 +149,10 @@ func TestMapper_OnResultAccepted_ExpiredUsesPreviousJob(t *testing.T) {
mapper.OnResultAccepted(9, true, "")
if got := mapper.storage.expired; got != 1 {
t.Fatalf("expected one expired validation, got %d", got)
}
select {
case event := <-events:
if !event.Expired {