core/go-ratelimit
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

fix(sqlite): replace quotas on empty snapshot load

Browse source 
Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Virgil 2026-03-23 09:15:16 +00:00
parent d1c90b937d
commit 9e715c2cb0
2 changed files with 29 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
ratelimit.go
View file

@ -228,10 +228,8 @@ func (rl *RateLimiter) loadSQLite() error {
if err != nil {
return err
}
// Persisted quotas are authoritative when present; otherwise keep config defaults.
if len(quotas) > 0 {
rl.Quotas = maps.Clone(quotas)
}
// Persisted quotas are always authoritative, even when empty.
rl.Quotas = maps.Clone(quotas)
state, err := rl.sqlite.loadState()
if err != nil {

27
sqlite_test.go
View file

@ -788,6 +788,33 @@ func TestSQLiteLoadReplacesPersistedSnapshot_Good(t *testing.T) {
assert.Equal(t, 1, rl2.Stats("model-b").RPD)
}
func TestSQLiteLoadReplacesQuotasWithEmptyPersistedSnapshot_Good(t *testing.T) {
dbPath := filepath.Join(t.TempDir(), "empty-quotas.db")
rl, err := NewWithSQLiteConfig(dbPath, Config{
Providers: []Provider{ProviderLocal},
})
require.NoError(t, err)
require.Empty(t, rl.Quotas)
rl.RecordUsage("usage-only-model", 10, 20)
require.NoError(t, rl.Persist())
require.NoError(t, rl.Close())
rl2, err := NewWithSQLiteConfig(dbPath, Config{
Providers: []Provider{ProviderGemini},
})
require.NoError(t, err)
defer rl2.Close()
require.NotEmpty(t, rl2.Quotas, "constructor should start with Gemini defaults")
require.NoError(t, rl2.Load())
assert.Empty(t, rl2.Quotas, "persisted empty quotas should replace configured defaults")
assert.NotContains(t, rl2.Quotas, "gemini-3-pro-preview")
assert.Equal(t, 1, rl2.Stats("usage-only-model").RPD)
}
func TestSQLitePersistAtomic_Good(t *testing.T) {
dbPath := filepath.Join(t.TempDir(), "persist-atomic.db")
rl, err := NewWithSQLiteConfig(dbPath, Config{