core/go-rocm
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

fix: clamp VRAM Free to prevent uint64 underflow

Browse source 
Guard against transient sysfs inconsistency where used > total.

Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Claude 2026-02-19 21:48:19 +00:00
parent 501de83d3b
commit 954c57071a
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
vram.go
View file

@ -13,6 +13,9 @@ import (
// GetVRAMInfo reads VRAM usage for the discrete GPU from sysfs. // GetVRAMInfo reads VRAM usage for the discrete GPU from sysfs.
// It identifies the dGPU by selecting the card with the largest VRAM total, // It identifies the dGPU by selecting the card with the largest VRAM total,
// which avoids hardcoding card numbers (e.g. card0=iGPU, card1=dGPU on Ryzen). // which avoids hardcoding card numbers (e.g. card0=iGPU, card1=dGPU on Ryzen).
//
// Note: total and used are read non-atomically from sysfs; transient
// inconsistencies are possible under heavy allocation churn.
func GetVRAMInfo() (VRAMInfo, error) { func GetVRAMInfo() (VRAMInfo, error) {
cards, err := filepath.Glob("/sys/class/drm/card[0-9]*/device/mem_info_vram_total") cards, err := filepath.Glob("/sys/class/drm/card[0-9]*/device/mem_info_vram_total")
if err != nil { if err != nil {
@ -45,10 +48,15 @@ func GetVRAMInfo() (VRAMInfo, error) {
return VRAMInfo{}, fmt.Errorf("rocm: read vram used: %w", err) return VRAMInfo{}, fmt.Errorf("rocm: read vram used: %w", err)
} }
free := uint64(0)
if bestTotal > used {
free = bestTotal - used
}
return VRAMInfo{ return VRAMInfo{
Total: bestTotal, Total: bestTotal,
Used: used, Used: used,
Free: bestTotal - used, Free: free,
}, nil }, nil
} }