Principle 1 — Predictable Names: - rocmModel.srv → rocmModel.server (struct field) - recordMetrics: met → metrics (local var) - backend.go/model.go: cfg → config (local vars) - gguf.go: tc/kc → tensorCount32/kvCount32 (v2 count reads) Principle 2 — Comments as Usage Examples: - Added concrete usage examples to all exported functions: VRAMInfo, ModelInfo, DiscoverModels, GetVRAMInfo, ROCmAvailable, LoadModel, Available, NewClient, Health, ChatComplete, Complete, ReadMetadata, FileTypeName Principle 5 — Test naming (_Good/_Bad/_Ugly): - All test functions renamed to AX-7 convention across: discover_test.go, vram_test.go, server_test.go, internal/gguf/gguf_test.go, internal/llamacpp/client_test.go, internal/llamacpp/health_test.go Also: fix go.sum missing entry for dappco.re/go/core transitive dep (pulled in by go-inference replace directive). All tests pass: go test ./... -short -count=1 Co-Authored-By: Virgil <virgil@lethean.io> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
137 lines
3.4 KiB
Go
137 lines
3.4 KiB
Go
//go:build linux && amd64
|
|
|
|
package rocm
|
|
|
|
import (
|
|
"context"
|
|
"os"
|
|
"strings"
|
|
"testing"
|
|
|
|
"forge.lthn.ai/core/go-inference"
|
|
coreerr "forge.lthn.ai/core/go-log"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestFindLlamaServer_Good_InPATH(t *testing.T) {
|
|
// llama-server is at /usr/local/bin/llama-server on this machine.
|
|
path, err := findLlamaServer()
|
|
require.NoError(t, err)
|
|
assert.Contains(t, path, "llama-server")
|
|
}
|
|
|
|
func TestFindLlamaServer_Good_EnvOverride(t *testing.T) {
|
|
t.Setenv("ROCM_LLAMA_SERVER_PATH", "/usr/local/bin/llama-server")
|
|
path, err := findLlamaServer()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, "/usr/local/bin/llama-server", path)
|
|
}
|
|
|
|
func TestFindLlamaServer_Bad_EnvPathMissing(t *testing.T) {
|
|
t.Setenv("ROCM_LLAMA_SERVER_PATH", "/nonexistent/llama-server")
|
|
_, err := findLlamaServer()
|
|
assert.ErrorContains(t, err, "not found")
|
|
}
|
|
|
|
func TestFreePort_Good(t *testing.T) {
|
|
port, err := freePort()
|
|
require.NoError(t, err)
|
|
assert.Greater(t, port, 0)
|
|
assert.Less(t, port, 65536)
|
|
}
|
|
|
|
func TestFreePort_Good_UniquePerCall(t *testing.T) {
|
|
p1, err := freePort()
|
|
require.NoError(t, err)
|
|
p2, err := freePort()
|
|
require.NoError(t, err)
|
|
_ = p1
|
|
_ = p2
|
|
}
|
|
|
|
func TestServerEnv_Good_SetsHIPVisibleDevices(t *testing.T) {
|
|
env := serverEnv()
|
|
var hipVals []string
|
|
for _, e := range env {
|
|
if strings.HasPrefix(e, "HIP_VISIBLE_DEVICES=") {
|
|
hipVals = append(hipVals, e)
|
|
}
|
|
}
|
|
assert.Equal(t, []string{"HIP_VISIBLE_DEVICES=0"}, hipVals)
|
|
}
|
|
|
|
func TestServerEnv_Good_FiltersExistingHIPVisibleDevices(t *testing.T) {
|
|
t.Setenv("HIP_VISIBLE_DEVICES", "1")
|
|
env := serverEnv()
|
|
var hipVals []string
|
|
for _, e := range env {
|
|
if strings.HasPrefix(e, "HIP_VISIBLE_DEVICES=") {
|
|
hipVals = append(hipVals, e)
|
|
}
|
|
}
|
|
assert.Equal(t, []string{"HIP_VISIBLE_DEVICES=0"}, hipVals)
|
|
}
|
|
|
|
func TestAvailable_Good(t *testing.T) {
|
|
b := &rocmBackend{}
|
|
if _, err := os.Stat("/dev/kfd"); err != nil {
|
|
t.Skip("no ROCm hardware")
|
|
}
|
|
assert.True(t, b.Available())
|
|
}
|
|
|
|
func TestServerAlive_Good_Running(t *testing.T) {
|
|
s := &server{exited: make(chan struct{})}
|
|
assert.True(t, s.alive())
|
|
}
|
|
|
|
func TestServerAlive_Good_Exited(t *testing.T) {
|
|
exited := make(chan struct{})
|
|
close(exited)
|
|
s := &server{exited: exited, exitErr: coreerr.E("test", "process killed", nil)}
|
|
assert.False(t, s.alive())
|
|
}
|
|
|
|
func TestGenerate_Bad_ServerDead(t *testing.T) {
|
|
exited := make(chan struct{})
|
|
close(exited)
|
|
s := &server{
|
|
exited: exited,
|
|
exitErr: coreerr.E("test", "process killed", nil),
|
|
}
|
|
m := &rocmModel{server: s}
|
|
|
|
var count int
|
|
for range m.Generate(context.Background(), "hello") {
|
|
count++
|
|
}
|
|
assert.Equal(t, 0, count)
|
|
assert.ErrorContains(t, m.Err(), "server has exited")
|
|
}
|
|
|
|
func TestStartServer_Ugly_RetriesOnProcessExit(t *testing.T) {
|
|
// /bin/false starts successfully but exits immediately with code 1.
|
|
// startServer should retry up to 3 times, then fail.
|
|
_, err := startServer("/bin/false", "/nonexistent/model.gguf", 999, 0, 0)
|
|
require.Error(t, err)
|
|
assert.Contains(t, err.Error(), "failed after 3 attempts")
|
|
}
|
|
|
|
func TestChat_Bad_ServerDead(t *testing.T) {
|
|
exited := make(chan struct{})
|
|
close(exited)
|
|
s := &server{
|
|
exited: exited,
|
|
exitErr: coreerr.E("test", "process killed", nil),
|
|
}
|
|
m := &rocmModel{server: s}
|
|
|
|
msgs := []inference.Message{{Role: "user", Content: "hello"}}
|
|
var count int
|
|
for range m.Chat(context.Background(), msgs) {
|
|
count++
|
|
}
|
|
assert.Equal(t, 0, count)
|
|
assert.ErrorContains(t, m.Err(), "server has exited")
|
|
}
|