go-scm/gitea/issues_test.go
Claude 9db37c6fb3
test: add comprehensive unit tests for forge/, gitea/, git/, agentci/
Phase 1 test coverage for the three 0% packages plus agentci/ improvement:

- git/ (0% -> 79.5%): RepoStatus methods, status parsing with real temp
  repos, multi-repo parallel status, Push/Pull error paths, ahead/behind
  with bare remote, context cancellation, GitError, IsNonFastForward,
  service DirtyRepos/AheadRepos filtering

- forge/ (0% -> 91.2%): All SDK wrapper functions tested via httptest mock
  server — client creation, repos, issues, PRs, labels, webhooks, orgs,
  meta, config resolution, SetPRDraft raw HTTP endpoint

- gitea/ (0% -> 89.2%): All SDK wrapper functions tested via httptest mock
  server — client creation, repos, issues, PRs, meta, config resolution

- agentci/ (56% -> 94.5%): Clotho DeterminePlan all code paths, security
  helpers (SanitizePath, EscapeShellArg, SecureSSHCommand, MaskToken)

Key findings documented in FINDINGS.md:
- Forgejo SDK validates token via HTTP on NewClient()
- SDK route patterns differ from public API docs (/org/ vs /orgs/)
- Gitea SDK requires auth token for GitHub mirror creation
- Config resolution priority verified: config file < env vars < flags

Co-Authored-By: Charon <developers@lethean.io>
2026-02-20 00:59:46 +00:00

217 lines
5.1 KiB
Go

package gitea
import (
"testing"
giteaSDK "code.gitea.io/sdk/gitea"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
func TestClient_ListIssues_Good(t *testing.T) {
client, srv := newTestClient(t)
defer srv.Close()
issues, err := client.ListIssues("test-org", "org-repo", ListIssuesOpts{})
require.NoError(t, err)
require.Len(t, issues, 2)
assert.Equal(t, "Issue 1", issues[0].Title)
}
func TestClient_ListIssues_Good_StateMapping(t *testing.T) {
tests := []struct {
name string
state string
}{
{name: "open", state: "open"},
{name: "closed", state: "closed"},
{name: "all", state: "all"},
{name: "default (empty)", state: ""},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
client, srv := newTestClient(t)
defer srv.Close()
_, err := client.ListIssues("test-org", "org-repo", ListIssuesOpts{State: tt.state})
require.NoError(t, err)
})
}
}
func TestClient_ListIssues_Good_CustomPageAndLimit(t *testing.T) {
client, srv := newTestClient(t)
defer srv.Close()
_, err := client.ListIssues("test-org", "org-repo", ListIssuesOpts{
Page: 2,
Limit: 10,
})
require.NoError(t, err)
}
func TestClient_ListIssues_Bad_ServerError(t *testing.T) {
client, srv := newErrorServer(t)
defer srv.Close()
_, err := client.ListIssues("test-org", "org-repo", ListIssuesOpts{})
assert.Error(t, err)
assert.Contains(t, err.Error(), "failed to list issues")
}
func TestClient_GetIssue_Good(t *testing.T) {
client, srv := newTestClient(t)
defer srv.Close()
issue, err := client.GetIssue("test-org", "org-repo", 1)
require.NoError(t, err)
assert.Equal(t, "Issue 1", issue.Title)
}
func TestClient_GetIssue_Bad_ServerError(t *testing.T) {
client, srv := newErrorServer(t)
defer srv.Close()
_, err := client.GetIssue("test-org", "org-repo", 1)
assert.Error(t, err)
assert.Contains(t, err.Error(), "failed to get issue")
}
func TestClient_CreateIssue_Good(t *testing.T) {
client, srv := newTestClient(t)
defer srv.Close()
issue, err := client.CreateIssue("test-org", "org-repo", giteaSDK.CreateIssueOption{
Title: "New Issue",
Body: "Issue description",
})
require.NoError(t, err)
assert.NotNil(t, issue)
}
func TestClient_CreateIssue_Bad_ServerError(t *testing.T) {
client, srv := newErrorServer(t)
defer srv.Close()
_, err := client.CreateIssue("test-org", "org-repo", giteaSDK.CreateIssueOption{
Title: "New Issue",
})
assert.Error(t, err)
assert.Contains(t, err.Error(), "failed to create issue")
}
func TestClient_ListPullRequests_Good(t *testing.T) {
client, srv := newTestClient(t)
defer srv.Close()
prs, err := client.ListPullRequests("test-org", "org-repo", "open")
require.NoError(t, err)
require.Len(t, prs, 1)
assert.Equal(t, "PR 1", prs[0].Title)
}
func TestClient_ListPullRequests_Good_StateMapping(t *testing.T) {
tests := []struct {
name string
state string
}{
{name: "open", state: "open"},
{name: "closed", state: "closed"},
{name: "all", state: "all"},
{name: "default (empty)", state: ""},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
client, srv := newTestClient(t)
defer srv.Close()
_, err := client.ListPullRequests("test-org", "org-repo", tt.state)
require.NoError(t, err)
})
}
}
func TestClient_ListPullRequests_Bad_ServerError(t *testing.T) {
client, srv := newErrorServer(t)
defer srv.Close()
_, err := client.ListPullRequests("test-org", "org-repo", "open")
assert.Error(t, err)
assert.Contains(t, err.Error(), "failed to list pull requests")
}
func TestClient_GetPullRequest_Good(t *testing.T) {
client, srv := newTestClient(t)
defer srv.Close()
pr, err := client.GetPullRequest("test-org", "org-repo", 1)
require.NoError(t, err)
assert.Equal(t, "PR 1", pr.Title)
}
func TestClient_GetPullRequest_Bad_ServerError(t *testing.T) {
client, srv := newErrorServer(t)
defer srv.Close()
_, err := client.GetPullRequest("test-org", "org-repo", 1)
assert.Error(t, err)
assert.Contains(t, err.Error(), "failed to get pull request")
}
// --- ListIssuesOpts defaulting ---
func TestListIssuesOpts_Defaults(t *testing.T) {
tests := []struct {
name string
opts ListIssuesOpts
expectedState string
expectedLimit int
expectedPage int
}{
{
name: "all defaults",
opts: ListIssuesOpts{},
expectedState: "open",
expectedLimit: 50,
expectedPage: 1,
},
{
name: "closed state",
opts: ListIssuesOpts{State: "closed"},
expectedState: "closed",
expectedLimit: 50,
expectedPage: 1,
},
{
name: "custom limit and page",
opts: ListIssuesOpts{Page: 3, Limit: 25},
expectedState: "open",
expectedLimit: 25,
expectedPage: 3,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
if tt.opts.State == "" {
tt.opts.State = "open"
}
assert.Equal(t, tt.expectedState, tt.opts.State)
limit := tt.opts.Limit
if limit == 0 {
limit = 50
}
assert.Equal(t, tt.expectedLimit, limit)
page := tt.opts.Page
if page == 0 {
page = 1
}
assert.Equal(t, tt.expectedPage, page)
})
}
}