go-scm/cmd
Snider 913b8fc960 fix(review): address CodeRabbit PR #2 round-2 findings
- manifest/compile.go: apply opts.Version override before empty-version check
  so version can be supplied via CompileOptions even when manifest has none
- manifest/compile.go: fix import grouping (stdlib before internal)
- pkg/api/provider.go: propagate c.Request.Context() into Install/Update calls
  so client disconnects cancel long-running operations
- pkg/api/provider.go: guard refreshMarketplace against path traversal; suppress
  raw filesystem errors from HTTP response
- pkg/api/provider.go: normalise typed-nil installer in NewProvider to prevent
  nil-pointer panics from non-nil interface holding nil pointer
- jobrunner/journal.go: upgrade sync.Mutex to sync.RWMutex; Query uses RLock
  for concurrent read throughput
- jobrunner/journal.go: use bytes.NewReader(data) instead of
  strings.NewReader(string(data)) to avoid double allocation
- jobrunner/journal.go: fix import grouping (stdlib before internal)
- internal/ax/stringsx/stringsx.go: fix Builder alias to strings.Builder
  (was bytes.Buffer — different copy-after-write semantics)
- internal/ax/stringsx/stringsx.go: fix NewReader to return *strings.Reader
- internal/ax/stringsx/stringsx.go: make SplitSeq lazy (no upfront []string)
- internal/ax/stringsx/stringsx.go: remove bytes import; use stdlib strings
  for ContainsAny, EqualFold, LastIndex
- gitea/client.go: fix import grouping (internal before third-party)
- gitea/prs.go: fix import grouping (internal before third-party)
- forge/labels.go: fix import grouping (internal before third-party)
- cmd/gitea/cmd_sync.go: move exec (golang.org/x/sys/execabs) to third-party
  import group
- forge/orgs_test.go: add t.Setenv("HOME", t.TempDir()) for config isolation
- forge/orgs_test.go: rename *_Bad_ServerError_Good → *_Bad_ServerError
- gitea/repos_test.go: add HOME isolation to CreateMirrorFromService test

Co-Authored-By: Virgil <virgil@lethean.io>
2026-04-07 10:29:22 +01:00
..
collect fix(review): address CodeRabbit PR #2 findings 2026-04-07 09:25:42 +01:00
forge fix(review): address CodeRabbit PR #2 findings 2026-04-07 09:25:42 +01:00
gitea fix(review): address CodeRabbit PR #2 round-2 findings 2026-04-07 10:29:22 +01:00
internal/syncutil fix(review): address CodeRabbit PR #2 findings 2026-04-07 09:25:42 +01:00
scm fix(review): address CodeRabbit PR #2 findings 2026-04-07 09:25:42 +01:00