core/go-store
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions 2

Merge pull request '[agent/codex:gpt-5.4-mini] Read ~/spec/code/core/go/store/RFC.md fully. Find features d...' (#111) from agent/read---spec-code-core-go-store-rfc-md-fu into dev
Some checks are pending
Security Scan / security (push) Waiting to run
Details
Test / test (push) Waiting to run
Details

Browse source
This commit is contained in:
Virgil 2026-04-04 09:35:10 +00:00
commit 80ba2afd44
3 changed files with 55 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
doc.go
View file

@ -58,10 +58,12 @@
// })
// defer unregister()
//
// scopedStore, err := store.NewScopedWithQuota(
// scopedStore, err := store.NewScopedConfigured(
// configuredStore,
// "tenant-a",
// store.QuotaConfig{MaxKeys: 100, MaxGroups: 10},
// store.ScopedStoreConfig{
// Namespace: "tenant-a",
// Quota: store.QuotaConfig{MaxKeys: 100, MaxGroups: 10},
// },
// )
// if err != nil {
// return

36
scope.go
View file

@ -33,6 +33,14 @@ type ScopedStore struct {
scopedWatchers map[uintptr]*scopedWatcherBinding
}
// Usage example: `config := store.ScopedStoreConfig{Namespace: "tenant-a", Quota: store.QuotaConfig{MaxKeys: 100, MaxGroups: 10}}`
type ScopedStoreConfig struct {
// Usage example: `config := store.ScopedStoreConfig{Namespace: "tenant-a"}`
Namespace string
// Usage example: `config := store.ScopedStoreConfig{Quota: store.QuotaConfig{MaxKeys: 100, MaxGroups: 10}}`
Quota QuotaConfig
}
type scopedWatcherBinding struct {
backingStore *Store
underlyingEvents <-chan Event
@ -66,27 +74,35 @@ func NewScoped(storeInstance *Store, namespace string) *ScopedStore {
return scopedStore
}
// Usage example: `scopedStore, err := store.NewScopedWithQuota(storeInstance, "tenant-a", store.QuotaConfig{MaxKeys: 100, MaxGroups: 10}); if err != nil { return }`
func NewScopedWithQuota(storeInstance *Store, namespace string, quota QuotaConfig) (*ScopedStore, error) {
scopedStore := NewScoped(storeInstance, namespace)
// Usage example: `scopedStore, err := store.NewScopedConfigured(storeInstance, store.ScopedStoreConfig{Namespace: "tenant-a", Quota: store.QuotaConfig{MaxKeys: 100, MaxGroups: 10}}); if err != nil { return }`
func NewScopedConfigured(storeInstance *Store, config ScopedStoreConfig) (*ScopedStore, error) {
scopedStore := NewScoped(storeInstance, config.Namespace)
if scopedStore == nil {
if storeInstance == nil {
return nil, core.E("store.NewScopedWithQuota", "store instance is nil", nil)
return nil, core.E("store.NewScopedConfigured", "store instance is nil", nil)
}
return nil, core.E("store.NewScopedWithQuota", core.Sprintf("namespace %q is invalid; use names like %q or %q", namespace, "tenant-a", "tenant-42"), nil)
return nil, core.E("store.NewScopedConfigured", core.Sprintf("namespace %q is invalid; use names like %q or %q", config.Namespace, "tenant-a", "tenant-42"), nil)
}
if quota.MaxKeys < 0 || quota.MaxGroups < 0 {
if config.Quota.MaxKeys < 0 || config.Quota.MaxGroups < 0 {
return nil, core.E(
"store.NewScopedWithQuota",
core.Sprintf("quota values must be zero or positive; got MaxKeys=%d MaxGroups=%d", quota.MaxKeys, quota.MaxGroups),
"store.NewScopedConfigured",
core.Sprintf("quota values must be zero or positive; got MaxKeys=%d MaxGroups=%d", config.Quota.MaxKeys, config.Quota.MaxGroups),
nil,
)
}
scopedStore.MaxKeys = quota.MaxKeys
scopedStore.MaxGroups = quota.MaxGroups
scopedStore.MaxKeys = config.Quota.MaxKeys
scopedStore.MaxGroups = config.Quota.MaxGroups
return scopedStore, nil
}
// Usage example: `scopedStore, err := store.NewScopedWithQuota(storeInstance, "tenant-a", store.QuotaConfig{MaxKeys: 100, MaxGroups: 10}); if err != nil { return }`
func NewScopedWithQuota(storeInstance *Store, namespace string, quota QuotaConfig) (*ScopedStore, error) {
return NewScopedConfigured(storeInstance, ScopedStoreConfig{
Namespace: namespace,
Quota: quota,
})
}
func (scopedStore *ScopedStore) namespacedGroup(group string) string {
return scopedStore.namespace + ":" + group
}

24
scope_test.go
View file

@ -102,6 +102,30 @@ func TestScope_NewScopedWithQuota_Good_InlineQuotaFields(t *testing.T) {
assert.Equal(t, 2, scopedStore.MaxGroups)
}
func TestScope_NewScopedConfigured_Good(t *testing.T) {
storeInstance, _ := New(":memory:")
defer storeInstance.Close()
scopedStore, err := NewScopedConfigured(storeInstance, ScopedStoreConfig{
Namespace: "tenant-a",
Quota: QuotaConfig{MaxKeys: 4, MaxGroups: 2},
})
require.NoError(t, err)
assert.Equal(t, "tenant-a", scopedStore.Namespace())
assert.Equal(t, 4, scopedStore.MaxKeys)
assert.Equal(t, 2, scopedStore.MaxGroups)
}
func TestScope_NewScopedConfigured_Bad_InvalidNamespace(t *testing.T) {
storeInstance, _ := New(":memory:")
defer storeInstance.Close()
_, err := NewScopedConfigured(storeInstance, ScopedStoreConfig{Namespace: "tenant_a"})
require.Error(t, err)
assert.Contains(t, err.Error(), "namespace")
}
// ---------------------------------------------------------------------------
// ScopedStore — basic CRUD
// ---------------------------------------------------------------------------