[ax] Migrate strings.*, fmt.Sprintf to core primitives #4

New issue

Open

opened 2026-03-22 16:39:15 +00:00 by Virgil · 1 comment

Virgil commented

2026-03-22 16:39:15 +00:00

Member

AX sweep findings:

MEDIUM — strings. in production code*

store.go:68 strings.Contains
store.go:234 strings.SplitSeq
store.go:244 strings.FieldsSeq
store.go:262 strings.Builder
store.go:347-349 strings.ReplaceAll (3 hits)

MEDIUM — fmt.Sprintf in production code

scope.go:36, :148, :168

LOW — Test files using stdlib (30+ hits)

fmt.Sprintf in bench_test.go, coverage_test.go, events_test.go, store_test.go
filepath.Join in coverage_test.go, store_test.go
strings.Repeat in store_test.go
fmt.Errorf in store_test.go

No os.Getenv found. No UK spelling issues. Coverage at 89.1%.

AX sweep findings: **MEDIUM — strings.* in production code** - store.go:68 strings.Contains - store.go:234 strings.SplitSeq - store.go:244 strings.FieldsSeq - store.go:262 strings.Builder - store.go:347-349 strings.ReplaceAll (3 hits) **MEDIUM — fmt.Sprintf in production code** - scope.go:36, :148, :168 **LOW — Test files using stdlib (30+ hits)** - fmt.Sprintf in bench_test.go, coverage_test.go, events_test.go, store_test.go - filepath.Join in coverage_test.go, store_test.go - strings.Repeat in store_test.go - fmt.Errorf in store_test.go No os.Getenv found. No UK spelling issues. Coverage at 89.1%.

Virgil commented

2026-03-23 09:46:16 +00:00

Author

Member

Fact-Finding: API Contract Extraction

Full inventory of exported API surface completed. Key stats:

Most exports have test coverage
Zero exports have usage-example comments
ScopedStore.All() iterator missing test coverage

This inventory feeds into RFC specs and contract test generation. Full table in agent log.

## Fact-Finding: API Contract Extraction Full inventory of exported API surface completed. Key stats: - Most exports have test coverage - Zero exports have usage-example comments - ScopedStore.All() iterator missing test coverage This inventory feeds into RFC specs and contract test generation. Full table in agent log.