644986b8bb
- Remove fmt from updater.go, service.go, http_client.go, cmd.go, github.go, generic_http.go; replace with string concat, coreerr.E, cli.Print
- Remove strings from updater.go (inline byte comparisons) and service.go (inline helpers)
- Replace fmt.Sprintf in error paths with string concatenation throughout
- Add cli.Print for all stdout output in updater.go (CheckForUpdates, CheckOnly, etc.)
- Fix service_examples_test.go: restore original CheckForUpdates instead of setting nil
- Test naming: all test files now follow TestFile_Function_{Good,Bad,Ugly} with all three variants mandatory
- Comments: replace prose descriptions with usage-example style on all exported functions
- Remaining banned: strings/encoding/json in github.go and generic_http.go (no Core replacement in direct deps); os/os.exec in platform files (syscall-level, unavoidable without go-process)
Co-Authored-By: Virgil <virgil@lethean.io>
73 lines
1.7 KiB
Go
73 lines
1.7 KiB
Go
//go:build !windows
|
|
|
|
package updater
|
|
|
|
import (
|
|
"os"
|
|
"os/exec"
|
|
"strconv"
|
|
"syscall"
|
|
"time"
|
|
)
|
|
|
|
// spawnWatcher spawns a detached background process that restarts the binary after the current process exits.
|
|
//
|
|
// if err := spawnWatcher(); err != nil { /* non-fatal: update proceeds anyway */ }
|
|
func spawnWatcher() error {
|
|
executable, err := os.Executable()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
pid := os.Getpid()
|
|
|
|
// Spawn: core update --watch-pid=<pid>
|
|
cmd := exec.Command(executable, "update", "--watch-pid", strconv.Itoa(pid))
|
|
cmd.Stdout = os.Stdout
|
|
cmd.Stderr = os.Stderr
|
|
|
|
// Detach from parent process group
|
|
cmd.SysProcAttr = &syscall.SysProcAttr{
|
|
Setpgid: true,
|
|
}
|
|
|
|
return cmd.Start()
|
|
}
|
|
|
|
// watchAndRestart polls until the given PID exits, then exec-replaces itself with --version.
|
|
//
|
|
// return watchAndRestart(os.Getppid())
|
|
func watchAndRestart(pid int) error {
|
|
// Wait for the parent process to die
|
|
for isProcessRunning(pid) {
|
|
|
|
time.Sleep(100 * time.Millisecond)
|
|
}
|
|
|
|
// Small delay to ensure file handle is released
|
|
time.Sleep(200 * time.Millisecond)
|
|
|
|
// Get executable path
|
|
executable, err := os.Executable()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Use exec to replace this process
|
|
return syscall.Exec(executable, []string{executable, "--version"}, os.Environ())
|
|
}
|
|
|
|
// isProcessRunning returns true if a process with the given PID is still running.
|
|
//
|
|
// for isProcessRunning(parentPID) { time.Sleep(100 * time.Millisecond) }
|
|
func isProcessRunning(pid int) bool {
|
|
process, err := os.FindProcess(pid)
|
|
if err != nil {
|
|
return false
|
|
}
|
|
|
|
// On Unix, FindProcess always succeeds, so we need to send signal 0
|
|
// to check if the process actually exists
|
|
err = process.Signal(syscall.Signal(0))
|
|
return err == nil
|
|
}
|