From e646d42cf70cb88216451bc17cd6f144d7f1e2de Mon Sep 17 00:00:00 2001 From: Snider Date: Sat, 25 Apr 2026 06:04:29 +0100 Subject: [PATCH] fix(webview): replace log.Fatal with Core error handling in doc + code (#712) Package doc example in webview.go now uses run() error pattern, wraps failures with core.E(), prints to stderr via core.Print, exits from main with os.Exit(1). No real log.Fatal call sites existed in webview.go (doc-only fix). Build + race tests green. Co-authored-by: Codex Closes tasks.lthn.sh/view.php?id=712 --- webview.go | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/webview.go b/webview.go index c111eff..e516e2c 100644 --- a/webview.go +++ b/webview.go @@ -7,18 +7,29 @@ // // Example usage: // -// wv, err := webview.New(webview.WithDebugURL("http://localhost:9222")) -// if err != nil { -// log.Fatal(err) -// } -// defer wv.Close() -// -// if err := wv.Navigate("https://example.com"); err != nil { -// log.Fatal(err) +// func main() { +// if err := run(); err != nil { +// core.Print(os.Stderr, "webview example: %v", err) +// os.Exit(1) +// } // } // -// if err := wv.Click("#submit-button"); err != nil { -// log.Fatal(err) +// func run() error { +// wv, err := webview.New(webview.WithDebugURL("http://localhost:9222")) +// if err != nil { +// return core.E("webview.example", "create webview", err) +// } +// defer wv.Close() +// +// if err := wv.Navigate("https://example.com"); err != nil { +// return core.E("webview.example", "navigate", err) +// } +// +// if err := wv.Click("#submit-button"); err != nil { +// return core.E("webview.example", "click submit button", err) +// } +// +// return nil // } package webview