core/go-webview
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

Align console filters with spec

Browse source
This commit is contained in:
Snider 2026-04-15 14:17:21 +01:00
parent 3002b4801d
commit f4a094e87c
2 changed files with 19 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
console.go
View file

@ -441,17 +441,21 @@ func (cw *ConsoleWatcher) addMessage(msg ConsoleMessage) {
}
}
// matchesFilter checks if a message matches any filter.
// matchesFilter checks whether a message matches the active filter set.
//
// When no filters are configured, every message matches. When filters exist,
// the watcher uses OR semantics: a message is included as soon as it matches
// one configured filter.
func (cw *ConsoleWatcher) matchesFilter(msg ConsoleMessage) bool {
if len(cw.filters) == 0 {
return true
}
for _, filter := range cw.filters {
if !cw.matchesSingleFilter(msg, filter) {
return false
if cw.matchesSingleFilter(msg, filter) {
return true
}
}
return true
return false
}
// matchesSingleFilter checks if a message matches a specific filter.

16
webview_test.go
View file

@ -778,8 +778,8 @@ func TestConsoleWatcherFilteredMessages_Good(t *testing.T) {
}
}
// TestConsoleWatcherFilteredMessages_Good_RequiresAllActiveFilters verifies filters compose as an intersection.
func TestConsoleWatcherFilteredMessages_Good_RequiresAllActiveFilters(t *testing.T) {
// TestConsoleWatcherFilteredMessages_Good_UsesAnyActiveFilter verifies filters compose as a union.
func TestConsoleWatcherFilteredMessages_Good_UsesAnyActiveFilter(t *testing.T) {
cw := &ConsoleWatcher{
messages: []ConsoleMessage{
{Type: "error", Text: "boom happened"},
@ -795,11 +795,17 @@ func TestConsoleWatcherFilteredMessages_Good_RequiresAllActiveFilters(t *testing
}
filtered := cw.FilteredMessages()
if len(filtered) != 1 {
t.Fatalf("Expected 1 filtered message, got %d", len(filtered))
if len(filtered) != 3 {
t.Fatalf("Expected 3 filtered messages, got %d", len(filtered))
}
if filtered[0].Text != "boom happened" {
t.Fatalf("Expected the intersection match, got %q", filtered[0].Text)
t.Fatalf("Expected the first matching message, got %q", filtered[0].Text)
}
if filtered[1].Text != "different message" {
t.Fatalf("Expected the second stored message to remain visible, got %q", filtered[1].Text)
}
if filtered[2].Text != "boom happened" {
t.Fatalf("Expected the log message matching the pattern filter, got %q", filtered[2].Text)
}
}