feat: restructure Core as unified struct with DTO pattern
Complete architectural overhaul of pkg/core:
- All subsystem types renamed to idiomatic Go (no stutter)
- Core struct: App, Embed, Fs, Config, ErrPan, ErrLog, Cli, Service, Lock, Ipc, I18n
- Exports consolidated in core.go, contracts/options in contract.go
- Service() unified get/register: c.Service(), c.Service("name"), c.Service("name", svc)
- Lock() named mutex map: c.Lock("srv"), c.Lock("ipc")
- Error system: Err/ErrLog/ErrPan + Log/LogErr/LogPan (shared ErrSink interface)
- CoreCommand with optional description (i18n resolves from command path)
- Tests moved to tests/ directory (black-box package core_test)
- Removed: ServiceFor/MustServiceFor, global instance, Display/Workspace/Crypt interfaces
- New files: app.go, fs.go, ipc.go, lock.go, i18n.go, task.go, runtime.go, contract.go
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-18 09:12:29 +00:00
|
|
|
package core_test
|
|
|
|
|
|
2026-01-30 10:18:54 +00:00
|
|
|
|
|
|
|
|
import (
|
feat: restructure Core as unified struct with DTO pattern
Complete architectural overhaul of pkg/core:
- All subsystem types renamed to idiomatic Go (no stutter)
- Core struct: App, Embed, Fs, Config, ErrPan, ErrLog, Cli, Service, Lock, Ipc, I18n
- Exports consolidated in core.go, contracts/options in contract.go
- Service() unified get/register: c.Service(), c.Service("name"), c.Service("name", svc)
- Lock() named mutex map: c.Lock("srv"), c.Lock("ipc")
- Error system: Err/ErrLog/ErrPan + Log/LogErr/LogPan (shared ErrSink interface)
- CoreCommand with optional description (i18n resolves from command path)
- Tests moved to tests/ directory (black-box package core_test)
- Removed: ServiceFor/MustServiceFor, global instance, Display/Workspace/Crypt interfaces
- New files: app.go, fs.go, ipc.go, lock.go, i18n.go, task.go, runtime.go, contract.go
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-18 09:12:29 +00:00
|
|
|
. "forge.lthn.ai/core/go/pkg/core"
|
2026-01-30 10:18:54 +00:00
|
|
|
"errors"
|
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
type TestQuery struct {
|
|
|
|
|
Value string
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
type TestTask struct {
|
|
|
|
|
Value string
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestCore_QUERY_Good(t *testing.T) {
|
|
|
|
|
c, err := New()
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
// Register a handler that responds to TestQuery
|
|
|
|
|
c.RegisterQuery(func(c *Core, q Query) (any, bool, error) {
|
|
|
|
|
if tq, ok := q.(TestQuery); ok {
|
|
|
|
|
return "result-" + tq.Value, true, nil
|
|
|
|
|
}
|
|
|
|
|
return nil, false, nil
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
result, handled, err := c.QUERY(TestQuery{Value: "test"})
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.True(t, handled)
|
|
|
|
|
assert.Equal(t, "result-test", result)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestCore_QUERY_NotHandled(t *testing.T) {
|
|
|
|
|
c, err := New()
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
// No handlers registered
|
|
|
|
|
result, handled, err := c.QUERY(TestQuery{Value: "test"})
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.False(t, handled)
|
|
|
|
|
assert.Nil(t, result)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestCore_QUERY_FirstResponder(t *testing.T) {
|
|
|
|
|
c, err := New()
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
// First handler responds
|
|
|
|
|
c.RegisterQuery(func(c *Core, q Query) (any, bool, error) {
|
|
|
|
|
return "first", true, nil
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
// Second handler would respond but shouldn't be called
|
|
|
|
|
c.RegisterQuery(func(c *Core, q Query) (any, bool, error) {
|
|
|
|
|
return "second", true, nil
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
result, handled, err := c.QUERY(TestQuery{})
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.True(t, handled)
|
|
|
|
|
assert.Equal(t, "first", result)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestCore_QUERY_SkipsNonHandlers(t *testing.T) {
|
|
|
|
|
c, err := New()
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
// First handler doesn't handle
|
|
|
|
|
c.RegisterQuery(func(c *Core, q Query) (any, bool, error) {
|
|
|
|
|
return nil, false, nil
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
// Second handler responds
|
|
|
|
|
c.RegisterQuery(func(c *Core, q Query) (any, bool, error) {
|
|
|
|
|
return "second", true, nil
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
result, handled, err := c.QUERY(TestQuery{})
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.True(t, handled)
|
|
|
|
|
assert.Equal(t, "second", result)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestCore_QUERYALL_Good(t *testing.T) {
|
|
|
|
|
c, err := New()
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
// Multiple handlers respond
|
|
|
|
|
c.RegisterQuery(func(c *Core, q Query) (any, bool, error) {
|
|
|
|
|
return "first", true, nil
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
c.RegisterQuery(func(c *Core, q Query) (any, bool, error) {
|
|
|
|
|
return "second", true, nil
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
c.RegisterQuery(func(c *Core, q Query) (any, bool, error) {
|
|
|
|
|
return nil, false, nil // Doesn't handle
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
results, err := c.QUERYALL(TestQuery{})
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.Len(t, results, 2)
|
|
|
|
|
assert.Contains(t, results, "first")
|
|
|
|
|
assert.Contains(t, results, "second")
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestCore_QUERYALL_AggregatesErrors(t *testing.T) {
|
|
|
|
|
c, err := New()
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
err1 := errors.New("error1")
|
|
|
|
|
err2 := errors.New("error2")
|
|
|
|
|
|
|
|
|
|
c.RegisterQuery(func(c *Core, q Query) (any, bool, error) {
|
|
|
|
|
return "result1", true, err1
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
c.RegisterQuery(func(c *Core, q Query) (any, bool, error) {
|
|
|
|
|
return "result2", true, err2
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
results, err := c.QUERYALL(TestQuery{})
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.ErrorIs(t, err, err1)
|
|
|
|
|
assert.ErrorIs(t, err, err2)
|
|
|
|
|
assert.Len(t, results, 2)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestCore_PERFORM_Good(t *testing.T) {
|
|
|
|
|
c, err := New()
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
executed := false
|
|
|
|
|
c.RegisterTask(func(c *Core, t Task) (any, bool, error) {
|
|
|
|
|
if tt, ok := t.(TestTask); ok {
|
|
|
|
|
executed = true
|
|
|
|
|
return "done-" + tt.Value, true, nil
|
|
|
|
|
}
|
|
|
|
|
return nil, false, nil
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
result, handled, err := c.PERFORM(TestTask{Value: "work"})
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.True(t, handled)
|
|
|
|
|
assert.True(t, executed)
|
|
|
|
|
assert.Equal(t, "done-work", result)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestCore_PERFORM_NotHandled(t *testing.T) {
|
|
|
|
|
c, err := New()
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
// No handlers registered
|
|
|
|
|
result, handled, err := c.PERFORM(TestTask{Value: "work"})
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.False(t, handled)
|
|
|
|
|
assert.Nil(t, result)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestCore_PERFORM_FirstResponder(t *testing.T) {
|
|
|
|
|
c, err := New()
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
callCount := 0
|
|
|
|
|
|
|
|
|
|
c.RegisterTask(func(c *Core, t Task) (any, bool, error) {
|
|
|
|
|
callCount++
|
|
|
|
|
return "first", true, nil
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
c.RegisterTask(func(c *Core, t Task) (any, bool, error) {
|
|
|
|
|
callCount++
|
|
|
|
|
return "second", true, nil
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
result, handled, err := c.PERFORM(TestTask{})
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
assert.True(t, handled)
|
|
|
|
|
assert.Equal(t, "first", result)
|
|
|
|
|
assert.Equal(t, 1, callCount) // Only first handler called
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestCore_PERFORM_WithError(t *testing.T) {
|
|
|
|
|
c, err := New()
|
|
|
|
|
assert.NoError(t, err)
|
|
|
|
|
|
|
|
|
|
expectedErr := errors.New("task failed")
|
|
|
|
|
c.RegisterTask(func(c *Core, t Task) (any, bool, error) {
|
|
|
|
|
return nil, true, expectedErr
|
|
|
|
|
})
|
|
|
|
|
|
|
|
|
|
result, handled, err := c.PERFORM(TestTask{})
|
|
|
|
|
assert.Error(t, err)
|
|
|
|
|
assert.ErrorIs(t, err, expectedErr)
|
|
|
|
|
assert.True(t, handled)
|
|
|
|
|
assert.Nil(t, result)
|
|
|
|
|
}
|