feat(mcp): add workspace root validation to prevent path traversal (#100)
* feat(mcp): add workspace root validation to prevent path traversal
- Add workspaceRoot field to Service for restricting file operations
- Add WithWorkspaceRoot() option for configuring the workspace directory
- Add validatePath() helper to check paths are within workspace
- Apply validation to all file operation handlers
- Default to current working directory for security
- Add comprehensive tests for path validation
Closes #82
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor: move CLI commands from pkg/ to internal/cmd/
- Move 18 CLI command packages to internal/cmd/ (not externally importable)
- Keep 16 library packages in pkg/ (externally importable)
- Update all import paths throughout codebase
- Cleaner separation between CLI logic and reusable libraries
CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor,
php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace
Libraries remaining: agentic, build, cache, cli, container, devops,
errors, framework, git, i18n, io, log, mcp, process, release, repos
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor(mcp): use pkg/io Medium for sandboxed file operations
Replace manual path validation with pkg/io.Medium for all file operations.
This delegates security (path traversal, symlink bypass) to the sandboxed
local.Medium implementation.
Changes:
- Add io.NewSandboxed() for creating sandboxed Medium instances
- Refactor MCP Service to use io.Medium instead of direct os.* calls
- Remove validatePath and resolvePathWithSymlinks functions
- Update tests to verify Medium-based behaviour
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: correct import path and workflow references
- Fix pkg/io/io.go import from core-gui to core
- Update CI workflows to use internal/cmd/updater path
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(security): address CodeRabbit review issues for path validation
- pkg/io/local: add symlink resolution and boundary-aware containment
- Reject absolute paths in sandboxed Medium
- Use filepath.EvalSymlinks to prevent symlink bypass attacks
- Fix prefix check to prevent /tmp/root matching /tmp/root2
- pkg/mcp: fix resolvePath to validate and return errors
- Changed resolvePath from (string) to (string, error)
- Update deleteFile, renameFile, listDirectory, fileExists to handle errors
- Changed New() to return (*Service, error) instead of *Service
- Properly propagate option errors instead of silently discarding
- pkg/io: wrap errors with E() helper for consistent context
- Copy() and MockMedium.Read() now use coreerr.E()
- tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines
- Fix hardcoded /tmp in TestPath to use t.TempDir()
- Add TestResolvePath_Bad_SymlinkTraversal test
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting across all files
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 21:59:34 +00:00
|
|
|
package io
|
|
|
|
|
|
|
|
|
|
import (
|
2026-02-01 22:50:55 +00:00
|
|
|
"os"
|
feat(mcp): add workspace root validation to prevent path traversal (#100)
* feat(mcp): add workspace root validation to prevent path traversal
- Add workspaceRoot field to Service for restricting file operations
- Add WithWorkspaceRoot() option for configuring the workspace directory
- Add validatePath() helper to check paths are within workspace
- Apply validation to all file operation handlers
- Default to current working directory for security
- Add comprehensive tests for path validation
Closes #82
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor: move CLI commands from pkg/ to internal/cmd/
- Move 18 CLI command packages to internal/cmd/ (not externally importable)
- Keep 16 library packages in pkg/ (externally importable)
- Update all import paths throughout codebase
- Cleaner separation between CLI logic and reusable libraries
CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor,
php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace
Libraries remaining: agentic, build, cache, cli, container, devops,
errors, framework, git, i18n, io, log, mcp, process, release, repos
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor(mcp): use pkg/io Medium for sandboxed file operations
Replace manual path validation with pkg/io.Medium for all file operations.
This delegates security (path traversal, symlink bypass) to the sandboxed
local.Medium implementation.
Changes:
- Add io.NewSandboxed() for creating sandboxed Medium instances
- Refactor MCP Service to use io.Medium instead of direct os.* calls
- Remove validatePath and resolvePathWithSymlinks functions
- Update tests to verify Medium-based behaviour
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: correct import path and workflow references
- Fix pkg/io/io.go import from core-gui to core
- Update CI workflows to use internal/cmd/updater path
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(security): address CodeRabbit review issues for path validation
- pkg/io/local: add symlink resolution and boundary-aware containment
- Reject absolute paths in sandboxed Medium
- Use filepath.EvalSymlinks to prevent symlink bypass attacks
- Fix prefix check to prevent /tmp/root matching /tmp/root2
- pkg/mcp: fix resolvePath to validate and return errors
- Changed resolvePath from (string) to (string, error)
- Update deleteFile, renameFile, listDirectory, fileExists to handle errors
- Changed New() to return (*Service, error) instead of *Service
- Properly propagate option errors instead of silently discarding
- pkg/io: wrap errors with E() helper for consistent context
- Copy() and MockMedium.Read() now use coreerr.E()
- tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines
- Fix hardcoded /tmp in TestPath to use t.TempDir()
- Add TestResolvePath_Bad_SymlinkTraversal test
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting across all files
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 21:59:34 +00:00
|
|
|
|
|
|
|
|
coreerr "github.com/host-uk/core/pkg/framework/core"
|
|
|
|
|
"github.com/host-uk/core/pkg/io/local"
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
// Medium defines the standard interface for a storage backend.
|
|
|
|
|
// This allows for different implementations (e.g., local disk, S3, SFTP)
|
|
|
|
|
// to be used interchangeably.
|
|
|
|
|
type Medium interface {
|
|
|
|
|
// Read retrieves the content of a file as a string.
|
|
|
|
|
Read(path string) (string, error)
|
|
|
|
|
|
|
|
|
|
// Write saves the given content to a file, overwriting it if it exists.
|
|
|
|
|
Write(path, content string) error
|
|
|
|
|
|
|
|
|
|
// EnsureDir makes sure a directory exists, creating it if necessary.
|
|
|
|
|
EnsureDir(path string) error
|
|
|
|
|
|
|
|
|
|
// IsFile checks if a path exists and is a regular file.
|
|
|
|
|
IsFile(path string) bool
|
|
|
|
|
|
|
|
|
|
// FileGet is a convenience function that reads a file from the medium.
|
|
|
|
|
FileGet(path string) (string, error)
|
|
|
|
|
|
|
|
|
|
// FileSet is a convenience function that writes a file to the medium.
|
|
|
|
|
FileSet(path, content string) error
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Local is a pre-initialized medium for the local filesystem.
|
|
|
|
|
// It uses "/" as root, providing unsandboxed access to the filesystem.
|
|
|
|
|
// For sandboxed access, use NewSandboxed with a specific root path.
|
|
|
|
|
var Local Medium
|
|
|
|
|
|
|
|
|
|
func init() {
|
|
|
|
|
var err error
|
|
|
|
|
Local, err = local.New("/")
|
|
|
|
|
if err != nil {
|
|
|
|
|
panic("io: failed to initialize Local medium: " + err.Error())
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// NewSandboxed creates a new Medium sandboxed to the given root directory.
|
|
|
|
|
// All file operations are restricted to paths within the root.
|
|
|
|
|
// The root directory will be created if it doesn't exist.
|
|
|
|
|
func NewSandboxed(root string) (Medium, error) {
|
|
|
|
|
return local.New(root)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// --- Helper Functions ---
|
|
|
|
|
|
|
|
|
|
// Read retrieves the content of a file from the given medium.
|
|
|
|
|
func Read(m Medium, path string) (string, error) {
|
|
|
|
|
return m.Read(path)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Write saves the given content to a file in the given medium.
|
|
|
|
|
func Write(m Medium, path, content string) error {
|
|
|
|
|
return m.Write(path, content)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// EnsureDir makes sure a directory exists in the given medium.
|
|
|
|
|
func EnsureDir(m Medium, path string) error {
|
|
|
|
|
return m.EnsureDir(path)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// IsFile checks if a path exists and is a regular file in the given medium.
|
|
|
|
|
func IsFile(m Medium, path string) bool {
|
|
|
|
|
return m.IsFile(path)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Copy copies a file from one medium to another.
|
|
|
|
|
func Copy(src Medium, srcPath string, dst Medium, dstPath string) error {
|
|
|
|
|
content, err := src.Read(srcPath)
|
|
|
|
|
if err != nil {
|
|
|
|
|
return coreerr.E("io.Copy", "read failed: "+srcPath, err)
|
|
|
|
|
}
|
|
|
|
|
if err := dst.Write(dstPath, content); err != nil {
|
|
|
|
|
return coreerr.E("io.Copy", "write failed: "+dstPath, err)
|
|
|
|
|
}
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// --- MockMedium ---
|
|
|
|
|
|
|
|
|
|
// MockMedium is an in-memory implementation of Medium for testing.
|
|
|
|
|
type MockMedium struct {
|
|
|
|
|
Files map[string]string
|
|
|
|
|
Dirs map[string]bool
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// NewMockMedium creates a new MockMedium instance.
|
|
|
|
|
func NewMockMedium() *MockMedium {
|
|
|
|
|
return &MockMedium{
|
|
|
|
|
Files: make(map[string]string),
|
|
|
|
|
Dirs: make(map[string]bool),
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Read retrieves the content of a file from the mock filesystem.
|
|
|
|
|
func (m *MockMedium) Read(path string) (string, error) {
|
|
|
|
|
content, ok := m.Files[path]
|
|
|
|
|
if !ok {
|
2026-02-01 22:50:55 +00:00
|
|
|
return "", coreerr.E("io.MockMedium.Read", "file not found: "+path, os.ErrNotExist)
|
feat(mcp): add workspace root validation to prevent path traversal (#100)
* feat(mcp): add workspace root validation to prevent path traversal
- Add workspaceRoot field to Service for restricting file operations
- Add WithWorkspaceRoot() option for configuring the workspace directory
- Add validatePath() helper to check paths are within workspace
- Apply validation to all file operation handlers
- Default to current working directory for security
- Add comprehensive tests for path validation
Closes #82
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor: move CLI commands from pkg/ to internal/cmd/
- Move 18 CLI command packages to internal/cmd/ (not externally importable)
- Keep 16 library packages in pkg/ (externally importable)
- Update all import paths throughout codebase
- Cleaner separation between CLI logic and reusable libraries
CLI commands moved: ai, ci, dev, docs, doctor, gitcmd, go, monitor,
php, pkgcmd, qa, sdk, security, setup, test, updater, vm, workspace
Libraries remaining: agentic, build, cache, cli, container, devops,
errors, framework, git, i18n, io, log, mcp, process, release, repos
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor(mcp): use pkg/io Medium for sandboxed file operations
Replace manual path validation with pkg/io.Medium for all file operations.
This delegates security (path traversal, symlink bypass) to the sandboxed
local.Medium implementation.
Changes:
- Add io.NewSandboxed() for creating sandboxed Medium instances
- Refactor MCP Service to use io.Medium instead of direct os.* calls
- Remove validatePath and resolvePathWithSymlinks functions
- Update tests to verify Medium-based behaviour
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix: correct import path and workflow references
- Fix pkg/io/io.go import from core-gui to core
- Update CI workflows to use internal/cmd/updater path
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(security): address CodeRabbit review issues for path validation
- pkg/io/local: add symlink resolution and boundary-aware containment
- Reject absolute paths in sandboxed Medium
- Use filepath.EvalSymlinks to prevent symlink bypass attacks
- Fix prefix check to prevent /tmp/root matching /tmp/root2
- pkg/mcp: fix resolvePath to validate and return errors
- Changed resolvePath from (string) to (string, error)
- Update deleteFile, renameFile, listDirectory, fileExists to handle errors
- Changed New() to return (*Service, error) instead of *Service
- Properly propagate option errors instead of silently discarding
- pkg/io: wrap errors with E() helper for consistent context
- Copy() and MockMedium.Read() now use coreerr.E()
- tests: rename to use _Good/_Bad/_Ugly suffixes per coding guidelines
- Fix hardcoded /tmp in TestPath to use t.TempDir()
- Add TestResolvePath_Bad_SymlinkTraversal test
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* style: fix gofmt formatting across all files
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 21:59:34 +00:00
|
|
|
}
|
|
|
|
|
return content, nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Write saves the given content to a file in the mock filesystem.
|
|
|
|
|
func (m *MockMedium) Write(path, content string) error {
|
|
|
|
|
m.Files[path] = content
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// EnsureDir records that a directory exists in the mock filesystem.
|
|
|
|
|
func (m *MockMedium) EnsureDir(path string) error {
|
|
|
|
|
m.Dirs[path] = true
|
|
|
|
|
return nil
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// IsFile checks if a path exists as a file in the mock filesystem.
|
|
|
|
|
func (m *MockMedium) IsFile(path string) bool {
|
|
|
|
|
_, ok := m.Files[path]
|
|
|
|
|
return ok
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// FileGet is a convenience function that reads a file from the mock filesystem.
|
|
|
|
|
func (m *MockMedium) FileGet(path string) (string, error) {
|
|
|
|
|
return m.Read(path)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// FileSet is a convenience function that writes a file to the mock filesystem.
|
|
|
|
|
func (m *MockMedium) FileSet(path, content string) error {
|
|
|
|
|
return m.Write(path, content)
|
|
|
|
|
}
|