From 2b91bd5c6e4b7a2eec7c63422a8b2696fa7edc0a Mon Sep 17 00:00:00 2001
From: Snider <631881+Snider@users.noreply.github.com>
Date: Wed, 4 Feb 2026 15:06:10 +0000
Subject: [PATCH] chore(io): address code review and fix CI

- Fix MockFile.Read to return io.EOF
- Use filepath.Match in TaskfileBuilder for precise globbing
- Stream xz data in createTarXzArchive to avoid in-memory string conversion
- Fix TestPath_RootFilesystem in local medium tests
- Fix formatting in pkg/build/buildcmd/cmd_project.go
---
 pkg/build/archive.go              | 8 +++++++-
 pkg/build/buildcmd/cmd_project.go | 1 -
 pkg/build/builders/taskfile.go    | 6 +++---
 pkg/io/io.go                      | 2 +-
 pkg/io/local/client_test.go       | 5 +++--
 5 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/pkg/build/archive.go b/pkg/build/archive.go
index 7e36d04..1959e29 100644
--- a/pkg/build/archive.go
+++ b/pkg/build/archive.go
@@ -185,7 +185,13 @@ func createTarXzArchive(fs io_interface.Medium, src, dst string) error {
 	}
 
 	// Write to destination file
-	if err := fs.Write(dst, string(xzData)); err != nil {
+	dstFile, err := fs.Create(dst)
+	if err != nil {
+		return fmt.Errorf("failed to create archive file: %w", err)
+	}
+	defer func() { _ = dstFile.Close() }()
+
+	if _, err := dstFile.Write(xzData); err != nil {
 		return fmt.Errorf("failed to write archive file: %w", err)
 	}
 
diff --git a/pkg/build/buildcmd/cmd_project.go b/pkg/build/buildcmd/cmd_project.go
index f25249f..25a09dd 100644
--- a/pkg/build/buildcmd/cmd_project.go
+++ b/pkg/build/buildcmd/cmd_project.go
@@ -79,7 +79,6 @@ func runProjectBuild(ctx context.Context, buildType string, ciMode bool, targets
 	}
 	outputDir = filepath.Clean(outputDir)
 
-
 	// Ensure config path is absolute if provided
 	if configPath != "" && !filepath.IsAbs(configPath) {
 		configPath = filepath.Join(projectDir, configPath)
diff --git a/pkg/build/builders/taskfile.go b/pkg/build/builders/taskfile.go
index b65b613..6079cef 100644
--- a/pkg/build/builders/taskfile.go
+++ b/pkg/build/builders/taskfile.go
@@ -246,10 +246,10 @@ func (b *TaskfileBuilder) findArtifactsForTarget(fs io.Medium, outputDir string,
 	return artifacts
 }
 
-// matchPattern implements a very simple glob matcher for Taskfile artifacts.
+// matchPattern implements glob matching for Taskfile artifacts.
 func (b *TaskfileBuilder) matchPattern(name, pattern string) bool {
-	p := strings.ReplaceAll(pattern, "*", "")
-	return strings.Contains(name, p)
+	matched, _ := filepath.Match(pattern, name)
+	return matched
 }
 
 // validateTaskCli checks if the task CLI is available.
diff --git a/pkg/io/io.go b/pkg/io/io.go
index 3ed2a20..7327b30 100644
--- a/pkg/io/io.go
+++ b/pkg/io/io.go
@@ -350,7 +350,7 @@ func (f *MockFile) Stat() (fs.FileInfo, error) {
 
 func (f *MockFile) Read(b []byte) (int, error) {
 	if f.offset >= int64(len(f.content)) {
-		return 0, fs.ErrClosed // Or io.EOF?
+		return 0, io.EOF
 	}
 	n := copy(b, f.content[f.offset:])
 	f.offset += int64(n)
diff --git a/pkg/io/local/client_test.go b/pkg/io/local/client_test.go
index 9e2a1e1..3cb5996 100644
--- a/pkg/io/local/client_test.go
+++ b/pkg/io/local/client_test.go
@@ -40,8 +40,9 @@ func TestPath_RootFilesystem(t *testing.T) {
 	assert.Equal(t, "/etc/passwd", m.path("/etc/passwd"))
 	assert.Equal(t, "/home/user/file.txt", m.path("/home/user/file.txt"))
 
-	// Relative paths still work
-	assert.Equal(t, "/file.txt", m.path("file.txt"))
+	// Relative paths are relative to CWD when root is "/"
+	cwd, _ := os.Getwd()
+	assert.Equal(t, filepath.Join(cwd, "file.txt"), m.path("file.txt"))
 }
 
 func TestReadWrite(t *testing.T) {