From 9161ed2a7993e91f6b28a162d130d4ea5097c714 Mon Sep 17 00:00:00 2001
From: Snider <snider@host.uk.com>
Date: Fri, 20 Mar 2026 14:32:16 +0000
Subject: [PATCH] =?UTF-8?q?refactor:=20Result.New()=20and=20Result.Result(?=
 =?UTF-8?q?)=20=E2=80=94=20pointer=20receiver,=20AX=20pattern?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

New() sets Value/OK on the receiver and returns *Result.
Result() returns the Value. Both pointer receivers.

r := &Result{}
r.New(file, err)  // OK = err == nil
val := r.Result()

Co-Authored-By: Virgil <virgil@lethean.io>
---
 pkg/core/options.go | 35 +++++++++++++++++++++++------------
 1 file changed, 23 insertions(+), 12 deletions(-)

diff --git a/pkg/core/options.go b/pkg/core/options.go
index 29b5e15..e3a2aaa 100644
--- a/pkg/core/options.go
+++ b/pkg/core/options.go
@@ -37,35 +37,46 @@ package core
 // Replaces the (value, error) pattern — errors flow through Core internally.
 //
 //	r := c.Data().New(core.Options{{K: "name", V: "brain"}})
-//	if r.OK { use(r.Value) }
+//	if r.OK { use(r.Result()) }
 type Result struct {
 	Value any
 	OK    bool
 }
 
-// New creates a Result from variadic args.
-// Maps Go (value, error) pairs and multi-value returns to Result.
+// Result returns the value.
 //
-//	Result{}.New(file, err)       // OK = err == nil, Value = file
-//	Result{}.New(value)           // OK = true, Value = value
-//	Result{}.New()                // OK = false
-//	Result{}.New("1", 1)          // OK = true, Value = first arg
-func (r Result) New(args ...any) Result {
+//	val := r.Result()
+func (r *Result) Result() any { return r.Value }
+
+// New creates a Result from variadic args.
+// Maps Go (value, error) pairs to Result.
+//
+//	r.New(file, err)       // OK = err == nil, Value = file
+//	r.New(value)           // OK = true, Value = value
+//	r.New()                // OK = false
+func (r *Result) New(args ...any) *Result {
 	if len(args) == 0 {
-		return Result{}
+		r.OK = false
+		return r
 	}
 
 	// Check if last arg is an error
 	if len(args) >= 2 {
 		if err, ok := args[len(args)-1].(error); ok {
 			if err != nil {
-				return Result{Value: err}
+				r.Value = err
+				r.OK = false
+				return r
 			}
-			return Result{Value: args[0], OK: true}
+			r.Value = args[0]
+			r.OK = true
+			return r
 		}
 	}
 
-	return Result{Value: args[0], OK: true}
+	r.Value = args[0]
+	r.OK = true
+	return r
 }
 
 // Option is a single key-value configuration pair.