core/go
8
0
Fork 0
generated from lthn/LEM
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

feat(qa): restore docblock check via go-devops import

Browse source 
Now that go-devops imports core/cli (not core/go/pkg/cli),
the circular dependency is resolved. Restore the docblock
coverage check using qa.CheckDocblockCoverage().

Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Snider 2026-02-22 23:31:46 +00:00
parent 9323eeb1fa
commit 97a561c809
3 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
cmd/gocmd/cmd_qa.go
View file

@ -11,6 +11,7 @@ import (
"time"
"forge.lthn.ai/core/cli/pkg/cli"
"forge.lthn.ai/core/go-devops/cmd/qa"
"forge.lthn.ai/core/go/pkg/i18n"
)
@ -613,8 +614,14 @@ func runInternalCheck(check QACheck) (string, error) {
return "", runGoFuzz(duration, "", "", qaVerbose)
case "docblock":
// TODO: migrate to go-devops/cmd/qa.CheckDocblockCoverage once circular dep resolved
return "", cli.Err("docblock check not yet available (pending go-devops migration)")
result, err := qa.CheckDocblockCoverage([]string{"./..."})
if err != nil {
return "", err
}
if result.Coverage < qaDocblockThreshold {
return "", cli.Err("docblock coverage %.1f%% below threshold %.1f%%", result.Coverage, qaDocblockThreshold)
}
return fmt.Sprintf("docblock coverage: %.1f%% (%d/%d)", result.Coverage, result.Documented, result.Total), nil
default:
return "", cli.Err("unknown internal check: %s", check.Name)

1
go.mod
View file

@ -6,6 +6,7 @@ require (
forge.lthn.ai/Snider/Borg v0.2.1
forge.lthn.ai/core/cli v0.0.1
forge.lthn.ai/core/go-crypt v0.0.1
forge.lthn.ai/core/go-devops v0.0.0-20260222232858-ac6cff9b1868
github.com/aws/aws-sdk-go-v2 v1.41.1
github.com/aws/aws-sdk-go-v2/service/s3 v1.96.0
github.com/gorilla/websocket v1.5.3

2
go.sum
View file

@ -4,6 +4,8 @@ forge.lthn.ai/core/cli v0.0.1 h1:nqpc4Tv8a4H/ERei+/71DVQxkCFU8HPFJP4120qPXgk=
forge.lthn.ai/core/cli v0.0.1/go.mod h1:xa3Nqw3sUtYYJ1k+1jYul18tgs6sBevCUsGsHJI1hHA=
forge.lthn.ai/core/go-crypt v0.0.1 h1:fmFc2SJ/VOXDRjkcYoLWfL7lI4HfPJeVS/Na6zHHcvw=
forge.lthn.ai/core/go-crypt v0.0.1/go.mod h1:/j/rUN2ZMV7x1B5BYxH3QdwkgZg0HNBw5XuyFZeyxBY=
forge.lthn.ai/core/go-devops v0.0.0-20260222232858-ac6cff9b1868 h1:jm2S0VbzjejUbkyA8fW0V1dp6cJOry7twfGzM/R/0Xg=
forge.lthn.ai/core/go-devops v0.0.0-20260222232858-ac6cff9b1868/go.mod h1:A/0iKmL8VcZbclOZvoE2mg8bNi75Sn8Fgzk8hQ8y70k=
github.com/ProtonMail/go-crypto v1.3.0 h1:ILq8+Sf5If5DCpHQp4PbZdS1J7HDFRXz/+xKBiRGFrw=
github.com/ProtonMail/go-crypto v1.3.0/go.mod h1:9whxjD8Rbs29b4XWbB8irEcE8KHMqaR2e7GWU1R+/PE=
github.com/aws/aws-sdk-go-v2 v1.41.1 h1:ABlyEARCDLN034NhxlRUSZr4l71mh+T5KAeGh6cerhU=