From d570c87efca8975969db13f44e62b0ece32a8b51 Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 24 Feb 2026 15:38:38 +0000 Subject: [PATCH] =?UTF-8?q?chore:=20fmt.Errorf(static)=20=E2=86=92=20error?= =?UTF-8?q?s.New?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Opus 4.6 --- pkg/coredeno/lifecycle.go | 3 ++- pkg/framework/core/service_manager.go | 3 ++- pkg/i18n/internal/validate/main.go | 3 ++- pkg/i18n/service.go | 5 +++-- pkg/manifest/sign.go | 3 ++- pkg/process/runner.go | 6 +++--- pkg/repos/registry.go | 3 ++- pkg/session/video.go | 3 ++- pkg/webview/actions.go | 7 ++++--- pkg/webview/angular.go | 7 ++++--- pkg/webview/cdp.go | 5 +++-- pkg/webview/webview.go | 25 +++++++++++++------------ pkg/ws/ws.go | 3 ++- 13 files changed, 44 insertions(+), 32 deletions(-) diff --git a/pkg/coredeno/lifecycle.go b/pkg/coredeno/lifecycle.go index 0a9a885..a603fd1 100644 --- a/pkg/coredeno/lifecycle.go +++ b/pkg/coredeno/lifecycle.go @@ -2,6 +2,7 @@ package coredeno import ( "context" + "errors" "fmt" "os" "os/exec" @@ -14,7 +15,7 @@ func (s *Sidecar) Start(ctx context.Context, args ...string) error { defer s.mu.Unlock() if s.cmd != nil { - return fmt.Errorf("coredeno: already running") + return errors.New("coredeno: already running") } // Ensure socket directory exists with owner-only permissions diff --git a/pkg/framework/core/service_manager.go b/pkg/framework/core/service_manager.go index 80c208f..9c4b0bd 100644 --- a/pkg/framework/core/service_manager.go +++ b/pkg/framework/core/service_manager.go @@ -1,6 +1,7 @@ package core import ( + "errors" "fmt" "sync" ) @@ -27,7 +28,7 @@ func newServiceManager() *serviceManager { // It also appends to startables/stoppables if the service implements those interfaces. func (m *serviceManager) registerService(name string, svc any) error { if name == "" { - return fmt.Errorf("core: service name cannot be empty") + return errors.New("core: service name cannot be empty") } m.mu.Lock() defer m.mu.Unlock() diff --git a/pkg/i18n/internal/validate/main.go b/pkg/i18n/internal/validate/main.go index 5e0d942..d295c57 100644 --- a/pkg/i18n/internal/validate/main.go +++ b/pkg/i18n/internal/validate/main.go @@ -19,6 +19,7 @@ package main import ( "encoding/json" + "errors" "fmt" "go/ast" "go/parser" @@ -101,7 +102,7 @@ func findProjectRoot() (string, error) { } parent := filepath.Dir(dir) if parent == dir { - return "", fmt.Errorf("could not find go.mod in any parent directory") + return "", errors.New("could not find go.mod in any parent directory") } dir = parent } diff --git a/pkg/i18n/service.go b/pkg/i18n/service.go index 91d1181..07c38a3 100644 --- a/pkg/i18n/service.go +++ b/pkg/i18n/service.go @@ -4,6 +4,7 @@ package i18n import ( "embed" "encoding/json" + "errors" "fmt" "io/fs" "path" @@ -118,7 +119,7 @@ func NewWithLoader(loader Loader, opts ...Option) (*Service, error) { // Load all available languages langs := loader.Languages() if len(langs) == 0 { - return nil, fmt.Errorf("no languages available from loader") + return nil, errors.New("no languages available from loader") } for _, lang := range langs { @@ -223,7 +224,7 @@ func (s *Service) SetLanguage(lang string) error { } if len(s.availableLangs) == 0 { - return fmt.Errorf("no languages available") + return errors.New("no languages available") } matcher := language.NewMatcher(s.availableLangs) diff --git a/pkg/manifest/sign.go b/pkg/manifest/sign.go index c8699b9..857d15c 100644 --- a/pkg/manifest/sign.go +++ b/pkg/manifest/sign.go @@ -3,6 +3,7 @@ package manifest import ( "crypto/ed25519" "encoding/base64" + "errors" "fmt" "gopkg.in/yaml.v3" @@ -29,7 +30,7 @@ func Sign(m *Manifest, priv ed25519.PrivateKey) error { // Verify checks the ed25519 signature in m.Sign against the public key. func Verify(m *Manifest, pub ed25519.PublicKey) (bool, error) { if m.Sign == "" { - return false, fmt.Errorf("manifest.Verify: no signature present") + return false, errors.New("manifest.Verify: no signature present") } sig, err := base64.StdEncoding.DecodeString(m.Sign) if err != nil { diff --git a/pkg/process/runner.go b/pkg/process/runner.go index effd39a..8eb1fd5 100644 --- a/pkg/process/runner.go +++ b/pkg/process/runner.go @@ -2,7 +2,7 @@ package process import ( "context" - "fmt" + "errors" "sync" "time" ) @@ -104,7 +104,7 @@ func (r *Runner) RunAll(ctx context.Context, specs []RunSpec) (*RunAllResult, er Name: name, Spec: remaining[name], Skipped: true, - Error: fmt.Errorf("circular dependency or missing dependency"), + Error: errors.New("circular dependency or missing dependency"), }) } break @@ -136,7 +136,7 @@ func (r *Runner) RunAll(ctx context.Context, specs []RunSpec) (*RunAllResult, er Name: spec.Name, Spec: spec, Skipped: true, - Error: fmt.Errorf("skipped due to dependency failure"), + Error: errors.New("skipped due to dependency failure"), } } else { result = r.runSpec(ctx, spec) diff --git a/pkg/repos/registry.go b/pkg/repos/registry.go index 07c7486..3ee519d 100644 --- a/pkg/repos/registry.go +++ b/pkg/repos/registry.go @@ -4,6 +4,7 @@ package repos import ( + "errors" "fmt" "os" "path/filepath" @@ -146,7 +147,7 @@ func FindRegistry(m io.Medium) (string, error) { } } - return "", fmt.Errorf("repos.yaml not found") + return "", errors.New("repos.yaml not found") } // ScanDirectory creates a Registry by scanning a directory for git repos. diff --git a/pkg/session/video.go b/pkg/session/video.go index 2258fe1..d19893c 100644 --- a/pkg/session/video.go +++ b/pkg/session/video.go @@ -1,6 +1,7 @@ package session import ( + "errors" "fmt" "os" "os/exec" @@ -10,7 +11,7 @@ import ( // RenderMP4 generates an MP4 video from session events using VHS (charmbracelet). func RenderMP4(sess *Session, outputPath string) error { if _, err := exec.LookPath("vhs"); err != nil { - return fmt.Errorf("vhs not installed (go install github.com/charmbracelet/vhs@latest)") + return errors.New("vhs not installed (go install github.com/charmbracelet/vhs@latest)") } tape := generateTape(sess, outputPath) diff --git a/pkg/webview/actions.go b/pkg/webview/actions.go index 4dcc0ab..5348020 100644 --- a/pkg/webview/actions.go +++ b/pkg/webview/actions.go @@ -2,6 +2,7 @@ package webview import ( "context" + "errors" "fmt" "time" ) @@ -191,7 +192,7 @@ func (a HoverAction) Execute(ctx context.Context, wv *Webview) error { } if elem.BoundingBox == nil { - return fmt.Errorf("element has no bounding box") + return errors.New("element has no bounding box") } x := elem.BoundingBox.X + elem.BoundingBox.Width/2 @@ -495,7 +496,7 @@ func (wv *Webview) DragAndDrop(sourceSelector, targetSelector string) error { return fmt.Errorf("source element not found: %w", err) } if source.BoundingBox == nil { - return fmt.Errorf("source element has no bounding box") + return errors.New("source element has no bounding box") } target, err := wv.querySelector(ctx, targetSelector) @@ -503,7 +504,7 @@ func (wv *Webview) DragAndDrop(sourceSelector, targetSelector string) error { return fmt.Errorf("target element not found: %w", err) } if target.BoundingBox == nil { - return fmt.Errorf("target element has no bounding box") + return errors.New("target element has no bounding box") } // Calculate center points diff --git a/pkg/webview/angular.go b/pkg/webview/angular.go index 0a842c7..105d519 100644 --- a/pkg/webview/angular.go +++ b/pkg/webview/angular.go @@ -2,6 +2,7 @@ package webview import ( "context" + "errors" "fmt" "time" ) @@ -42,7 +43,7 @@ func (ah *AngularHelper) waitForAngular(ctx context.Context) error { return err } if !isAngular { - return fmt.Errorf("not an Angular application") + return errors.New("not an Angular application") } // Wait for Zone.js stability @@ -278,13 +279,13 @@ func (ah *AngularHelper) GetRouterState() (*AngularRouterState, error) { } if result == nil { - return nil, fmt.Errorf("could not get router state") + return nil, errors.New("could not get router state") } // Parse result resultMap, ok := result.(map[string]any) if !ok { - return nil, fmt.Errorf("invalid router state format") + return nil, errors.New("invalid router state format") } state := &AngularRouterState{ diff --git a/pkg/webview/cdp.go b/pkg/webview/cdp.go index f00d1f1..cea7f05 100644 --- a/pkg/webview/cdp.go +++ b/pkg/webview/cdp.go @@ -3,6 +3,7 @@ package webview import ( "context" "encoding/json" + "errors" "fmt" "io" "net/http" @@ -121,7 +122,7 @@ func NewCDPClient(debugURL string) (*CDPClient, error) { } if wsURL == "" { - return nil, fmt.Errorf("no WebSocket URL available") + return nil, errors.New("no WebSocket URL available") } // Connect to WebSocket @@ -306,7 +307,7 @@ func (c *CDPClient) NewTab(url string) (*CDPClient, error) { } if target.WebSocketDebuggerURL == "" { - return nil, fmt.Errorf("no WebSocket URL for new tab") + return nil, errors.New("no WebSocket URL for new tab") } // Connect to new tab diff --git a/pkg/webview/webview.go b/pkg/webview/webview.go index d18bf6e..d01fd50 100644 --- a/pkg/webview/webview.go +++ b/pkg/webview/webview.go @@ -24,6 +24,7 @@ package webview import ( "context" "encoding/base64" + "errors" "fmt" "sync" "time" @@ -122,7 +123,7 @@ func New(opts ...Option) (*Webview, error) { if wv.client == nil { cancel() - return nil, fmt.Errorf("no debug URL provided; use WithDebugURL option") + return nil, errors.New("no debug URL provided; use WithDebugURL option") } // Enable console capture @@ -222,7 +223,7 @@ func (wv *Webview) Screenshot() ([]byte, error) { dataStr, ok := result["data"].(string) if !ok { - return nil, fmt.Errorf("invalid screenshot data") + return nil, errors.New("invalid screenshot data") } data, err := base64.StdEncoding.DecodeString(dataStr) @@ -263,7 +264,7 @@ func (wv *Webview) GetURL() (string, error) { url, ok := result.(string) if !ok { - return "", fmt.Errorf("invalid URL result") + return "", errors.New("invalid URL result") } return url, nil @@ -281,7 +282,7 @@ func (wv *Webview) GetTitle() (string, error) { title, ok := result.(string) if !ok { - return "", fmt.Errorf("invalid title result") + return "", errors.New("invalid title result") } return title, nil @@ -306,7 +307,7 @@ func (wv *Webview) GetHTML(selector string) (string, error) { html, ok := result.(string) if !ok { - return "", fmt.Errorf("invalid HTML result") + return "", errors.New("invalid HTML result") } return html, nil @@ -520,7 +521,7 @@ func (wv *Webview) evaluate(ctx context.Context, script string) (any, error) { return nil, fmt.Errorf("JavaScript error: %s", description) } } - return nil, fmt.Errorf("JavaScript error") + return nil, errors.New("JavaScript error") } // Extract result value @@ -541,12 +542,12 @@ func (wv *Webview) querySelector(ctx context.Context, selector string) (*Element root, ok := docResult["root"].(map[string]any) if !ok { - return nil, fmt.Errorf("invalid document root") + return nil, errors.New("invalid document root") } rootID, ok := root["nodeId"].(float64) if !ok { - return nil, fmt.Errorf("invalid root node ID") + return nil, errors.New("invalid root node ID") } // Query selector @@ -576,12 +577,12 @@ func (wv *Webview) querySelectorAll(ctx context.Context, selector string) ([]*El root, ok := docResult["root"].(map[string]any) if !ok { - return nil, fmt.Errorf("invalid document root") + return nil, errors.New("invalid document root") } rootID, ok := root["nodeId"].(float64) if !ok { - return nil, fmt.Errorf("invalid root node ID") + return nil, errors.New("invalid root node ID") } // Query selector all @@ -595,7 +596,7 @@ func (wv *Webview) querySelectorAll(ctx context.Context, selector string) ([]*El nodeIDs, ok := queryResult["nodeIds"].([]any) if !ok { - return nil, fmt.Errorf("invalid node IDs") + return nil, errors.New("invalid node IDs") } elements := make([]*ElementInfo, 0, len(nodeIDs)) @@ -622,7 +623,7 @@ func (wv *Webview) getElementInfo(ctx context.Context, nodeID int) (*ElementInfo node, ok := descResult["node"].(map[string]any) if !ok { - return nil, fmt.Errorf("invalid node description") + return nil, errors.New("invalid node description") } tagName, _ := node["nodeName"].(string) diff --git a/pkg/ws/ws.go b/pkg/ws/ws.go index 16dd6f7..ea9cc03 100644 --- a/pkg/ws/ws.go +++ b/pkg/ws/ws.go @@ -47,6 +47,7 @@ package ws import ( "context" "encoding/json" + "errors" "fmt" "net/http" "sync" @@ -220,7 +221,7 @@ func (h *Hub) Broadcast(msg Message) error { select { case h.broadcast <- data: default: - return fmt.Errorf("broadcast channel full") + return errors.New("broadcast channel full") } return nil }