Merge pull request 'fix: CodeRabbit review findings for Env/Path' (#22) from dev into main
Some checks failed
CI / test (push) Failing after 2s
Some checks failed
CI / test (push) Failing after 2s
This commit is contained in:
commit
fb04b28419
3 changed files with 13 additions and 4 deletions
|
|
@ -34,6 +34,10 @@ func TestEnv_PS(t *testing.T) {
|
|||
}
|
||||
|
||||
func TestEnv_DIR_HOME(t *testing.T) {
|
||||
if ch := os.Getenv("CORE_HOME"); ch != "" {
|
||||
assert.Equal(t, ch, core.Env("DIR_HOME"))
|
||||
return
|
||||
}
|
||||
home, err := os.UserHomeDir()
|
||||
require.NoError(t, err)
|
||||
assert.Equal(t, home, core.Env("DIR_HOME"))
|
||||
|
|
|
|||
7
path.go
7
path.go
|
|
@ -1,8 +1,8 @@
|
|||
// SPDX-License-Identifier: EUPL-1.2
|
||||
|
||||
// OS-aware filesystem path operations for the Core framework.
|
||||
// Zero filepath import — uses Env("DS") for the separator and
|
||||
// Core string primitives for all path manipulation.
|
||||
// Uses Env("DS") for the separator and Core string primitives
|
||||
// for path manipulation. filepath imported only for PathGlob.
|
||||
//
|
||||
// Path anchors relative segments to DIR_HOME:
|
||||
//
|
||||
|
|
@ -29,6 +29,9 @@ import "path/filepath"
|
|||
func Path(segments ...string) string {
|
||||
ds := Env("DS")
|
||||
home := Env("DIR_HOME")
|
||||
if home == "" {
|
||||
home = "."
|
||||
}
|
||||
if len(segments) == 0 {
|
||||
return home
|
||||
}
|
||||
|
|
|
|||
|
|
@ -19,7 +19,8 @@ func TestPath_Relative(t *testing.T) {
|
|||
}
|
||||
|
||||
func TestPath_Absolute(t *testing.T) {
|
||||
assert.Equal(t, "/tmp/workspace", core.Path("/tmp", "workspace"))
|
||||
ds := core.Env("DS")
|
||||
assert.Equal(t, "/tmp"+ds+"workspace", core.Path("/tmp", "workspace"))
|
||||
}
|
||||
|
||||
func TestPath_Empty(t *testing.T) {
|
||||
|
|
@ -35,7 +36,8 @@ func TestPath_Cleans(t *testing.T) {
|
|||
}
|
||||
|
||||
func TestPath_CleanDoubleSlash(t *testing.T) {
|
||||
assert.Equal(t, "/tmp/file", core.Path("/tmp//file"))
|
||||
ds := core.Env("DS")
|
||||
assert.Equal(t, ds+"tmp"+ds+"file", core.Path("/tmp//file"))
|
||||
}
|
||||
|
||||
func TestPathBase(t *testing.T) {
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue