2dff772a40
Plans 1-5 complete for core/go scope. 456 tests, 84.4% coverage, 100% AX-7 naming.
Critical bugs (Plan 1):
- P4-3+P7-3: ACTION broadcast calls all handlers with panic recovery
- P7-2+P7-4: RunE() with defer ServiceShutdown, Run() delegates
- P3-1: Startable/Stoppable return Result (breaking, clean)
- P9-1: Zero os/exec — App.Find() rewritten with os.Stat+PATH
- I3: Embed() removed, I15: New() comment fixed
- I9: CommandLifecycle removed → Command.Managed field
Registry[T] (Plan 2):
- Universal thread-safe named collection with 3 lock modes
- All 5 registries migrated: services, commands, drive, data, lock
- Insertion order preserved (fixes P4-1)
- c.RegistryOf("name") cross-cutting accessor
Action/Task system (Plan 3):
- Action type with Run()/Exists(), ActionHandler signature
- c.Action("name") dual-purpose accessor (register/invoke)
- TaskDef with Steps — sequential chain, async dispatch, previous-input piping
- Panic recovery on all Action execution
- broadcast() internal, ACTION() sugar
Process primitive (Plan 4):
- c.Process() returns Action sugar — Run/RunIn/RunWithEnv/Start/Kill/Exists
- No deps added — delegates to c.Action("process.*")
- Permission-by-registration: no handler = no capability
Missing primitives (Plan 5):
- core.ID() — atomic counter + crypto/rand suffix
- ValidateName() / SanitisePath() — reusable validation
- Fs.WriteAtomic() — write-to-temp-then-rename
- Fs.NewUnrestricted() / Fs.Root() — legitimate sandbox bypass
- AX-7: 456/456 tests renamed to TestFile_Function_{Good,Bad,Ugly}
Co-Authored-By: Virgil <virgil@lethean.io>
135 lines
2.9 KiB
Go
135 lines
2.9 KiB
Go
package core_test
|
|
|
|
import (
|
|
"embed"
|
|
"io"
|
|
"testing"
|
|
|
|
. "dappco.re/go/core"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
//go:embed testdata
|
|
var testFS embed.FS
|
|
|
|
// --- Data (Embedded Content Mounts) ---
|
|
|
|
func mountTestData(t *testing.T, c *Core, name string) {
|
|
t.Helper()
|
|
|
|
r := c.Data().New(NewOptions(
|
|
Option{Key: "name", Value: name},
|
|
Option{Key: "source", Value: testFS},
|
|
Option{Key: "path", Value: "testdata"},
|
|
))
|
|
assert.True(t, r.OK)
|
|
}
|
|
|
|
func TestData_New_Good(t *testing.T) {
|
|
c := New()
|
|
r := c.Data().New(NewOptions(
|
|
Option{Key: "name", Value: "test"},
|
|
Option{Key: "source", Value: testFS},
|
|
Option{Key: "path", Value: "testdata"},
|
|
))
|
|
assert.True(t, r.OK)
|
|
assert.NotNil(t, r.Value)
|
|
}
|
|
|
|
func TestData_New_Bad(t *testing.T) {
|
|
c := New()
|
|
|
|
r := c.Data().New(NewOptions(Option{Key: "source", Value: testFS}))
|
|
assert.False(t, r.OK)
|
|
|
|
r = c.Data().New(NewOptions(Option{Key: "name", Value: "test"}))
|
|
assert.False(t, r.OK)
|
|
|
|
r = c.Data().New(NewOptions(Option{Key: "name", Value: "test"}, Option{Key: "source", Value: "not-an-fs"}))
|
|
assert.False(t, r.OK)
|
|
}
|
|
|
|
func TestData_ReadString_Good(t *testing.T) {
|
|
c := New()
|
|
mountTestData(t, c, "app")
|
|
r := c.Data().ReadString("app/test.txt")
|
|
assert.True(t, r.OK)
|
|
assert.Equal(t, "hello from testdata\n", r.Value.(string))
|
|
}
|
|
|
|
func TestData_ReadString_Bad(t *testing.T) {
|
|
c := New()
|
|
r := c.Data().ReadString("nonexistent/file.txt")
|
|
assert.False(t, r.OK)
|
|
}
|
|
|
|
func TestData_ReadFile_Good(t *testing.T) {
|
|
c := New()
|
|
mountTestData(t, c, "app")
|
|
r := c.Data().ReadFile("app/test.txt")
|
|
assert.True(t, r.OK)
|
|
assert.Equal(t, "hello from testdata\n", string(r.Value.([]byte)))
|
|
}
|
|
|
|
func TestData_Get_Good(t *testing.T) {
|
|
c := New()
|
|
mountTestData(t, c, "brain")
|
|
gr := c.Data().Get("brain")
|
|
assert.True(t, gr.OK)
|
|
emb := gr.Value.(*Embed)
|
|
|
|
r := emb.Open("test.txt")
|
|
assert.True(t, r.OK)
|
|
file := r.Value.(io.ReadCloser)
|
|
defer file.Close()
|
|
content, _ := io.ReadAll(file)
|
|
assert.Equal(t, "hello from testdata\n", string(content))
|
|
}
|
|
|
|
func TestData_Get_Bad(t *testing.T) {
|
|
c := New()
|
|
r := c.Data().Get("nonexistent")
|
|
assert.False(t, r.OK)
|
|
}
|
|
|
|
func TestData_Mounts_Good(t *testing.T) {
|
|
c := New()
|
|
mountTestData(t, c, "a")
|
|
mountTestData(t, c, "b")
|
|
mounts := c.Data().Mounts()
|
|
assert.Len(t, mounts, 2)
|
|
}
|
|
|
|
func TestData_List_Good(t *testing.T) {
|
|
c := New()
|
|
mountTestData(t, c, "app")
|
|
r := c.Data().List("app/.")
|
|
assert.True(t, r.OK)
|
|
}
|
|
|
|
func TestData_List_Bad(t *testing.T) {
|
|
c := New()
|
|
r := c.Data().List("nonexistent/path")
|
|
assert.False(t, r.OK)
|
|
}
|
|
|
|
func TestData_ListNames_Good(t *testing.T) {
|
|
c := New()
|
|
mountTestData(t, c, "app")
|
|
r := c.Data().ListNames("app/.")
|
|
assert.True(t, r.OK)
|
|
assert.Contains(t, r.Value.([]string), "test")
|
|
}
|
|
|
|
func TestData_Extract_Good(t *testing.T) {
|
|
c := New()
|
|
mountTestData(t, c, "app")
|
|
r := c.Data().Extract("app/.", t.TempDir(), nil)
|
|
assert.True(t, r.OK)
|
|
}
|
|
|
|
func TestData_Extract_Bad(t *testing.T) {
|
|
c := New()
|
|
r := c.Data().Extract("nonexistent/path", t.TempDir(), nil)
|
|
assert.False(t, r.OK)
|
|
}
|