2dff772a40
Plans 1-5 complete for core/go scope. 456 tests, 84.4% coverage, 100% AX-7 naming.
Critical bugs (Plan 1):
- P4-3+P7-3: ACTION broadcast calls all handlers with panic recovery
- P7-2+P7-4: RunE() with defer ServiceShutdown, Run() delegates
- P3-1: Startable/Stoppable return Result (breaking, clean)
- P9-1: Zero os/exec — App.Find() rewritten with os.Stat+PATH
- I3: Embed() removed, I15: New() comment fixed
- I9: CommandLifecycle removed → Command.Managed field
Registry[T] (Plan 2):
- Universal thread-safe named collection with 3 lock modes
- All 5 registries migrated: services, commands, drive, data, lock
- Insertion order preserved (fixes P4-1)
- c.RegistryOf("name") cross-cutting accessor
Action/Task system (Plan 3):
- Action type with Run()/Exists(), ActionHandler signature
- c.Action("name") dual-purpose accessor (register/invoke)
- TaskDef with Steps — sequential chain, async dispatch, previous-input piping
- Panic recovery on all Action execution
- broadcast() internal, ACTION() sugar
Process primitive (Plan 4):
- c.Process() returns Action sugar — Run/RunIn/RunWithEnv/Start/Kill/Exists
- No deps added — delegates to c.Action("process.*")
- Permission-by-registration: no handler = no capability
Missing primitives (Plan 5):
- core.ID() — atomic counter + crypto/rand suffix
- ValidateName() / SanitisePath() — reusable validation
- Fs.WriteAtomic() — write-to-temp-then-rename
- Fs.NewUnrestricted() / Fs.Root() — legitimate sandbox bypass
- AX-7: 456/456 tests renamed to TestFile_Function_{Good,Bad,Ugly}
Co-Authored-By: Virgil <virgil@lethean.io>
111 lines
2.9 KiB
Go
111 lines
2.9 KiB
Go
// SPDX-License-Identifier: EUPL-1.2
|
|
|
|
package core_test
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
|
|
core "dappco.re/go/core"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestPath_Relative(t *testing.T) {
|
|
home, err := os.UserHomeDir()
|
|
require.NoError(t, err)
|
|
ds := core.Env("DS")
|
|
assert.Equal(t, home+ds+"Code"+ds+".core", core.Path("Code", ".core"))
|
|
}
|
|
|
|
func TestPath_Absolute(t *testing.T) {
|
|
ds := core.Env("DS")
|
|
assert.Equal(t, "/tmp"+ds+"workspace", core.Path("/tmp", "workspace"))
|
|
}
|
|
|
|
func TestPath_Empty(t *testing.T) {
|
|
home, err := os.UserHomeDir()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, home, core.Path())
|
|
}
|
|
|
|
func TestPath_Cleans(t *testing.T) {
|
|
home, err := os.UserHomeDir()
|
|
require.NoError(t, err)
|
|
assert.Equal(t, home+core.Env("DS")+"Code", core.Path("Code", "sub", ".."))
|
|
}
|
|
|
|
func TestPath_CleanDoubleSlash(t *testing.T) {
|
|
ds := core.Env("DS")
|
|
assert.Equal(t, ds+"tmp"+ds+"file", core.Path("/tmp//file"))
|
|
}
|
|
|
|
func TestPath_PathBase(t *testing.T) {
|
|
assert.Equal(t, "core", core.PathBase("/Users/snider/Code/core"))
|
|
assert.Equal(t, "homelab", core.PathBase("deploy/to/homelab"))
|
|
}
|
|
|
|
func TestPath_PathBase_Root(t *testing.T) {
|
|
assert.Equal(t, "/", core.PathBase("/"))
|
|
}
|
|
|
|
func TestPath_PathBase_Empty(t *testing.T) {
|
|
assert.Equal(t, ".", core.PathBase(""))
|
|
}
|
|
|
|
func TestPath_PathDir(t *testing.T) {
|
|
assert.Equal(t, "/Users/snider/Code", core.PathDir("/Users/snider/Code/core"))
|
|
}
|
|
|
|
func TestPath_PathDir_Root(t *testing.T) {
|
|
assert.Equal(t, "/", core.PathDir("/file"))
|
|
}
|
|
|
|
func TestPath_PathDir_NoDir(t *testing.T) {
|
|
assert.Equal(t, ".", core.PathDir("file.go"))
|
|
}
|
|
|
|
func TestPath_PathExt(t *testing.T) {
|
|
assert.Equal(t, ".go", core.PathExt("main.go"))
|
|
assert.Equal(t, "", core.PathExt("Makefile"))
|
|
assert.Equal(t, ".gz", core.PathExt("archive.tar.gz"))
|
|
}
|
|
|
|
func TestPath_EnvConsistency(t *testing.T) {
|
|
assert.Equal(t, core.Env("DIR_HOME"), core.Path())
|
|
}
|
|
|
|
func TestPath_PathGlob_Good(t *testing.T) {
|
|
dir := t.TempDir()
|
|
os.WriteFile(filepath.Join(dir, "a.txt"), []byte("a"), 0644)
|
|
os.WriteFile(filepath.Join(dir, "b.txt"), []byte("b"), 0644)
|
|
os.WriteFile(filepath.Join(dir, "c.log"), []byte("c"), 0644)
|
|
|
|
matches := core.PathGlob(filepath.Join(dir, "*.txt"))
|
|
assert.Len(t, matches, 2)
|
|
}
|
|
|
|
func TestPath_PathGlob_NoMatch(t *testing.T) {
|
|
matches := core.PathGlob("/nonexistent/pattern-*.xyz")
|
|
assert.Empty(t, matches)
|
|
}
|
|
|
|
func TestPath_PathIsAbs_Good(t *testing.T) {
|
|
assert.True(t, core.PathIsAbs("/tmp"))
|
|
assert.True(t, core.PathIsAbs("/"))
|
|
assert.False(t, core.PathIsAbs("relative"))
|
|
assert.False(t, core.PathIsAbs(""))
|
|
}
|
|
|
|
func TestPath_CleanPath_Good(t *testing.T) {
|
|
assert.Equal(t, "/a/b", core.CleanPath("/a//b", "/"))
|
|
assert.Equal(t, "/a/c", core.CleanPath("/a/b/../c", "/"))
|
|
assert.Equal(t, "/", core.CleanPath("/", "/"))
|
|
assert.Equal(t, ".", core.CleanPath("", "/"))
|
|
}
|
|
|
|
func TestPath_PathDir_TrailingSlash(t *testing.T) {
|
|
result := core.PathDir("/Users/snider/Code/")
|
|
assert.Equal(t, "/Users/snider/Code", result)
|
|
}
|