go/pkg/plugin/registry_test.go
Snider 03c9188d79
feat: infrastructure packages and lint cleanup (#281)
* ci: consolidate duplicate workflows and merge CodeQL configs

Remove 17 duplicate workflow files that were split copies of the
combined originals. Each family (CI, CodeQL, Coverage, PR Build,
Alpha Release) had the same job duplicated across separate
push/pull_request/schedule/manual trigger files.

Merge codeql.yml and codescan.yml into a single codeql.yml with
a language matrix covering go, javascript-typescript, python,
and actions — matching the previous default setup coverage.

Remaining workflows (one per family):
- ci.yml (push + PR + manual)
- codeql.yml (push + PR + schedule, all languages)
- coverage.yml (push + PR + manual)
- alpha-release.yml (push + manual)
- pr-build.yml (PR + manual)
- release.yml (tag push)
- agent-verify.yml, auto-label.yml, auto-project.yml

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat: add collect, config, crypt, plugin packages and fix all lint issues

Add four new infrastructure packages with CLI commands:
- pkg/config: layered configuration (defaults → file → env → flags)
- pkg/crypt: crypto primitives (Argon2id, AES-GCM, ChaCha20, HMAC, checksums)
- pkg/plugin: plugin system with GitHub-based install/update/remove
- pkg/collect: collection subsystem (GitHub, BitcoinTalk, market, papers, excavate)

Fix all golangci-lint issues across the entire codebase (~100 errcheck,
staticcheck SA1012/SA1019/ST1005, unused, ineffassign fixes) so that
`core go qa` passes with 0 issues.

Closes #167, #168, #170, #250, #251, #252, #253, #254, #255, #256

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-04 11:34:43 +00:00

136 lines
3 KiB
Go

package plugin
import (
"testing"
"github.com/host-uk/core/pkg/io"
"github.com/stretchr/testify/assert"
)
func TestRegistry_Add_Good(t *testing.T) {
m := io.NewMockMedium()
reg := NewRegistry(m, "/home/user/.core/plugins")
err := reg.Add(&PluginConfig{
Name: "my-plugin",
Version: "1.0.0",
Source: "github:org/my-plugin",
Enabled: true,
})
assert.NoError(t, err)
list := reg.List()
assert.Len(t, list, 1)
assert.Equal(t, "my-plugin", list[0].Name)
assert.Equal(t, "1.0.0", list[0].Version)
}
func TestRegistry_Add_Bad_EmptyName(t *testing.T) {
m := io.NewMockMedium()
reg := NewRegistry(m, "/home/user/.core/plugins")
err := reg.Add(&PluginConfig{
Version: "1.0.0",
})
assert.Error(t, err)
assert.Contains(t, err.Error(), "plugin name is required")
}
func TestRegistry_Remove_Good(t *testing.T) {
m := io.NewMockMedium()
reg := NewRegistry(m, "/home/user/.core/plugins")
_ = reg.Add(&PluginConfig{
Name: "my-plugin",
Version: "1.0.0",
})
err := reg.Remove("my-plugin")
assert.NoError(t, err)
assert.Empty(t, reg.List())
}
func TestRegistry_Get_Good(t *testing.T) {
m := io.NewMockMedium()
reg := NewRegistry(m, "/home/user/.core/plugins")
_ = reg.Add(&PluginConfig{
Name: "test-plugin",
Version: "2.0.0",
Source: "github:org/test-plugin",
})
cfg, ok := reg.Get("test-plugin")
assert.True(t, ok)
assert.Equal(t, "test-plugin", cfg.Name)
assert.Equal(t, "2.0.0", cfg.Version)
}
func TestRegistry_Get_Bad_NotFound(t *testing.T) {
m := io.NewMockMedium()
reg := NewRegistry(m, "/home/user/.core/plugins")
cfg, ok := reg.Get("nonexistent")
assert.False(t, ok)
assert.Nil(t, cfg)
}
func TestRegistry_Remove_Bad_NotFound(t *testing.T) {
m := io.NewMockMedium()
reg := NewRegistry(m, "/home/user/.core/plugins")
err := reg.Remove("nonexistent")
assert.Error(t, err)
assert.Contains(t, err.Error(), "plugin not found")
}
func TestRegistry_SaveLoad_Good(t *testing.T) {
m := io.NewMockMedium()
basePath := "/home/user/.core/plugins"
reg := NewRegistry(m, basePath)
_ = reg.Add(&PluginConfig{
Name: "plugin-a",
Version: "1.0.0",
Source: "github:org/plugin-a",
Enabled: true,
InstalledAt: "2025-01-01T00:00:00Z",
})
_ = reg.Add(&PluginConfig{
Name: "plugin-b",
Version: "2.0.0",
Source: "github:org/plugin-b",
Enabled: false,
InstalledAt: "2025-01-02T00:00:00Z",
})
err := reg.Save()
assert.NoError(t, err)
// Load into a fresh registry
reg2 := NewRegistry(m, basePath)
err = reg2.Load()
assert.NoError(t, err)
list := reg2.List()
assert.Len(t, list, 2)
a, ok := reg2.Get("plugin-a")
assert.True(t, ok)
assert.Equal(t, "1.0.0", a.Version)
assert.True(t, a.Enabled)
b, ok := reg2.Get("plugin-b")
assert.True(t, ok)
assert.Equal(t, "2.0.0", b.Version)
assert.False(t, b.Enabled)
}
func TestRegistry_Load_Good_EmptyWhenNoFile(t *testing.T) {
m := io.NewMockMedium()
reg := NewRegistry(m, "/home/user/.core/plugins")
err := reg.Load()
assert.NoError(t, err)
assert.Empty(t, reg.List())
}