2dff772a40
Plans 1-5 complete for core/go scope. 456 tests, 84.4% coverage, 100% AX-7 naming.
Critical bugs (Plan 1):
- P4-3+P7-3: ACTION broadcast calls all handlers with panic recovery
- P7-2+P7-4: RunE() with defer ServiceShutdown, Run() delegates
- P3-1: Startable/Stoppable return Result (breaking, clean)
- P9-1: Zero os/exec — App.Find() rewritten with os.Stat+PATH
- I3: Embed() removed, I15: New() comment fixed
- I9: CommandLifecycle removed → Command.Managed field
Registry[T] (Plan 2):
- Universal thread-safe named collection with 3 lock modes
- All 5 registries migrated: services, commands, drive, data, lock
- Insertion order preserved (fixes P4-1)
- c.RegistryOf("name") cross-cutting accessor
Action/Task system (Plan 3):
- Action type with Run()/Exists(), ActionHandler signature
- c.Action("name") dual-purpose accessor (register/invoke)
- TaskDef with Steps — sequential chain, async dispatch, previous-input piping
- Panic recovery on all Action execution
- broadcast() internal, ACTION() sugar
Process primitive (Plan 4):
- c.Process() returns Action sugar — Run/RunIn/RunWithEnv/Start/Kill/Exists
- No deps added — delegates to c.Action("process.*")
- Permission-by-registration: no handler = no capability
Missing primitives (Plan 5):
- core.ID() — atomic counter + crypto/rand suffix
- ValidateName() / SanitisePath() — reusable validation
- Fs.WriteAtomic() — write-to-temp-then-rename
- Fs.NewUnrestricted() / Fs.Root() — legitimate sandbox bypass
- AX-7: 456/456 tests renamed to TestFile_Function_{Good,Bad,Ugly}
Co-Authored-By: Virgil <virgil@lethean.io>
125 lines
2.5 KiB
Go
125 lines
2.5 KiB
Go
package core_test
|
|
|
|
import (
|
|
"context"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
. "dappco.re/go/core"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// --- PerformAsync ---
|
|
|
|
func TestTask_PerformAsync_Good(t *testing.T) {
|
|
c := New()
|
|
var mu sync.Mutex
|
|
var result string
|
|
|
|
c.RegisterTask(func(_ *Core, task Task) Result {
|
|
mu.Lock()
|
|
result = "done"
|
|
mu.Unlock()
|
|
return Result{"completed", true}
|
|
})
|
|
|
|
r := c.PerformAsync("work")
|
|
assert.True(t, r.OK)
|
|
taskID := r.Value.(string)
|
|
assert.NotEmpty(t, taskID)
|
|
|
|
time.Sleep(100 * time.Millisecond)
|
|
|
|
mu.Lock()
|
|
assert.Equal(t, "done", result)
|
|
mu.Unlock()
|
|
}
|
|
|
|
func TestTask_PerformAsync_Progress_Good(t *testing.T) {
|
|
c := New()
|
|
c.RegisterTask(func(_ *Core, task Task) Result {
|
|
return Result{OK: true}
|
|
})
|
|
|
|
r := c.PerformAsync("work")
|
|
taskID := r.Value.(string)
|
|
c.Progress(taskID, 0.5, "halfway", "work")
|
|
}
|
|
|
|
func TestTask_PerformAsync_Completion_Good(t *testing.T) {
|
|
c := New()
|
|
completed := make(chan ActionTaskCompleted, 1)
|
|
|
|
c.RegisterTask(func(_ *Core, task Task) Result {
|
|
return Result{Value: "result", OK: true}
|
|
})
|
|
c.RegisterAction(func(_ *Core, msg Message) Result {
|
|
if evt, ok := msg.(ActionTaskCompleted); ok {
|
|
completed <- evt
|
|
}
|
|
return Result{OK: true}
|
|
})
|
|
|
|
c.PerformAsync("work")
|
|
|
|
select {
|
|
case evt := <-completed:
|
|
assert.Nil(t, evt.Error)
|
|
assert.Equal(t, "result", evt.Result)
|
|
case <-time.After(2 * time.Second):
|
|
t.Fatal("timed out waiting for completion")
|
|
}
|
|
}
|
|
|
|
func TestTask_PerformAsync_NoHandler_Good(t *testing.T) {
|
|
c := New()
|
|
completed := make(chan ActionTaskCompleted, 1)
|
|
|
|
c.RegisterAction(func(_ *Core, msg Message) Result {
|
|
if evt, ok := msg.(ActionTaskCompleted); ok {
|
|
completed <- evt
|
|
}
|
|
return Result{OK: true}
|
|
})
|
|
|
|
c.PerformAsync("unhandled")
|
|
|
|
select {
|
|
case evt := <-completed:
|
|
assert.NotNil(t, evt.Error)
|
|
case <-time.After(2 * time.Second):
|
|
t.Fatal("timed out")
|
|
}
|
|
}
|
|
|
|
func TestTask_PerformAsync_AfterShutdown_Bad(t *testing.T) {
|
|
c := New()
|
|
c.ServiceStartup(context.Background(), nil)
|
|
c.ServiceShutdown(context.Background())
|
|
|
|
r := c.PerformAsync("should not run")
|
|
assert.False(t, r.OK)
|
|
}
|
|
|
|
// --- RegisterAction + RegisterActions ---
|
|
|
|
func TestTask_RegisterAction_Good(t *testing.T) {
|
|
c := New()
|
|
called := false
|
|
c.RegisterAction(func(_ *Core, _ Message) Result {
|
|
called = true
|
|
return Result{OK: true}
|
|
})
|
|
c.ACTION(nil)
|
|
assert.True(t, called)
|
|
}
|
|
|
|
func TestTask_RegisterActions_Good(t *testing.T) {
|
|
c := New()
|
|
count := 0
|
|
h := func(_ *Core, _ Message) Result { count++; return Result{OK: true} }
|
|
c.RegisterActions(h, h)
|
|
c.ACTION(nil)
|
|
assert.Equal(t, 2, count)
|
|
}
|