Complete architectural overhaul of pkg/core:
- All subsystem types renamed to idiomatic Go (no stutter)
- Core struct: App, Embed, Fs, Config, ErrPan, ErrLog, Cli, Service, Lock, Ipc, I18n
- Exports consolidated in core.go, contracts/options in contract.go
- Service() unified get/register: c.Service(), c.Service("name"), c.Service("name", svc)
- Lock() named mutex map: c.Lock("srv"), c.Lock("ipc")
- Error system: Err/ErrLog/ErrPan + Log/LogErr/LogPan (shared ErrSink interface)
- CoreCommand with optional description (i18n resolves from command path)
- Tests moved to tests/ directory (black-box package core_test)
- Removed: ServiceFor/MustServiceFor, global instance, Display/Workspace/Crypt interfaces
- New files: app.go, fs.go, ipc.go, lock.go, i18n.go, task.go, runtime.go, contract.go
Co-Authored-By: Virgil <virgil@lethean.io>
129 lines
2.9 KiB
Go
129 lines
2.9 KiB
Go
package core_test
|
|
|
|
import (
|
|
. "forge.lthn.ai/core/go/pkg/core"
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestNewRuntime(t *testing.T) {
|
|
testCases := []struct {
|
|
name string
|
|
app any
|
|
factories map[string]ServiceFactory
|
|
expectErr bool
|
|
expectErrStr string
|
|
checkRuntime func(*testing.T, *Runtime)
|
|
}{
|
|
{
|
|
name: "Good path",
|
|
app: nil,
|
|
factories: map[string]ServiceFactory{},
|
|
expectErr: false,
|
|
checkRuntime: func(t *testing.T, rt *Runtime) {
|
|
assert.NotNil(t, rt)
|
|
assert.NotNil(t, rt.Core)
|
|
},
|
|
},
|
|
{
|
|
name: "With non-nil app",
|
|
app: &mockApp{},
|
|
factories: map[string]ServiceFactory{},
|
|
expectErr: false,
|
|
checkRuntime: func(t *testing.T, rt *Runtime) {
|
|
assert.NotNil(t, rt)
|
|
assert.NotNil(t, rt.Core)
|
|
assert.NotNil(t, rt.Core.App)
|
|
},
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
rt, err := NewRuntime(tc.app)
|
|
|
|
if tc.expectErr {
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), tc.expectErrStr)
|
|
assert.Nil(t, rt)
|
|
} else {
|
|
assert.NoError(t, err)
|
|
if tc.checkRuntime != nil {
|
|
tc.checkRuntime(t, rt)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestNewWithFactories_Good(t *testing.T) {
|
|
factories := map[string]ServiceFactory{
|
|
"test": func() (any, error) {
|
|
return &MockService{Name: "test"}, nil
|
|
},
|
|
}
|
|
rt, err := NewWithFactories(nil, factories)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, rt)
|
|
svc := rt.Core.Service("test")
|
|
assert.NotNil(t, svc)
|
|
mockSvc, ok := svc.(*MockService)
|
|
assert.True(t, ok)
|
|
assert.Equal(t, "test", mockSvc.Name)
|
|
}
|
|
|
|
func TestNewWithFactories_Bad(t *testing.T) {
|
|
factories := map[string]ServiceFactory{
|
|
"test": func() (any, error) {
|
|
return nil, assert.AnError
|
|
},
|
|
}
|
|
_, err := NewWithFactories(nil, factories)
|
|
assert.Error(t, err)
|
|
assert.ErrorIs(t, err, assert.AnError)
|
|
}
|
|
|
|
func TestNewWithFactories_Ugly(t *testing.T) {
|
|
factories := map[string]ServiceFactory{
|
|
"test": nil,
|
|
}
|
|
_, err := NewWithFactories(nil, factories)
|
|
assert.Error(t, err)
|
|
assert.Contains(t, err.Error(), "factory is nil")
|
|
}
|
|
|
|
func TestRuntime_Lifecycle_Good(t *testing.T) {
|
|
rt, err := NewRuntime(nil)
|
|
assert.NoError(t, err)
|
|
assert.NotNil(t, rt)
|
|
|
|
// ServiceName
|
|
assert.Equal(t, "Core", rt.ServiceName())
|
|
|
|
// ServiceStartup & ServiceShutdown
|
|
// These are simple wrappers around the core methods, which are tested in core_test.go.
|
|
// We call them here to ensure coverage.
|
|
rt.ServiceStartup(context.TODO(), nil)
|
|
rt.ServiceShutdown(context.TODO())
|
|
|
|
// Test shutdown with nil core
|
|
rt.Core = nil
|
|
rt.ServiceShutdown(context.TODO())
|
|
}
|
|
|
|
func TestNewServiceRuntime_Good(t *testing.T) {
|
|
c, err := New()
|
|
assert.NoError(t, err)
|
|
|
|
sr := NewServiceRuntime(c, "test options")
|
|
assert.NotNil(t, sr)
|
|
assert.Equal(t, c, sr.Core())
|
|
|
|
// We can't directly test sr.Cfg() without a registered config service,
|
|
// as it will panic.
|
|
assert.Panics(t, func() {
|
|
sr.Config()
|
|
})
|
|
}
|