* feat: add security logging and fix framework regressions This commit implements comprehensive security event logging and resolves critical regressions in the core framework. Security Logging: - Enhanced `pkg/log` with a `Security` level and helper. - Added `log.Username()` to consistently identify the executing user. - Instrumented GitHub CLI auth, Agentic configuration, filesystem sandbox, MCP handlers, and MCP TCP transport with security logs. - Added `SecurityStyle` to the CLI for consistent visual representation of security events. UniFi Security (CodeQL): - Refactored `pkg/unifi` to remove hardcoded `InsecureSkipVerify`, resolving a high-severity alert. - Added a `--verify-tls` flag and configuration option to control TLS verification. - Updated command handlers to support the new verification parameter. Framework Fixes: - Restored original signatures for `MustServiceFor`, `Config()`, and `Display()` in `pkg/framework/core`, which had been corrupted during a merge. - Fixed `pkg/framework/framework.go` and `pkg/framework/core/runtime_pkg.go` to match the restored signatures. - These fixes resolve project-wide compilation errors caused by the signature mismatches. I encountered significant blockers due to a corrupted state of the `dev` branch after a merge, which introduced breaking changes in the core framework's DI system. I had to manually reconcile these signatures with the expected usage across the codebase to restore build stability. * feat(mcp): add RAG tools (query, ingest, collections) Add vector database tools to the MCP server for RAG operations: - rag_query: Search for relevant documentation using semantic similarity - rag_ingest: Ingest files or directories into the vector database - rag_collections: List available collections Uses existing internal/cmd/rag exports (QueryDocs, IngestDirectory, IngestFile) and pkg/rag for Qdrant client access. Default collection is "hostuk-docs" with topK=5 for queries. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add metrics tools (record, query) Add MCP tools for recording and querying AI/security metrics events. The metrics_record tool writes events to daily JSONL files, and the metrics_query tool provides aggregated statistics by type, repo, and agent. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add 'core mcp serve' command Add CLI command to start the MCP server for AI tool integration. - Create internal/cmd/mcpcmd package with serve subcommand - Support --workspace flag for directory restriction - Handle SIGINT/SIGTERM for clean shutdown - Register in full.go build variant Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(ws): add WebSocket hub package for real-time streaming Add pkg/ws package implementing a hub pattern for WebSocket connections: - Hub manages client connections, broadcasts, and channel subscriptions - Client struct represents connected WebSocket clients - Message types: process_output, process_status, event, error, ping/pong - Channel-based subscription system (subscribe/unsubscribe) - SendProcessOutput and SendProcessStatus for process streaming integration - Full test coverage including concurrency tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(mcp): add process management and WebSocket MCP tools Add MCP tools for process management: - process_start: Start a new external process - process_stop: Gracefully stop a running process - process_kill: Force kill a process - process_list: List all managed processes - process_output: Get captured process output - process_input: Send input to process stdin Add MCP tools for WebSocket: - ws_start: Start WebSocket server for real-time streaming - ws_info: Get hub statistics (clients, channels) Update Service struct with optional process.Service and ws.Hub fields, new WithProcessService and WithWSHub options, getter methods, and Shutdown method for cleanup. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(webview): add browser automation package via Chrome DevTools Protocol Add pkg/webview package for browser automation: - webview.go: Main interface with Connect, Navigate, Click, Type, QuerySelector, Screenshot, Evaluate - cdp.go: Chrome DevTools Protocol WebSocket client implementation - actions.go: DOM action types (Click, Type, Hover, Scroll, etc.) and ActionSequence builder - console.go: Console message capture and filtering with ConsoleWatcher and ExceptionWatcher - angular.go: Angular-specific helpers for router navigation, component access, and Zone.js stability Add MCP tools for webview: - webview_connect/disconnect: Connection management - webview_navigate: Page navigation - webview_click/type/query/wait: DOM interaction - webview_console: Console output capture - webview_eval: JavaScript execution - webview_screenshot: Screenshot capture Add documentation: - docs/mcp/angular-testing.md: Guide for Angular application testing Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: document new packages and BugSETI application - Update CLAUDE.md with documentation for: - pkg/ws (WebSocket hub for real-time streaming) - pkg/webview (Browser automation via CDP) - pkg/mcp (MCP server tools: process, ws, webview) - BugSETI application overview - Add comprehensive README for BugSETI with: - Installation and configuration guide - Usage workflow documentation - Architecture overview - Contributing guidelines Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(bugseti): add BugSETI system tray app with auto-update BugSETI - Distributed Bug Fixing like SETI@home but for code Features: - System tray app with Wails v3 - GitHub issue fetching with label filters - Issue queue with priority management - AI context seeding via seed-agent-developer skill - Automated PR submission flow - Stats tracking and leaderboard - Cross-platform notifications - Self-updating with stable/beta/nightly channels Includes: - cmd/bugseti: Main application with Angular frontend - internal/bugseti: Core services (fetcher, queue, seeder, submit, config, stats, notify) - internal/bugseti/updater: Auto-update system (checker, downloader, installer) - .github/workflows/bugseti-release.yml: CI/CD for all platforms Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: resolve import cycle and code duplication - Remove pkg/log import from pkg/io/local to break import cycle (pkg/log/rotation.go imports pkg/io, creating circular dependency) - Use stderr logging for security events in sandbox escape detection - Remove unused sync/atomic import from core.go - Fix duplicate LogSecurity function declarations in cli/log.go - Update workspace/service.go Crypt() call to match interface Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: update tests for new function signatures and format code - Update core_test.go: Config(), Display() now panic instead of returning error - Update runtime_pkg_test.go: sr.Config() now panics instead of returning error - Update MustServiceFor tests to use assert.Panics - Format BugSETI, MCP tools, and webview packages with gofmt Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Snider <631881+Snider@users.noreply.github.com> Co-authored-by: Claude <developers@lethean.io> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
465 lines
11 KiB
Go
465 lines
11 KiB
Go
// Package ws provides WebSocket support for real-time streaming.
|
|
//
|
|
// The ws package enables live process output, events, and bidirectional communication
|
|
// between the Go backend and web frontends. It implements a hub pattern for managing
|
|
// WebSocket connections and channel-based subscriptions.
|
|
//
|
|
// # Getting Started
|
|
//
|
|
// hub := ws.NewHub()
|
|
// go hub.Run(ctx)
|
|
//
|
|
// // Register HTTP handler
|
|
// http.HandleFunc("/ws", hub.Handler())
|
|
//
|
|
// # Message Types
|
|
//
|
|
// The package defines several message types for different purposes:
|
|
// - TypeProcessOutput: Real-time process output streaming
|
|
// - TypeProcessStatus: Process status updates (running, exited, etc.)
|
|
// - TypeEvent: Generic events
|
|
// - TypeError: Error messages
|
|
// - TypePing/TypePong: Keep-alive messages
|
|
// - TypeSubscribe/TypeUnsubscribe: Channel subscription management
|
|
//
|
|
// # Channel Subscriptions
|
|
//
|
|
// Clients can subscribe to specific channels to receive targeted messages:
|
|
//
|
|
// // Client sends: {"type": "subscribe", "data": "process:proc-1"}
|
|
// // Server broadcasts only to subscribers of "process:proc-1"
|
|
//
|
|
// # Integration with Core
|
|
//
|
|
// The Hub can receive process events via Core.ACTION and forward them to WebSocket clients:
|
|
//
|
|
// core.RegisterAction(func(c *framework.Core, msg framework.Message) error {
|
|
// switch m := msg.(type) {
|
|
// case process.ActionProcessOutput:
|
|
// hub.SendProcessOutput(m.ID, m.Line)
|
|
// case process.ActionProcessExited:
|
|
// hub.SendProcessStatus(m.ID, "exited", m.ExitCode)
|
|
// }
|
|
// return nil
|
|
// })
|
|
package ws
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"net/http"
|
|
"sync"
|
|
"time"
|
|
|
|
"github.com/gorilla/websocket"
|
|
)
|
|
|
|
var upgrader = websocket.Upgrader{
|
|
ReadBufferSize: 1024,
|
|
WriteBufferSize: 1024,
|
|
CheckOrigin: func(r *http.Request) bool {
|
|
return true // Allow all origins for local development
|
|
},
|
|
}
|
|
|
|
// MessageType identifies the type of WebSocket message.
|
|
type MessageType string
|
|
|
|
const (
|
|
// TypeProcessOutput indicates real-time process output.
|
|
TypeProcessOutput MessageType = "process_output"
|
|
// TypeProcessStatus indicates a process status change.
|
|
TypeProcessStatus MessageType = "process_status"
|
|
// TypeEvent indicates a generic event.
|
|
TypeEvent MessageType = "event"
|
|
// TypeError indicates an error message.
|
|
TypeError MessageType = "error"
|
|
// TypePing is a client-to-server keep-alive request.
|
|
TypePing MessageType = "ping"
|
|
// TypePong is the server response to ping.
|
|
TypePong MessageType = "pong"
|
|
// TypeSubscribe requests subscription to a channel.
|
|
TypeSubscribe MessageType = "subscribe"
|
|
// TypeUnsubscribe requests unsubscription from a channel.
|
|
TypeUnsubscribe MessageType = "unsubscribe"
|
|
)
|
|
|
|
// Message is the standard WebSocket message format.
|
|
type Message struct {
|
|
Type MessageType `json:"type"`
|
|
Channel string `json:"channel,omitempty"`
|
|
ProcessID string `json:"processId,omitempty"`
|
|
Data any `json:"data,omitempty"`
|
|
Timestamp time.Time `json:"timestamp"`
|
|
}
|
|
|
|
// Client represents a connected WebSocket client.
|
|
type Client struct {
|
|
hub *Hub
|
|
conn *websocket.Conn
|
|
send chan []byte
|
|
subscriptions map[string]bool
|
|
mu sync.RWMutex
|
|
}
|
|
|
|
// Hub manages WebSocket connections and message broadcasting.
|
|
type Hub struct {
|
|
clients map[*Client]bool
|
|
broadcast chan []byte
|
|
register chan *Client
|
|
unregister chan *Client
|
|
channels map[string]map[*Client]bool
|
|
mu sync.RWMutex
|
|
}
|
|
|
|
// NewHub creates a new WebSocket hub.
|
|
func NewHub() *Hub {
|
|
return &Hub{
|
|
clients: make(map[*Client]bool),
|
|
broadcast: make(chan []byte, 256),
|
|
register: make(chan *Client),
|
|
unregister: make(chan *Client),
|
|
channels: make(map[string]map[*Client]bool),
|
|
}
|
|
}
|
|
|
|
// Run starts the hub's main loop. It should be called in a goroutine.
|
|
// The loop exits when the context is canceled.
|
|
func (h *Hub) Run(ctx context.Context) {
|
|
for {
|
|
select {
|
|
case <-ctx.Done():
|
|
// Close all client connections on shutdown
|
|
h.mu.Lock()
|
|
for client := range h.clients {
|
|
close(client.send)
|
|
delete(h.clients, client)
|
|
}
|
|
h.mu.Unlock()
|
|
return
|
|
case client := <-h.register:
|
|
h.mu.Lock()
|
|
h.clients[client] = true
|
|
h.mu.Unlock()
|
|
case client := <-h.unregister:
|
|
h.mu.Lock()
|
|
if _, ok := h.clients[client]; ok {
|
|
delete(h.clients, client)
|
|
close(client.send)
|
|
// Remove from all channels
|
|
for channel := range client.subscriptions {
|
|
if clients, ok := h.channels[channel]; ok {
|
|
delete(clients, client)
|
|
// Clean up empty channels
|
|
if len(clients) == 0 {
|
|
delete(h.channels, channel)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
h.mu.Unlock()
|
|
case message := <-h.broadcast:
|
|
h.mu.RLock()
|
|
for client := range h.clients {
|
|
select {
|
|
case client.send <- message:
|
|
default:
|
|
// Client buffer full, will be cleaned up
|
|
go func(c *Client) {
|
|
h.unregister <- c
|
|
}(client)
|
|
}
|
|
}
|
|
h.mu.RUnlock()
|
|
}
|
|
}
|
|
}
|
|
|
|
// Subscribe adds a client to a channel.
|
|
func (h *Hub) Subscribe(client *Client, channel string) {
|
|
h.mu.Lock()
|
|
defer h.mu.Unlock()
|
|
|
|
if _, ok := h.channels[channel]; !ok {
|
|
h.channels[channel] = make(map[*Client]bool)
|
|
}
|
|
h.channels[channel][client] = true
|
|
|
|
client.mu.Lock()
|
|
client.subscriptions[channel] = true
|
|
client.mu.Unlock()
|
|
}
|
|
|
|
// Unsubscribe removes a client from a channel.
|
|
func (h *Hub) Unsubscribe(client *Client, channel string) {
|
|
h.mu.Lock()
|
|
defer h.mu.Unlock()
|
|
|
|
if clients, ok := h.channels[channel]; ok {
|
|
delete(clients, client)
|
|
// Clean up empty channels
|
|
if len(clients) == 0 {
|
|
delete(h.channels, channel)
|
|
}
|
|
}
|
|
|
|
client.mu.Lock()
|
|
delete(client.subscriptions, channel)
|
|
client.mu.Unlock()
|
|
}
|
|
|
|
// Broadcast sends a message to all connected clients.
|
|
func (h *Hub) Broadcast(msg Message) error {
|
|
msg.Timestamp = time.Now()
|
|
data, err := json.Marshal(msg)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to marshal message: %w", err)
|
|
}
|
|
|
|
select {
|
|
case h.broadcast <- data:
|
|
default:
|
|
return fmt.Errorf("broadcast channel full")
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// SendToChannel sends a message to all clients subscribed to a channel.
|
|
func (h *Hub) SendToChannel(channel string, msg Message) error {
|
|
msg.Timestamp = time.Now()
|
|
msg.Channel = channel
|
|
data, err := json.Marshal(msg)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to marshal message: %w", err)
|
|
}
|
|
|
|
h.mu.RLock()
|
|
clients, ok := h.channels[channel]
|
|
h.mu.RUnlock()
|
|
|
|
if !ok {
|
|
return nil // No subscribers, not an error
|
|
}
|
|
|
|
for client := range clients {
|
|
select {
|
|
case client.send <- data:
|
|
default:
|
|
// Client buffer full, skip
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// SendProcessOutput sends process output to subscribers of the process channel.
|
|
func (h *Hub) SendProcessOutput(processID string, output string) error {
|
|
return h.SendToChannel("process:"+processID, Message{
|
|
Type: TypeProcessOutput,
|
|
ProcessID: processID,
|
|
Data: output,
|
|
})
|
|
}
|
|
|
|
// SendProcessStatus sends a process status update to subscribers.
|
|
func (h *Hub) SendProcessStatus(processID string, status string, exitCode int) error {
|
|
return h.SendToChannel("process:"+processID, Message{
|
|
Type: TypeProcessStatus,
|
|
ProcessID: processID,
|
|
Data: map[string]any{
|
|
"status": status,
|
|
"exitCode": exitCode,
|
|
},
|
|
})
|
|
}
|
|
|
|
// SendError sends an error message to all connected clients.
|
|
func (h *Hub) SendError(errMsg string) error {
|
|
return h.Broadcast(Message{
|
|
Type: TypeError,
|
|
Data: errMsg,
|
|
})
|
|
}
|
|
|
|
// SendEvent sends a generic event to all connected clients.
|
|
func (h *Hub) SendEvent(eventType string, data any) error {
|
|
return h.Broadcast(Message{
|
|
Type: TypeEvent,
|
|
Data: map[string]any{
|
|
"event": eventType,
|
|
"data": data,
|
|
},
|
|
})
|
|
}
|
|
|
|
// ClientCount returns the number of connected clients.
|
|
func (h *Hub) ClientCount() int {
|
|
h.mu.RLock()
|
|
defer h.mu.RUnlock()
|
|
return len(h.clients)
|
|
}
|
|
|
|
// ChannelCount returns the number of active channels.
|
|
func (h *Hub) ChannelCount() int {
|
|
h.mu.RLock()
|
|
defer h.mu.RUnlock()
|
|
return len(h.channels)
|
|
}
|
|
|
|
// ChannelSubscriberCount returns the number of subscribers for a channel.
|
|
func (h *Hub) ChannelSubscriberCount(channel string) int {
|
|
h.mu.RLock()
|
|
defer h.mu.RUnlock()
|
|
if clients, ok := h.channels[channel]; ok {
|
|
return len(clients)
|
|
}
|
|
return 0
|
|
}
|
|
|
|
// HubStats contains hub statistics.
|
|
type HubStats struct {
|
|
Clients int `json:"clients"`
|
|
Channels int `json:"channels"`
|
|
}
|
|
|
|
// Stats returns current hub statistics.
|
|
func (h *Hub) Stats() HubStats {
|
|
h.mu.RLock()
|
|
defer h.mu.RUnlock()
|
|
return HubStats{
|
|
Clients: len(h.clients),
|
|
Channels: len(h.channels),
|
|
}
|
|
}
|
|
|
|
// HandleWebSocket is an alias for Handler for clearer API.
|
|
func (h *Hub) HandleWebSocket(w http.ResponseWriter, r *http.Request) {
|
|
h.Handler()(w, r)
|
|
}
|
|
|
|
// Handler returns an HTTP handler for WebSocket connections.
|
|
func (h *Hub) Handler() http.HandlerFunc {
|
|
return func(w http.ResponseWriter, r *http.Request) {
|
|
conn, err := upgrader.Upgrade(w, r, nil)
|
|
if err != nil {
|
|
return
|
|
}
|
|
|
|
client := &Client{
|
|
hub: h,
|
|
conn: conn,
|
|
send: make(chan []byte, 256),
|
|
subscriptions: make(map[string]bool),
|
|
}
|
|
|
|
h.register <- client
|
|
|
|
go client.writePump()
|
|
go client.readPump()
|
|
}
|
|
}
|
|
|
|
// readPump handles incoming messages from the client.
|
|
func (c *Client) readPump() {
|
|
defer func() {
|
|
c.hub.unregister <- c
|
|
c.conn.Close()
|
|
}()
|
|
|
|
c.conn.SetReadLimit(65536)
|
|
c.conn.SetReadDeadline(time.Now().Add(60 * time.Second))
|
|
c.conn.SetPongHandler(func(string) error {
|
|
c.conn.SetReadDeadline(time.Now().Add(60 * time.Second))
|
|
return nil
|
|
})
|
|
|
|
for {
|
|
_, message, err := c.conn.ReadMessage()
|
|
if err != nil {
|
|
break
|
|
}
|
|
|
|
var msg Message
|
|
if err := json.Unmarshal(message, &msg); err != nil {
|
|
continue
|
|
}
|
|
|
|
switch msg.Type {
|
|
case TypeSubscribe:
|
|
if channel, ok := msg.Data.(string); ok {
|
|
c.hub.Subscribe(c, channel)
|
|
}
|
|
case TypeUnsubscribe:
|
|
if channel, ok := msg.Data.(string); ok {
|
|
c.hub.Unsubscribe(c, channel)
|
|
}
|
|
case TypePing:
|
|
c.send <- mustMarshal(Message{Type: TypePong, Timestamp: time.Now()})
|
|
}
|
|
}
|
|
}
|
|
|
|
// writePump sends messages to the client.
|
|
func (c *Client) writePump() {
|
|
ticker := time.NewTicker(30 * time.Second)
|
|
defer func() {
|
|
ticker.Stop()
|
|
c.conn.Close()
|
|
}()
|
|
|
|
for {
|
|
select {
|
|
case message, ok := <-c.send:
|
|
c.conn.SetWriteDeadline(time.Now().Add(10 * time.Second))
|
|
if !ok {
|
|
c.conn.WriteMessage(websocket.CloseMessage, []byte{})
|
|
return
|
|
}
|
|
|
|
w, err := c.conn.NextWriter(websocket.TextMessage)
|
|
if err != nil {
|
|
return
|
|
}
|
|
w.Write(message)
|
|
|
|
// Batch queued messages
|
|
n := len(c.send)
|
|
for i := 0; i < n; i++ {
|
|
w.Write([]byte{'\n'})
|
|
w.Write(<-c.send)
|
|
}
|
|
|
|
if err := w.Close(); err != nil {
|
|
return
|
|
}
|
|
case <-ticker.C:
|
|
c.conn.SetWriteDeadline(time.Now().Add(10 * time.Second))
|
|
if err := c.conn.WriteMessage(websocket.PingMessage, nil); err != nil {
|
|
return
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func mustMarshal(v any) []byte {
|
|
data, _ := json.Marshal(v)
|
|
return data
|
|
}
|
|
|
|
// Subscriptions returns a copy of the client's current subscriptions.
|
|
func (c *Client) Subscriptions() []string {
|
|
c.mu.RLock()
|
|
defer c.mu.RUnlock()
|
|
|
|
result := make([]string, 0, len(c.subscriptions))
|
|
for channel := range c.subscriptions {
|
|
result = append(result, channel)
|
|
}
|
|
return result
|
|
}
|
|
|
|
// Close closes the client connection.
|
|
func (c *Client) Close() error {
|
|
c.hub.unregister <- c
|
|
return c.conn.Close()
|
|
}
|