* Standardize CLI error handling and deprecate cli.Fatal - Updated `pkg/cli/output.go` to send error and warning output to `os.Stderr`. - Added `ErrorWrap`, `ErrorWrapVerb`, and `ErrorWrapAction` helpers to `pkg/cli/output.go`. - Deprecated `cli.Fatal` family of functions in `pkg/cli/errors.go`. - Introduced `cli.ExitError` and `cli.Exit` helper to allow commands to return specific exit codes. - Updated `pkg/cli/app.go` to silence Cobra errors and handle error printing and process exit in `Main`. - Refactored multiple commands (QA, SDK, CI, Updater) to return errors instead of exiting abruptly. - Replaced direct `os.Stderr` writes with standardized CLI or log helpers across the codebase. - Updated tests to accommodate changes in output destination. * Fix CI failure: remove unused fmt import in pkg/mcp/transport_tcp.go - Removed unused "fmt" import in `pkg/mcp/transport_tcp.go` that was causing CI failure. - Verified build and relevant tests pass. * Standardize CLI error handling and fix formatting issues - Updated `pkg/cli/output.go` to send error and warning output to `os.Stderr`. - Added `ErrorWrap`, `ErrorWrapVerb`, and `ErrorWrapAction` helpers to `pkg/cli/output.go`. - Deprecated `cli.Fatal` family of functions in `pkg/cli/errors.go`. - Introduced `cli.ExitError` and `cli.Exit` helper to allow commands to return specific exit codes. - Updated `pkg/cli/app.go` to silence Cobra errors and handle error printing and process exit in `Main`. - Refactored multiple commands (QA, SDK, CI, Updater) to return errors instead of exiting abruptly. - Replaced direct `os.Stderr` writes with standardized CLI or log helpers across the codebase. - Updated tests to accommodate changes in output destination. - Fixed formatting in `pkg/io/local/client.go`. - Removed unused `fmt` import in `pkg/mcp/transport_tcp.go`. * Standardize CLI error handling and fix CI issues - Updated `pkg/cli/output.go` to send error and warning output to `os.Stderr`. - Added `ErrorWrap`, `ErrorWrapVerb`, and `ErrorWrapAction` helpers to `pkg/cli/output.go`. - Deprecated `cli.Fatal` family of functions in `pkg/cli/errors.go`. - Introduced `cli.ExitError` and `cli.Exit` helper to allow commands to return specific exit codes. - Updated `pkg/cli/app.go` to silence Cobra errors and handle error printing and process exit in `Main`. - Refactored multiple commands (QA, SDK, CI, Updater) to return errors instead of exiting abruptly. - Replaced direct `os.Stderr` writes with standardized CLI or log helpers across the codebase. - Updated tests to accommodate changes in output destination. - Fixed formatting in `pkg/io/local/client.go`. - Removed unused `fmt` import in `pkg/mcp/transport_tcp.go`. - Fixed potential `gh` context issue in `.github/workflows/auto-merge.yml` by providing `GH_REPO`. --------- Co-authored-by: Claude <developers@lethean.io>
101 lines
1.4 KiB
Go
101 lines
1.4 KiB
Go
package cli
|
|
|
|
import (
|
|
"bytes"
|
|
"io"
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
func captureOutput(f func()) string {
|
|
oldOut := os.Stdout
|
|
oldErr := os.Stderr
|
|
r, w, _ := os.Pipe()
|
|
os.Stdout = w
|
|
os.Stderr = w
|
|
|
|
f()
|
|
|
|
_ = w.Close()
|
|
os.Stdout = oldOut
|
|
os.Stderr = oldErr
|
|
|
|
var buf bytes.Buffer
|
|
_, _ = io.Copy(&buf, r)
|
|
return buf.String()
|
|
}
|
|
|
|
func TestSemanticOutput(t *testing.T) {
|
|
UseASCII()
|
|
|
|
// Test Success
|
|
out := captureOutput(func() {
|
|
Success("done")
|
|
})
|
|
if out == "" {
|
|
t.Error("Success output empty")
|
|
}
|
|
|
|
// Test Error
|
|
out = captureOutput(func() {
|
|
Error("fail")
|
|
})
|
|
if out == "" {
|
|
t.Error("Error output empty")
|
|
}
|
|
|
|
// Test Warn
|
|
out = captureOutput(func() {
|
|
Warn("warn")
|
|
})
|
|
if out == "" {
|
|
t.Error("Warn output empty")
|
|
}
|
|
|
|
// Test Info
|
|
out = captureOutput(func() {
|
|
Info("info")
|
|
})
|
|
if out == "" {
|
|
t.Error("Info output empty")
|
|
}
|
|
|
|
// Test Task
|
|
out = captureOutput(func() {
|
|
Task("task", "msg")
|
|
})
|
|
if out == "" {
|
|
t.Error("Task output empty")
|
|
}
|
|
|
|
// Test Section
|
|
out = captureOutput(func() {
|
|
Section("section")
|
|
})
|
|
if out == "" {
|
|
t.Error("Section output empty")
|
|
}
|
|
|
|
// Test Hint
|
|
out = captureOutput(func() {
|
|
Hint("hint", "msg")
|
|
})
|
|
if out == "" {
|
|
t.Error("Hint output empty")
|
|
}
|
|
|
|
// Test Result
|
|
out = captureOutput(func() {
|
|
Result(true, "pass")
|
|
})
|
|
if out == "" {
|
|
t.Error("Result(true) output empty")
|
|
}
|
|
|
|
out = captureOutput(func() {
|
|
Result(false, "fail")
|
|
})
|
|
if out == "" {
|
|
t.Error("Result(false) output empty")
|
|
}
|
|
}
|