2dff772a40
Plans 1-5 complete for core/go scope. 456 tests, 84.4% coverage, 100% AX-7 naming.
Critical bugs (Plan 1):
- P4-3+P7-3: ACTION broadcast calls all handlers with panic recovery
- P7-2+P7-4: RunE() with defer ServiceShutdown, Run() delegates
- P3-1: Startable/Stoppable return Result (breaking, clean)
- P9-1: Zero os/exec — App.Find() rewritten with os.Stat+PATH
- I3: Embed() removed, I15: New() comment fixed
- I9: CommandLifecycle removed → Command.Managed field
Registry[T] (Plan 2):
- Universal thread-safe named collection with 3 lock modes
- All 5 registries migrated: services, commands, drive, data, lock
- Insertion order preserved (fixes P4-1)
- c.RegistryOf("name") cross-cutting accessor
Action/Task system (Plan 3):
- Action type with Run()/Exists(), ActionHandler signature
- c.Action("name") dual-purpose accessor (register/invoke)
- TaskDef with Steps — sequential chain, async dispatch, previous-input piping
- Panic recovery on all Action execution
- broadcast() internal, ACTION() sugar
Process primitive (Plan 4):
- c.Process() returns Action sugar — Run/RunIn/RunWithEnv/Start/Kill/Exists
- No deps added — delegates to c.Action("process.*")
- Permission-by-registration: no handler = no capability
Missing primitives (Plan 5):
- core.ID() — atomic counter + crypto/rand suffix
- ValidateName() / SanitisePath() — reusable validation
- Fs.WriteAtomic() — write-to-temp-then-rename
- Fs.NewUnrestricted() / Fs.Root() — legitimate sandbox bypass
- AX-7: 456/456 tests renamed to TestFile_Function_{Good,Bad,Ugly}
Co-Authored-By: Virgil <virgil@lethean.io>
102 lines
2.3 KiB
Go
102 lines
2.3 KiB
Go
package core_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
. "dappco.re/go/core"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
// --- Config ---
|
|
|
|
func TestConfig_SetGet_Good(t *testing.T) {
|
|
c := New()
|
|
c.Config().Set("api_url", "https://api.lthn.ai")
|
|
c.Config().Set("max_agents", 5)
|
|
|
|
r := c.Config().Get("api_url")
|
|
assert.True(t, r.OK)
|
|
assert.Equal(t, "https://api.lthn.ai", r.Value)
|
|
}
|
|
|
|
func TestConfig_Get_Bad(t *testing.T) {
|
|
c := New()
|
|
r := c.Config().Get("missing")
|
|
assert.False(t, r.OK)
|
|
assert.Nil(t, r.Value)
|
|
}
|
|
|
|
func TestConfig_TypedAccessors_Good(t *testing.T) {
|
|
c := New()
|
|
c.Config().Set("url", "https://lthn.ai")
|
|
c.Config().Set("port", 8080)
|
|
c.Config().Set("debug", true)
|
|
|
|
assert.Equal(t, "https://lthn.ai", c.Config().String("url"))
|
|
assert.Equal(t, 8080, c.Config().Int("port"))
|
|
assert.True(t, c.Config().Bool("debug"))
|
|
}
|
|
|
|
func TestConfig_TypedAccessors_Bad(t *testing.T) {
|
|
c := New()
|
|
// Missing keys return zero values
|
|
assert.Equal(t, "", c.Config().String("missing"))
|
|
assert.Equal(t, 0, c.Config().Int("missing"))
|
|
assert.False(t, c.Config().Bool("missing"))
|
|
}
|
|
|
|
// --- Feature Flags ---
|
|
|
|
func TestConfig_Features_Good(t *testing.T) {
|
|
c := New()
|
|
c.Config().Enable("dark-mode")
|
|
c.Config().Enable("beta")
|
|
|
|
assert.True(t, c.Config().Enabled("dark-mode"))
|
|
assert.True(t, c.Config().Enabled("beta"))
|
|
assert.False(t, c.Config().Enabled("missing"))
|
|
}
|
|
|
|
func TestConfig_Features_Disable_Good(t *testing.T) {
|
|
c := New()
|
|
c.Config().Enable("feature")
|
|
assert.True(t, c.Config().Enabled("feature"))
|
|
|
|
c.Config().Disable("feature")
|
|
assert.False(t, c.Config().Enabled("feature"))
|
|
}
|
|
|
|
func TestConfig_Features_CaseSensitive(t *testing.T) {
|
|
c := New()
|
|
c.Config().Enable("Feature")
|
|
assert.True(t, c.Config().Enabled("Feature"))
|
|
assert.False(t, c.Config().Enabled("feature"))
|
|
}
|
|
|
|
func TestConfig_EnabledFeatures_Good(t *testing.T) {
|
|
c := New()
|
|
c.Config().Enable("a")
|
|
c.Config().Enable("b")
|
|
c.Config().Enable("c")
|
|
c.Config().Disable("b")
|
|
|
|
features := c.Config().EnabledFeatures()
|
|
assert.Contains(t, features, "a")
|
|
assert.Contains(t, features, "c")
|
|
assert.NotContains(t, features, "b")
|
|
}
|
|
|
|
// --- ConfigVar ---
|
|
|
|
func TestConfig_ConfigVar_Good(t *testing.T) {
|
|
v := NewConfigVar("hello")
|
|
assert.True(t, v.IsSet())
|
|
assert.Equal(t, "hello", v.Get())
|
|
|
|
v.Set("world")
|
|
assert.Equal(t, "world", v.Get())
|
|
|
|
v.Unset()
|
|
assert.False(t, v.IsSet())
|
|
assert.Equal(t, "", v.Get())
|
|
}
|