2dff772a40
Plans 1-5 complete for core/go scope. 456 tests, 84.4% coverage, 100% AX-7 naming.
Critical bugs (Plan 1):
- P4-3+P7-3: ACTION broadcast calls all handlers with panic recovery
- P7-2+P7-4: RunE() with defer ServiceShutdown, Run() delegates
- P3-1: Startable/Stoppable return Result (breaking, clean)
- P9-1: Zero os/exec — App.Find() rewritten with os.Stat+PATH
- I3: Embed() removed, I15: New() comment fixed
- I9: CommandLifecycle removed → Command.Managed field
Registry[T] (Plan 2):
- Universal thread-safe named collection with 3 lock modes
- All 5 registries migrated: services, commands, drive, data, lock
- Insertion order preserved (fixes P4-1)
- c.RegistryOf("name") cross-cutting accessor
Action/Task system (Plan 3):
- Action type with Run()/Exists(), ActionHandler signature
- c.Action("name") dual-purpose accessor (register/invoke)
- TaskDef with Steps — sequential chain, async dispatch, previous-input piping
- Panic recovery on all Action execution
- broadcast() internal, ACTION() sugar
Process primitive (Plan 4):
- c.Process() returns Action sugar — Run/RunIn/RunWithEnv/Start/Kill/Exists
- No deps added — delegates to c.Action("process.*")
- Permission-by-registration: no handler = no capability
Missing primitives (Plan 5):
- core.ID() — atomic counter + crypto/rand suffix
- ValidateName() / SanitisePath() — reusable validation
- Fs.WriteAtomic() — write-to-temp-then-rename
- Fs.NewUnrestricted() / Fs.Root() — legitimate sandbox bypass
- AX-7: 456/456 tests renamed to TestFile_Function_{Good,Bad,Ugly}
Co-Authored-By: Virgil <virgil@lethean.io>
68 lines
1.6 KiB
Go
68 lines
1.6 KiB
Go
// SPDX-License-Identifier: EUPL-1.2
|
|
|
|
// Synchronisation, locking, and lifecycle snapshots for the Core framework.
|
|
|
|
package core
|
|
|
|
import (
|
|
"sync"
|
|
)
|
|
|
|
// Lock is the DTO for a named mutex.
|
|
type Lock struct {
|
|
Name string
|
|
Mutex *sync.RWMutex
|
|
locks *Registry[*sync.RWMutex] // per-Core named mutexes
|
|
}
|
|
|
|
// Lock returns a named Lock, creating the mutex if needed.
|
|
// Locks are per-Core — separate Core instances do not share mutexes.
|
|
func (c *Core) Lock(name string) *Lock {
|
|
r := c.lock.locks.Get(name)
|
|
if r.OK {
|
|
return &Lock{Name: name, Mutex: r.Value.(*sync.RWMutex)}
|
|
}
|
|
m := &sync.RWMutex{}
|
|
c.lock.locks.Set(name, m)
|
|
return &Lock{Name: name, Mutex: m}
|
|
}
|
|
|
|
// LockEnable marks that the service lock should be applied after initialisation.
|
|
func (c *Core) LockEnable(name ...string) {
|
|
c.services.lockEnabled = true
|
|
}
|
|
|
|
// LockApply activates the service lock if it was enabled.
|
|
func (c *Core) LockApply(name ...string) {
|
|
if c.services.lockEnabled {
|
|
c.services.Lock()
|
|
}
|
|
}
|
|
|
|
// Startables returns services that have an OnStart function, in registration order.
|
|
func (c *Core) Startables() Result {
|
|
if c.services == nil {
|
|
return Result{}
|
|
}
|
|
var out []*Service
|
|
c.services.Each(func(_ string, svc *Service) {
|
|
if svc.OnStart != nil {
|
|
out = append(out, svc)
|
|
}
|
|
})
|
|
return Result{out, true}
|
|
}
|
|
|
|
// Stoppables returns services that have an OnStop function, in registration order.
|
|
func (c *Core) Stoppables() Result {
|
|
if c.services == nil {
|
|
return Result{}
|
|
}
|
|
var out []*Service
|
|
c.services.Each(func(_ string, svc *Service) {
|
|
if svc.OnStop != nil {
|
|
out = append(out, svc)
|
|
}
|
|
})
|
|
return Result{out, true}
|
|
}
|