* feat(go): make go fmt git-aware by default - By default, only check changed Go files (modified, staged, untracked) - Add --all flag to check all files (previous behaviour) - Reduces noise when running fmt on large codebases Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(build): minimal output by default, add missing i18n - Default output now shows single line: "Success Built N artifacts (dir)" - Add --verbose/-v flag to show full detailed output - Add all missing i18n translations for build commands - Errors still show failure reason in minimal mode Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat: add root-level `core git` command - Create pkg/gitcmd with git workflow commands as root menu - Export command builders from pkg/dev (AddCommitCommand, etc.) - Commands available under both `core git` and `core dev` for compatibility - Git commands: health, commit, push, pull, work, sync, apply - GitHub orchestration stays in dev: issues, reviews, ci, impact Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * feat(qa): add docblock coverage checking Implement docblock/docstring coverage analysis for Go code: - New `core qa docblock` command to check coverage - Shows compact file:line list when under threshold - Integrate with `core go qa` as a default check - Add --docblock-threshold flag (default 80%) The checker uses Go AST parsing to find exported symbols (functions, types, consts, vars) without documentation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback - Fix doc comment: "status" → "health" in gitcmd package - Implement --check flag for `core go fmt` (exits non-zero if files need formatting) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: add docstrings for 100% coverage Add documentation comments to all exported symbols: - pkg/build: ProjectType constants - pkg/cli: LogLevel, RenderStyle, TableStyle - pkg/framework: ServiceFor, MustServiceFor, Core.Core - pkg/git: GitError.Error, GitError.Unwrap - pkg/i18n: Handler Match/Handle methods - pkg/log: Level constants - pkg/mcp: Tool input/output types - pkg/php: Service constants, QA types, service methods - pkg/process: ServiceError.Error - pkg/repos: RepoType constants - pkg/setup: ChangeType, ChangeCategory constants - pkg/workspace: AddWorkspaceCommands Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: standardize line endings to LF Add .gitattributes to enforce LF line endings for all text files. Normalize all existing files to use Unix-style line endings. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback - cmd_format.go: validate --check/--fix mutual exclusivity, capture stderr - cmd_docblock.go: return error instead of os.Exit(1) for proper error handling Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address CodeRabbit review feedback (round 2) - linuxkit.go: propagate state update errors, handle cmd.Wait() errors in waitForExit - mcp.go: guard against empty old_string in editDiff to prevent runaway edits - cmd_docblock.go: log parse errors instead of silently skipping Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
167 lines
3 KiB
Go
167 lines
3 KiB
Go
package process
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"os/exec"
|
|
"sync"
|
|
"time"
|
|
)
|
|
|
|
// Process represents a managed external process.
|
|
type Process struct {
|
|
ID string
|
|
Command string
|
|
Args []string
|
|
Dir string
|
|
Env []string
|
|
StartedAt time.Time
|
|
Status Status
|
|
ExitCode int
|
|
Duration time.Duration
|
|
|
|
cmd *exec.Cmd
|
|
ctx context.Context
|
|
cancel context.CancelFunc
|
|
output *RingBuffer
|
|
stdin io.WriteCloser
|
|
done chan struct{}
|
|
mu sync.RWMutex
|
|
}
|
|
|
|
// Info returns a snapshot of process state.
|
|
func (p *Process) Info() Info {
|
|
p.mu.RLock()
|
|
defer p.mu.RUnlock()
|
|
|
|
pid := 0
|
|
if p.cmd != nil && p.cmd.Process != nil {
|
|
pid = p.cmd.Process.Pid
|
|
}
|
|
|
|
return Info{
|
|
ID: p.ID,
|
|
Command: p.Command,
|
|
Args: p.Args,
|
|
Dir: p.Dir,
|
|
StartedAt: p.StartedAt,
|
|
Status: p.Status,
|
|
ExitCode: p.ExitCode,
|
|
Duration: p.Duration,
|
|
PID: pid,
|
|
}
|
|
}
|
|
|
|
// Output returns the captured output as a string.
|
|
func (p *Process) Output() string {
|
|
p.mu.RLock()
|
|
defer p.mu.RUnlock()
|
|
if p.output == nil {
|
|
return ""
|
|
}
|
|
return p.output.String()
|
|
}
|
|
|
|
// OutputBytes returns the captured output as bytes.
|
|
func (p *Process) OutputBytes() []byte {
|
|
p.mu.RLock()
|
|
defer p.mu.RUnlock()
|
|
if p.output == nil {
|
|
return nil
|
|
}
|
|
return p.output.Bytes()
|
|
}
|
|
|
|
// IsRunning returns true if the process is still executing.
|
|
func (p *Process) IsRunning() bool {
|
|
p.mu.RLock()
|
|
defer p.mu.RUnlock()
|
|
return p.Status == StatusRunning
|
|
}
|
|
|
|
// Wait blocks until the process exits.
|
|
func (p *Process) Wait() error {
|
|
<-p.done
|
|
p.mu.RLock()
|
|
defer p.mu.RUnlock()
|
|
if p.Status == StatusFailed || p.Status == StatusKilled {
|
|
return &exec.ExitError{}
|
|
}
|
|
if p.ExitCode != 0 {
|
|
return &exec.ExitError{}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Done returns a channel that closes when the process exits.
|
|
func (p *Process) Done() <-chan struct{} {
|
|
return p.done
|
|
}
|
|
|
|
// Kill forcefully terminates the process.
|
|
func (p *Process) Kill() error {
|
|
p.mu.Lock()
|
|
defer p.mu.Unlock()
|
|
|
|
if p.Status != StatusRunning {
|
|
return nil
|
|
}
|
|
|
|
if p.cmd == nil || p.cmd.Process == nil {
|
|
return nil
|
|
}
|
|
|
|
return p.cmd.Process.Kill()
|
|
}
|
|
|
|
// Signal sends a signal to the process.
|
|
func (p *Process) Signal(sig interface{ Signal() }) error {
|
|
p.mu.Lock()
|
|
defer p.mu.Unlock()
|
|
|
|
if p.Status != StatusRunning {
|
|
return nil
|
|
}
|
|
|
|
if p.cmd == nil || p.cmd.Process == nil {
|
|
return nil
|
|
}
|
|
|
|
// Type assert to os.Signal for Process.Signal
|
|
if osSig, ok := sig.(interface{ String() string }); ok {
|
|
_ = osSig // Satisfy linter
|
|
}
|
|
|
|
return p.cmd.Process.Kill() // Simplified - would use Signal in full impl
|
|
}
|
|
|
|
// SendInput writes to the process stdin.
|
|
func (p *Process) SendInput(input string) error {
|
|
p.mu.RLock()
|
|
defer p.mu.RUnlock()
|
|
|
|
if p.Status != StatusRunning {
|
|
return ErrProcessNotRunning
|
|
}
|
|
|
|
if p.stdin == nil {
|
|
return ErrStdinNotAvailable
|
|
}
|
|
|
|
_, err := p.stdin.Write([]byte(input))
|
|
return err
|
|
}
|
|
|
|
// CloseStdin closes the process stdin pipe.
|
|
func (p *Process) CloseStdin() error {
|
|
p.mu.Lock()
|
|
defer p.mu.Unlock()
|
|
|
|
if p.stdin == nil {
|
|
return nil
|
|
}
|
|
|
|
err := p.stdin.Close()
|
|
p.stdin = nil
|
|
return err
|
|
}
|