go/pkg/php/deploy_test.go
Snider fdc108c69e
feat: git command, build improvements, and go fmt git-aware (#74)
* feat(go): make go fmt git-aware by default

- By default, only check changed Go files (modified, staged, untracked)
- Add --all flag to check all files (previous behaviour)
- Reduces noise when running fmt on large codebases

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(build): minimal output by default, add missing i18n

- Default output now shows single line: "Success Built N artifacts (dir)"
- Add --verbose/-v flag to show full detailed output
- Add all missing i18n translations for build commands
- Errors still show failure reason in minimal mode

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat: add root-level `core git` command

- Create pkg/gitcmd with git workflow commands as root menu
- Export command builders from pkg/dev (AddCommitCommand, etc.)
- Commands available under both `core git` and `core dev` for compatibility
- Git commands: health, commit, push, pull, work, sync, apply
- GitHub orchestration stays in dev: issues, reviews, ci, impact

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat(qa): add docblock coverage checking

Implement docblock/docstring coverage analysis for Go code:
- New `core qa docblock` command to check coverage
- Shows compact file:line list when under threshold
- Integrate with `core go qa` as a default check
- Add --docblock-threshold flag (default 80%)

The checker uses Go AST parsing to find exported symbols
(functions, types, consts, vars) without documentation.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: address CodeRabbit review feedback

- Fix doc comment: "status" → "health" in gitcmd package
- Implement --check flag for `core go fmt` (exits non-zero if files need formatting)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* docs: add docstrings for 100% coverage

Add documentation comments to all exported symbols:
- pkg/build: ProjectType constants
- pkg/cli: LogLevel, RenderStyle, TableStyle
- pkg/framework: ServiceFor, MustServiceFor, Core.Core
- pkg/git: GitError.Error, GitError.Unwrap
- pkg/i18n: Handler Match/Handle methods
- pkg/log: Level constants
- pkg/mcp: Tool input/output types
- pkg/php: Service constants, QA types, service methods
- pkg/process: ServiceError.Error
- pkg/repos: RepoType constants
- pkg/setup: ChangeType, ChangeCategory constants
- pkg/workspace: AddWorkspaceCommands

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* chore: standardize line endings to LF

Add .gitattributes to enforce LF line endings for all text files.
Normalize all existing files to use Unix-style line endings.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: address CodeRabbit review feedback

- cmd_format.go: validate --check/--fix mutual exclusivity, capture stderr
- cmd_docblock.go: return error instead of os.Exit(1) for proper error handling

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: address CodeRabbit review feedback (round 2)

- linuxkit.go: propagate state update errors, handle cmd.Wait() errors in waitForExit
- mcp.go: guard against empty old_string in editDiff to prevent runaway edits
- cmd_docblock.go: log parse errors instead of silently skipping

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-02-01 10:48:44 +00:00

257 lines
6.3 KiB
Go

package php
import (
"os"
"path/filepath"
"testing"
)
func TestLoadCoolifyConfig_Good(t *testing.T) {
tests := []struct {
name string
envContent string
wantURL string
wantToken string
wantAppID string
wantStaging string
}{
{
name: "all values set",
envContent: `COOLIFY_URL=https://coolify.example.com
COOLIFY_TOKEN=secret-token
COOLIFY_APP_ID=app-123
COOLIFY_STAGING_APP_ID=staging-456`,
wantURL: "https://coolify.example.com",
wantToken: "secret-token",
wantAppID: "app-123",
wantStaging: "staging-456",
},
{
name: "quoted values",
envContent: `COOLIFY_URL="https://coolify.example.com"
COOLIFY_TOKEN='secret-token'
COOLIFY_APP_ID="app-123"`,
wantURL: "https://coolify.example.com",
wantToken: "secret-token",
wantAppID: "app-123",
},
{
name: "with comments and blank lines",
envContent: `# Coolify configuration
COOLIFY_URL=https://coolify.example.com
# API token
COOLIFY_TOKEN=secret-token
COOLIFY_APP_ID=app-123
# COOLIFY_STAGING_APP_ID=not-this`,
wantURL: "https://coolify.example.com",
wantToken: "secret-token",
wantAppID: "app-123",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Create temp directory
dir := t.TempDir()
envPath := filepath.Join(dir, ".env")
// Write .env file
if err := os.WriteFile(envPath, []byte(tt.envContent), 0644); err != nil {
t.Fatalf("failed to write .env: %v", err)
}
// Load config
config, err := LoadCoolifyConfig(dir)
if err != nil {
t.Fatalf("LoadCoolifyConfig() error = %v", err)
}
if config.URL != tt.wantURL {
t.Errorf("URL = %q, want %q", config.URL, tt.wantURL)
}
if config.Token != tt.wantToken {
t.Errorf("Token = %q, want %q", config.Token, tt.wantToken)
}
if config.AppID != tt.wantAppID {
t.Errorf("AppID = %q, want %q", config.AppID, tt.wantAppID)
}
if tt.wantStaging != "" && config.StagingAppID != tt.wantStaging {
t.Errorf("StagingAppID = %q, want %q", config.StagingAppID, tt.wantStaging)
}
})
}
}
func TestLoadCoolifyConfig_Bad(t *testing.T) {
tests := []struct {
name string
envContent string
wantErr string
}{
{
name: "missing URL",
envContent: "COOLIFY_TOKEN=secret",
wantErr: "COOLIFY_URL is not set",
},
{
name: "missing token",
envContent: "COOLIFY_URL=https://coolify.example.com",
wantErr: "COOLIFY_TOKEN is not set",
},
{
name: "empty values",
envContent: "COOLIFY_URL=\nCOOLIFY_TOKEN=",
wantErr: "COOLIFY_URL is not set",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Create temp directory
dir := t.TempDir()
envPath := filepath.Join(dir, ".env")
// Write .env file
if err := os.WriteFile(envPath, []byte(tt.envContent), 0644); err != nil {
t.Fatalf("failed to write .env: %v", err)
}
// Load config
_, err := LoadCoolifyConfig(dir)
if err == nil {
t.Fatal("LoadCoolifyConfig() expected error, got nil")
}
if err.Error() != tt.wantErr {
t.Errorf("error = %q, want %q", err.Error(), tt.wantErr)
}
})
}
}
func TestGetAppIDForEnvironment_Good(t *testing.T) {
config := &CoolifyConfig{
URL: "https://coolify.example.com",
Token: "token",
AppID: "prod-123",
StagingAppID: "staging-456",
}
tests := []struct {
name string
env Environment
wantID string
}{
{
name: "production environment",
env: EnvProduction,
wantID: "prod-123",
},
{
name: "staging environment",
env: EnvStaging,
wantID: "staging-456",
},
{
name: "empty defaults to production",
env: "",
wantID: "prod-123",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
id := getAppIDForEnvironment(config, tt.env)
if id != tt.wantID {
t.Errorf("getAppIDForEnvironment() = %q, want %q", id, tt.wantID)
}
})
}
}
func TestGetAppIDForEnvironment_FallbackToProduction(t *testing.T) {
config := &CoolifyConfig{
URL: "https://coolify.example.com",
Token: "token",
AppID: "prod-123",
// No staging app ID
}
// Staging should fall back to production
id := getAppIDForEnvironment(config, EnvStaging)
if id != "prod-123" {
t.Errorf("getAppIDForEnvironment(EnvStaging) = %q, want %q (should fallback)", id, "prod-123")
}
}
func TestIsDeploymentComplete_Good(t *testing.T) {
completeStatuses := []string{"finished", "success", "failed", "error", "cancelled"}
for _, status := range completeStatuses {
if !IsDeploymentComplete(status) {
t.Errorf("IsDeploymentComplete(%q) = false, want true", status)
}
}
incompleteStatuses := []string{"queued", "building", "deploying", "pending", "rolling_back"}
for _, status := range incompleteStatuses {
if IsDeploymentComplete(status) {
t.Errorf("IsDeploymentComplete(%q) = true, want false", status)
}
}
}
func TestIsDeploymentSuccessful_Good(t *testing.T) {
successStatuses := []string{"finished", "success"}
for _, status := range successStatuses {
if !IsDeploymentSuccessful(status) {
t.Errorf("IsDeploymentSuccessful(%q) = false, want true", status)
}
}
failedStatuses := []string{"failed", "error", "cancelled", "queued", "building"}
for _, status := range failedStatuses {
if IsDeploymentSuccessful(status) {
t.Errorf("IsDeploymentSuccessful(%q) = true, want false", status)
}
}
}
func TestNewCoolifyClient_Good(t *testing.T) {
tests := []struct {
name string
baseURL string
wantBaseURL string
}{
{
name: "URL without trailing slash",
baseURL: "https://coolify.example.com",
wantBaseURL: "https://coolify.example.com",
},
{
name: "URL with trailing slash",
baseURL: "https://coolify.example.com/",
wantBaseURL: "https://coolify.example.com",
},
{
name: "URL with api path",
baseURL: "https://coolify.example.com/api/",
wantBaseURL: "https://coolify.example.com/api",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
client := NewCoolifyClient(tt.baseURL, "token")
if client.BaseURL != tt.wantBaseURL {
t.Errorf("BaseURL = %q, want %q", client.BaseURL, tt.wantBaseURL)
}
if client.Token != "token" {
t.Errorf("Token = %q, want %q", client.Token, "token")
}
if client.HTTPClient == nil {
t.Error("HTTPClient is nil")
}
})
}
}