Reject ambiguous core scheme root
This commit is contained in:
parent
8d8b1c1a7d
commit
1f6ae5c3da
2 changed files with 7 additions and 1 deletions
|
|
@ -63,7 +63,10 @@ func (s *Service) registerDefaultSchemes() {
|
|||
func (s *Service) resolveCoreRoute(ctx context.Context, route string, query url.Values) core.Result {
|
||||
segment, subpath := splitCoreRoute(route)
|
||||
if segment == "" {
|
||||
segment = "settings"
|
||||
return core.Result{
|
||||
Value: coreerr.E("display.resolveCoreRoute", "core route is required", nil),
|
||||
OK: false,
|
||||
}
|
||||
}
|
||||
|
||||
switch segment {
|
||||
|
|
|
|||
|
|
@ -139,6 +139,9 @@ func TestScheme_ResolveScheme_Bad(t *testing.T) {
|
|||
malformedResult := svc.ResolveScheme(context.Background(), "://bad-url")
|
||||
require.False(t, malformedResult.OK)
|
||||
|
||||
rootResult := svc.ResolveScheme(context.Background(), "core://")
|
||||
require.False(t, rootResult.OK)
|
||||
|
||||
noHandlerResult := svc.ResolveScheme(context.Background(), "core://store")
|
||||
require.False(t, noHandlerResult.OK)
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue