core/gui
8
0
Fork 0
Code Issues 1 Pull requests 2 Projects Releases Packages Wiki Activity Actions

test: cover gui manifest and marketplace hardening
Some checks are pending
Security Scan / security (push) Waiting to run
Details
Test / test (push) Waiting to run
Details

Browse source
This commit is contained in:
Snider 2026-04-15 20:48:09 +01:00
parent 2c5385e1cf
commit 2b59d5892a
3 changed files with 149 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
pkg/display/manifest_test.go
View file

@ -107,3 +107,52 @@ func TestManifest_DiscoverManifestPath_Ugly(t *testing.T) {
require.NoError(t, err)
assert.Equal(t, manifestPath, got)
}
func TestManifest_ManifestWindowConfig_Good(t *testing.T) {
root := t.TempDir()
require.NoError(t, os.MkdirAll(filepath.Join(root, ".core"), 0o755))
require.NoError(t, os.WriteFile(filepath.Join(root, "index.html"), []byte("<html></html>"), 0o644))
require.NoError(t, os.WriteFile(filepath.Join(root, ".core", "view.yaml"), []byte(strings.Join([]string{
"windows:",
" main:",
" title: Core GUI",
" width: 1280",
" height: 720",
" preload: true",
}, "\n")), 0o644))
svc, err := New()
require.NoError(t, err)
got := svc.manifestWindowConfig(filepath.Join(root, "index.html"))
require.NotNil(t, got)
require.Contains(t, got, "main")
assert.Equal(t, "Core GUI", got["main"].Title)
assert.Equal(t, 1280, got["main"].Width)
assert.Equal(t, 720, got["main"].Height)
assert.True(t, got["main"].Preload)
}
func TestManifest_ManifestWindowConfig_Bad(t *testing.T) {
svc, err := New()
require.NoError(t, err)
got := svc.manifestWindowConfig(filepath.Join(t.TempDir(), "missing.html"))
assert.Nil(t, got)
}
func TestManifest_ManifestWindowConfig_Ugly(t *testing.T) {
root := t.TempDir()
require.NoError(t, os.MkdirAll(filepath.Join(root, ".core"), 0o755))
require.NoError(t, os.WriteFile(filepath.Join(root, "index.html"), []byte("<html></html>"), 0o644))
require.NoError(t, os.WriteFile(filepath.Join(root, ".core", "view.yaml"), []byte("windows: [\n"), 0o644))
svc, err := New()
require.NoError(t, err)
got := svc.manifestWindowConfig(filepath.Join(root, "index.html"))
assert.Nil(t, got)
}

59
pkg/display/network_test.go
View file

@ -79,3 +79,62 @@ func TestNetwork_RenderNetworkPage_Ugly(t *testing.T) {
assert.Contains(t, body, "&lt;addr&gt;")
assert.Contains(t, body, "loopback")
}
func TestNetwork_RenderNetworkInterfacePage_Good(t *testing.T) {
svc := &Service{}
state := NetworkState{
Hostname: "core-host",
ObservedAt: time.Unix(1_700_000_000, 0).UTC(),
Peers: []NetworkPeerState{
{ID: "peer-1", Topic: "timeline", Connected: true, SeenAt: time.Unix(1_700_000_100, 0).UTC()},
},
}
iface := NetworkInterfaceState{
Name: "en0",
Index: 2,
MTU: 1500,
Addresses: []string{"192.168.0.10/24"},
Flags: []string{"up", "running"},
Up: true,
}
body := svc.renderNetworkInterfacePage(state, iface)
assert.Contains(t, body, "core://network/en0")
assert.Contains(t, body, "core-host")
assert.Contains(t, body, "192.168.0.10/24")
assert.Contains(t, body, "Flags: up, running")
assert.Contains(t, body, "Registered peers")
assert.Contains(t, body, "peer-1")
}
func TestNetwork_RenderNetworkInterfacePage_Bad(t *testing.T) {
svc := &Service{}
state := NetworkState{Hostname: "core-host", ObservedAt: time.Unix(1, 0).UTC()}
iface := NetworkInterfaceState{Name: "en0", Index: 2, MTU: 1500, Up: false}
body := svc.renderNetworkInterfacePage(state, iface)
assert.Contains(t, body, "Flags: none")
assert.NotContains(t, body, "Registered peers")
}
func TestNetwork_RenderNetworkInterfacePage_Ugly(t *testing.T) {
svc := &Service{}
state := NetworkState{Hostname: "<host>", ObservedAt: time.Unix(1, 0).UTC()}
iface := NetworkInterfaceState{
Name: "\"quoted\"",
Index: 99,
MTU: 9,
Addresses: []string{"<addr>"},
Up: false,
Loopback: true,
}
body := svc.renderNetworkInterfacePage(state, iface)
assert.Contains(t, body, "&#34;quoted&#34;")
assert.Contains(t, body, "&lt;addr&gt;")
assert.Contains(t, body, "&lt;host&gt;")
assert.Contains(t, body, "loopback")
}

43
pkg/marketplace/marketplace_test.go
View file

@ -62,14 +62,53 @@ func TestMarketplace_FetchManifest_Bad(t *testing.T) {
}
func TestMarketplace_FetchManifest_Ugly(t *testing.T) {
t.Run("invalid yaml", func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
_, _ = w.Write([]byte(": not-yaml"))
}))
t.Cleanup(server.Close)
installer := Installer{HTTPClient: server.Client()}
_, err := installer.FetchManifest(context.Background(), server.URL)
require.Error(t, err)
})
t.Run("size limit", func(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
_, _ = w.Write([]byte("name: " + strings.Repeat("x", maxManifestBytes)))
}))
t.Cleanup(server.Close)
installer := Installer{HTTPClient: server.Client()}
_, err := installer.FetchManifest(context.Background(), server.URL)
require.Error(t, err)
assert.Contains(t, err.Error(), "exceeds")
})
}
func TestMarketplace_List_Bad(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
_, _ = w.Write([]byte(": not-yaml"))
w.WriteHeader(http.StatusBadGateway)
_, _ = w.Write([]byte("boom"))
}))
t.Cleanup(server.Close)
installer := Installer{HTTPClient: server.Client()}
_, err := installer.FetchManifest(context.Background(), server.URL)
_, err := installer.List(context.Background(), server.URL)
require.Error(t, err)
assert.Contains(t, err.Error(), "marketplace list failed")
}
func TestMarketplace_List_Ugly(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
_, _ = w.Write([]byte(strings.Repeat("a", maxManifestBytes+1)))
}))
t.Cleanup(server.Close)
installer := Installer{HTTPClient: server.Client()}
_, err := installer.List(context.Background(), server.URL)
require.Error(t, err)
assert.Contains(t, err.Error(), "exceeds")
}
func TestMarketplace_VerifyManifest_Good(t *testing.T) {