core/mcp
8
0
Fork 0
Code Issues 4 Pull requests 2 Projects Releases Packages Wiki Activity Actions

refactor(mcp): remove unused registry iterator helper

Browse source 
Keeps the registry surface tighter by removing the unused splitTagSeq helper and updating the test to cover the production splitTag helper directly.

Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Virgil 2026-04-02 07:29:59 +00:00
parent bfb5bf84e2
commit 7b22fd3141
2 changed files with 2 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/mcp/iter_test.go
View file

@ -29,9 +29,9 @@ func TestService_Iterators(t *testing.T) {
}
}
func TestRegistry_SplitTagSeq(t *testing.T) {
func TestRegistry_SplitTag(t *testing.T) {
tag := "name,omitempty,json"
parts := slices.Collect(splitTagSeq(tag))
parts := splitTag(tag)
expected := []string{"name", "omitempty", "json"}
if !slices.Equal(parts, expected) {

14
pkg/mcp/registry.go
View file

@ -4,7 +4,6 @@ package mcp
import (
"context"
"iter"
"reflect"
core "dappco.re/go/core"
@ -134,19 +133,6 @@ func splitTag(tag string) []string {
return core.Split(tag, ",")
}
// splitTagSeq returns an iterator over the tag parts.
func splitTagSeq(tag string) iter.Seq[string] {
// core.Split returns []string; wrap as iterator
parts := core.Split(tag, ",")
return func(yield func(string) bool) {
for _, p := range parts {
if !yield(p) {
return
}
}
}
}
// goTypeToJSONType maps Go types to JSON Schema types.
func goTypeToJSONType(t reflect.Type) string {
switch t.Kind() {