core/mcp
8
0
Fork 0
Code Issues 4 Pull requests 2 Projects Releases Packages Wiki Activity Actions

fix(mcp): harden session notification dispatch

Browse source
This commit is contained in:
Virgil 2026-04-02 13:54:12 +00:00
parent 8bc44d83a4
commit 8b7e0c40a6
1 changed files with 27 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
pkg/mcp/notify.go
View file

@ -203,11 +203,21 @@ func sendSessionNotification(ctx context.Context, session *mcp.ServerSession, me
}
ctx = normalizeNotificationContext(ctx)
conn, err := sessionConnection(session)
if conn, err := sessionMCPConnection(session); err == nil {
if notifier, ok := conn.(interface {
Notify(context.Context, string, any) error
}); ok {
if err := notifier.Notify(ctx, method, payload); err != nil {
return err
}
return nil
}
}
conn, err := sessionJSONRPCConnection(session)
if err != nil {
return err
}
notifier, ok := conn.(interface {
Notify(context.Context, string, any) error
})
@ -221,7 +231,21 @@ func sendSessionNotification(ctx context.Context, session *mcp.ServerSession, me
return nil
}
func sessionConnection(session *mcp.ServerSession) (any, error) {
func sessionMCPConnection(session *mcp.ServerSession) (any, error) {
value := reflect.ValueOf(session)
if value.Kind() != reflect.Ptr || value.IsNil() {
return nil, coreNotifyError("invalid session")
}
field := value.Elem().FieldByName("mcpConn")
if !field.IsValid() {
return nil, coreNotifyError("session mcp connection field unavailable")
}
return reflect.NewAt(field.Type(), unsafe.Pointer(field.UnsafeAddr())).Elem().Interface(), nil
}
func sessionJSONRPCConnection(session *mcp.ServerSession) (any, error) {
value := reflect.ValueOf(session)
if value.Kind() != reflect.Ptr || value.IsNil() {
return nil, coreNotifyError("invalid session")