core/mcp
8
0
Fork 0
Code Issues 4 Pull requests 2 Projects Releases Packages Wiki Activity Actions

fix: OnStartup/OnShutdown return core.Result (v0.8.0 Startable interface)

Browse source 
Was returning error — Core didn't recognise it as Startable so mcp/serve
commands were never registered. One-line fix per method.

Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Snider 2026-03-26 07:54:42 +00:00
parent d02853cb6c
commit 96f46e53cb
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
pkg/mcp/register.go
View file

@ -45,10 +45,10 @@ func Register(c *core.Core) core.Result {
}
// OnStartup implements core.Startable — registers MCP transport commands.
func (s *Service) OnStartup(ctx context.Context) error {
func (s *Service) OnStartup(ctx context.Context) core.Result {
c, ok := s.coreRef.(*core.Core)
if !ok || c == nil {
return nil
return core.Result{OK: true}
}
c.Command("mcp", core.Command{
@ -73,10 +73,13 @@ func (s *Service) OnStartup(ctx context.Context) error {
},
})
return nil
return core.Result{OK: true}
}
// OnShutdown implements core.Stoppable — stops the MCP transport.
func (s *Service) OnShutdown(ctx context.Context) error {
return s.Shutdown(ctx)
func (s *Service) OnShutdown(ctx context.Context) core.Result {
if err := s.Shutdown(ctx); err != nil {
return core.Result{Value: err, OK: false}
}
return core.Result{OK: true}
}