core/mcp
8
0
Fork 0
Code Issues 4 Pull requests 2 Projects Releases Packages Wiki Activity Actions

fix(mcp): add session notification helper

Browse source 
Use the Core context for forwarded IPC channel events and expose a session-level notification helper that the broadcast path reuses. This keeps the notification API more symmetric and avoids dropping context during IPC forwarding.

Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Virgil 2026-04-02 10:12:35 +00:00
parent a541c95dc8
commit c3a449e678
3 changed files with 39 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
pkg/mcp/notify.go
View file

@ -54,13 +54,25 @@ type ChannelNotification struct {
// s.SendNotificationToAllClients(ctx, "info", "monitor", map[string]any{"event": "build complete"})
func (s *Service) SendNotificationToAllClients(ctx context.Context, level mcp.LoggingLevel, logger string, data any) {
for session := range s.server.Sessions() {
if err := session.Log(ctx, &mcp.LoggingMessageParams{
Level: level,
Logger: logger,
Data: data,
}); err != nil {
s.logger.Debug("notify: failed to send to session", "session", session.ID(), "error", err)
}
s.SendNotificationToSession(ctx, session, level, logger, data)
}
}
// SendNotificationToSession sends a log-level notification to one connected
// MCP session.
//
// s.SendNotificationToSession(ctx, session, "info", "monitor", data)
func (s *Service) SendNotificationToSession(ctx context.Context, session *mcp.ServerSession, level mcp.LoggingLevel, logger string, data any) {
if session == nil {
return
}
if err := session.Log(ctx, &mcp.LoggingMessageParams{
Level: level,
Logger: logger,
Data: data,
}); err != nil {
s.logger.Debug("notify: failed to send to session", "session", session.ID(), "error", err)
}
}

12
pkg/mcp/notify_test.go
View file

@ -45,6 +45,18 @@ func TestChannelSendToSession_Good_GuardNilSession(t *testing.T) {
})
}
func TestSendNotificationToSession_Good_GuardNilSession(t *testing.T) {
svc, err := New(Options{})
if err != nil {
t.Fatalf("New() failed: %v", err)
}
ctx := context.Background()
svc.SendNotificationToSession(ctx, nil, "info", "test", map[string]any{
"ok": true,
})
}
func TestChannelSendToSession_Good_CustomNotification(t *testing.T) {
svc, err := New(Options{})
if err != nil {

9
pkg/mcp/register.go
View file

@ -97,9 +97,16 @@ func (s *Service) OnStartup(ctx context.Context) core.Result {
//
// c.ACTION(mcp.ChannelPush{Channel: "agent.status", Data: statusMap})
func (s *Service) HandleIPCEvents(c *core.Core, msg core.Message) core.Result {
ctx := context.Background()
if c != nil {
if coreCtx := c.Context(); coreCtx != nil {
ctx = coreCtx
}
}
switch ev := msg.(type) {
case ChannelPush:
s.ChannelSend(context.Background(), ev.Channel, ev.Data)
s.ChannelSend(ctx, ev.Channel, ev.Data)
}
return core.Result{OK: true}
}