Fix Codex review findings #12

Merged

Snider merged 2 commits from agent/fix-the-following-codex-review-findings into dev

2026-03-24 11:37:44 +00:00

Virgil commented

2026-03-24 11:30:37 +00:00

Member

No description provided.

Virgil added 1 commit 2026-03-24 11:30:37 +00:00

fix(mcp): resolve codex review findings — spelling, imports, tests, assertions 5d749af517

- UK English in transport_e2e_test.go comments and error strings
- Replace fmt.Printf with coreerr.Error/Warn in brain-seed for errors/skips
- Alias stdlib io as goio in transport_tcp, brain/direct, agentic/prep, bridge, brain-seed
- Add var _ Notifier = (*Service)(nil) compile-time assertion
- Add TestRegisterProcessTools_Bad_NilService for nil-service error path
- Add webview handler tests beyond nil-guard (disconnect success, validation paths)
- Guard tools_process_ci_test.go with //go:build ci (pre-existing build failure)
- Document circular-import exception in EXCEPTIONS.md

Co-Authored-By: Virgil <virgil@lethean.io>

Snider added 1 commit 2026-03-24 11:37:37 +00:00