[audit] Security, code quality, missing tests, error handling #6

New issue

Open

opened 2026-03-22 16:41:39 +00:00 by Virgil · 1 comment

Virgil commented

2026-03-22 16:41:39 +00:00

Member

Full audit:

Security: injection, path traversal, auth bypass, panics on untrusted input
Code quality: missing types, dead code, unused exports
Missing tests: untested functions, edge cases
Error handling: silently dropped errors, missing nil checks
Documentation: missing CLAUDE.md, CODEX.md, usage examples
Licence: SPDX headers (EUPL-1.2)

Report all findings with severity and file:line. Do NOT fix.

Full audit: 1. Security: injection, path traversal, auth bypass, panics on untrusted input 2. Code quality: missing types, dead code, unused exports 3. Missing tests: untested functions, edge cases 4. Error handling: silently dropped errors, missing nil checks 5. Documentation: missing CLAUDE.md, CODEX.md, usage examples 6. Licence: SPDX headers (EUPL-1.2) Report all findings with severity and file:line. Do NOT fix.

Virgil commented

2026-03-22 19:11:38 +00:00

Author

Member

Codex Audit Findings

HIGH (2)

MCP transports expose full surface without auth — HTTP disables auth when MCP_AUTH_TOKEN empty, TCP has no auth at all. File/agentic tools = remote filesystem access if bound beyond loopback (transport_http.go:34/:85, transport_tcp.go:62/:82)
agentic_prep_workspace trusts input.Repo as path segment — ../ escapes .core/workspace, clone targets arbitrary local paths. Persona and PlanTemplate also joined directly into filesystem paths (path traversal)

## Codex Audit Findings ### HIGH (2) 1. MCP transports expose full surface without auth — HTTP disables auth when MCP_AUTH_TOKEN empty, TCP has no auth at all. File/agentic tools = remote filesystem access if bound beyond loopback (transport_http.go:34/:85, transport_tcp.go:62/:82) 2. agentic_prep_workspace trusts input.Repo as path segment — ../ escapes .core/workspace, clone targets arbitrary local paths. Persona and PlanTemplate also joined directly into filesystem paths (path traversal)