From bcb40d4ebf2f124fc6a3490a2e8f302348b6ef36 Mon Sep 17 00:00:00 2001
From: Snider <snider@host.uk.com>
Date: Tue, 17 Mar 2026 09:04:27 +0000
Subject: [PATCH] fix(dx): add strict_types, composer scripts, and fix test
 discovery

- Add declare(strict_types=1) to 17 PHP files missing it (13 Livewire
  modals, 1 route file, 1 migration, 1 test use case, TestCase)
- Add composer test/lint scripts to composer.json for monorepo consistency
- Fix phpunit.xml to discover tests in src/Search/Tests and src/Mod/Hub/Tests
- Update CLAUDE.md commands section to document composer test/lint

Co-Authored-By: Virgil <virgil@lethean.io>
---
 CLAUDE.md                                           | 13 +++++++------
 composer.json                                       |  4 ++++
 phpunit.xml                                         |  4 ++++
 ...2026_01_11_000001_create_honeypot_hits_table.php |  2 ++
 src/Mod/Hub/Tests/UseCase/DashboardBasic.php        |  2 ++
 src/Website/Hub/Routes/admin.php                    |  2 ++
 src/Website/Hub/View/Modal/Admin/AIServices.php     |  2 ++
 src/Website/Hub/View/Modal/Admin/AccountUsage.php   |  2 ++
 src/Website/Hub/View/Modal/Admin/Analytics.php      |  2 ++
 src/Website/Hub/View/Modal/Admin/BoostPurchase.php  |  2 ++
 src/Website/Hub/View/Modal/Admin/Console.php        |  2 ++
 src/Website/Hub/View/Modal/Admin/Content.php        |  2 ++
 src/Website/Hub/View/Modal/Admin/ContentEditor.php  |  2 ++
 src/Website/Hub/View/Modal/Admin/ContentManager.php |  2 ++
 src/Website/Hub/View/Modal/Admin/Platform.php       |  2 ++
 src/Website/Hub/View/Modal/Admin/PlatformUser.php   |  2 ++
 src/Website/Hub/View/Modal/Admin/Profile.php        |  2 ++
 src/Website/Hub/View/Modal/Admin/Settings.php       |  2 ++
 src/Website/Hub/View/Modal/Admin/UsageDashboard.php |  2 ++
 tests/TestCase.php                                  |  2 ++
 20 files changed, 49 insertions(+), 6 deletions(-)

diff --git a/CLAUDE.md b/CLAUDE.md
index 450b223..35c627e 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -9,12 +9,13 @@ This is the **Core Admin Package** (`lthn/php-admin`) - an admin panel and servi
 ## Commands
 
 ```bash
-php artisan serve             # Laravel dev server
-npm run dev                   # Vite dev server (Tailwind v4)
-npm run build                 # Production asset build
-./vendor/bin/pint --dirty     # Format changed files only
-./vendor/bin/pest             # Run all tests
-./vendor/bin/pest --filter=SearchTest  # Run specific test
+composer test                         # Run all tests (Pest)
+composer test -- --filter=SearchTest  # Run specific test
+composer lint                         # Fix code style (Pint)
+./vendor/bin/pint --dirty             # Format changed files only
+php artisan serve                     # Laravel dev server
+npm run dev                           # Vite dev server (Tailwind v4)
+npm run build                         # Production asset build
 ```
 
 CI matrix: PHP 8.2, 8.3, 8.4.
diff --git a/composer.json b/composer.json
index c8d46ee..7062f18 100644
--- a/composer.json
+++ b/composer.json
@@ -26,6 +26,10 @@
             ]
         }
     },
+    "scripts": {
+        "test": "vendor/bin/pest",
+        "lint": "vendor/bin/pint"
+    },
     "minimum-stability": "stable",
     "prefer-stable": true,
     "replace": {
diff --git a/phpunit.xml b/phpunit.xml
index 61c031c..28b553c 100644
--- a/phpunit.xml
+++ b/phpunit.xml
@@ -11,6 +11,10 @@
         <testsuite name="Feature">
             <directory>tests/Feature</directory>
         </testsuite>
+        <testsuite name="Package">
+            <directory>src/Search/Tests</directory>
+            <directory>src/Mod/Hub/Tests</directory>
+        </testsuite>
     </testsuites>
     <source>
         <include>
diff --git a/src/Mod/Hub/Migrations/2026_01_11_000001_create_honeypot_hits_table.php b/src/Mod/Hub/Migrations/2026_01_11_000001_create_honeypot_hits_table.php
index 75b5bce..967dcae 100644
--- a/src/Mod/Hub/Migrations/2026_01_11_000001_create_honeypot_hits_table.php
+++ b/src/Mod/Hub/Migrations/2026_01_11_000001_create_honeypot_hits_table.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\Schema;
diff --git a/src/Mod/Hub/Tests/UseCase/DashboardBasic.php b/src/Mod/Hub/Tests/UseCase/DashboardBasic.php
index 6db1ba4..8f2c622 100644
--- a/src/Mod/Hub/Tests/UseCase/DashboardBasic.php
+++ b/src/Mod/Hub/Tests/UseCase/DashboardBasic.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /**
  * UseCase: Hub Dashboard (Basic Flow)
  *
diff --git a/src/Website/Hub/Routes/admin.php b/src/Website/Hub/Routes/admin.php
index ce7a023..4146e56 100644
--- a/src/Website/Hub/Routes/admin.php
+++ b/src/Website/Hub/Routes/admin.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Illuminate\Support\Facades\Route;
 
 /*
diff --git a/src/Website/Hub/View/Modal/Admin/AIServices.php b/src/Website/Hub/View/Modal/Admin/AIServices.php
index ddd404a..1415b7d 100644
--- a/src/Website/Hub/View/Modal/Admin/AIServices.php
+++ b/src/Website/Hub/View/Modal/Admin/AIServices.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Core\Mod\Social\Actions\Common\UpdateOrCreateService;
diff --git a/src/Website/Hub/View/Modal/Admin/AccountUsage.php b/src/Website/Hub/View/Modal/Admin/AccountUsage.php
index d7712fa..99728eb 100644
--- a/src/Website/Hub/View/Modal/Admin/AccountUsage.php
+++ b/src/Website/Hub/View/Modal/Admin/AccountUsage.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Core\Front\Admin\AdminMenuRegistry;
diff --git a/src/Website/Hub/View/Modal/Admin/Analytics.php b/src/Website/Hub/View/Modal/Admin/Analytics.php
index ec7e96b..7f3ede0 100644
--- a/src/Website/Hub/View/Modal/Admin/Analytics.php
+++ b/src/Website/Hub/View/Modal/Admin/Analytics.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Livewire\Component;
diff --git a/src/Website/Hub/View/Modal/Admin/BoostPurchase.php b/src/Website/Hub/View/Modal/Admin/BoostPurchase.php
index a54a024..d85b5ce 100644
--- a/src/Website/Hub/View/Modal/Admin/BoostPurchase.php
+++ b/src/Website/Hub/View/Modal/Admin/BoostPurchase.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Core\Tenant\Models\Feature;
diff --git a/src/Website/Hub/View/Modal/Admin/Console.php b/src/Website/Hub/View/Modal/Admin/Console.php
index 156bc1e..dcdea8a 100644
--- a/src/Website/Hub/View/Modal/Admin/Console.php
+++ b/src/Website/Hub/View/Modal/Admin/Console.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Livewire\Component;
diff --git a/src/Website/Hub/View/Modal/Admin/Content.php b/src/Website/Hub/View/Modal/Admin/Content.php
index 4984cc7..56bf187 100644
--- a/src/Website/Hub/View/Modal/Admin/Content.php
+++ b/src/Website/Hub/View/Modal/Admin/Content.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Core\Tenant\Services\WorkspaceService;
diff --git a/src/Website/Hub/View/Modal/Admin/ContentEditor.php b/src/Website/Hub/View/Modal/Admin/ContentEditor.php
index cb4637a..13ac53b 100644
--- a/src/Website/Hub/View/Modal/Admin/ContentEditor.php
+++ b/src/Website/Hub/View/Modal/Admin/ContentEditor.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Core\Mod\Content\Enums\ContentType;
diff --git a/src/Website/Hub/View/Modal/Admin/ContentManager.php b/src/Website/Hub/View/Modal/Admin/ContentManager.php
index 5b73a5f..5e20d8a 100644
--- a/src/Website/Hub/View/Modal/Admin/ContentManager.php
+++ b/src/Website/Hub/View/Modal/Admin/ContentManager.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Core\Cdn\Services\BunnyCdnService;
diff --git a/src/Website/Hub/View/Modal/Admin/Platform.php b/src/Website/Hub/View/Modal/Admin/Platform.php
index 448ab56..c5db6d9 100644
--- a/src/Website/Hub/View/Modal/Admin/Platform.php
+++ b/src/Website/Hub/View/Modal/Admin/Platform.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Core\Tenant\Enums\UserTier;
diff --git a/src/Website/Hub/View/Modal/Admin/PlatformUser.php b/src/Website/Hub/View/Modal/Admin/PlatformUser.php
index edff1b9..1a2d3d8 100644
--- a/src/Website/Hub/View/Modal/Admin/PlatformUser.php
+++ b/src/Website/Hub/View/Modal/Admin/PlatformUser.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Illuminate\Support\Facades\DB;
diff --git a/src/Website/Hub/View/Modal/Admin/Profile.php b/src/Website/Hub/View/Modal/Admin/Profile.php
index bf82e7d..493da0c 100644
--- a/src/Website/Hub/View/Modal/Admin/Profile.php
+++ b/src/Website/Hub/View/Modal/Admin/Profile.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Core\Tenant\Enums\UserTier;
diff --git a/src/Website/Hub/View/Modal/Admin/Settings.php b/src/Website/Hub/View/Modal/Admin/Settings.php
index df3b5f3..7902c65 100644
--- a/src/Website/Hub/View/Modal/Admin/Settings.php
+++ b/src/Website/Hub/View/Modal/Admin/Settings.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Flux\Flux;
diff --git a/src/Website/Hub/View/Modal/Admin/UsageDashboard.php b/src/Website/Hub/View/Modal/Admin/UsageDashboard.php
index 7739e17..160b29b 100644
--- a/src/Website/Hub/View/Modal/Admin/UsageDashboard.php
+++ b/src/Website/Hub/View/Modal/Admin/UsageDashboard.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Website\Hub\View\Modal\Admin;
 
 use Core\Tenant\Services\EntitlementService;
diff --git a/tests/TestCase.php b/tests/TestCase.php
index fe1ffc2..6ac0072 100644
--- a/tests/TestCase.php
+++ b/tests/TestCase.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Tests;
 
 use Illuminate\Foundation\Testing\TestCase as BaseTestCase;
-- 
2.45.3