perf: optimize AgentPhase dependency checking #23

New issue

Open

opened 2026-02-20 03:02:20 +00:00 by Clotho · 0 comments

Clotho commented

2026-02-20 03:02:20 +00:00

Member

Issue

Models/AgentPhase.php::checkDependencies() performs N+1 queries.

Current Behavior

Method loops through dependencies with individual find() calls:

foreach ($dependencies as $depId) {
    $dep = AgentPhase::find($depId);
    // ...
}

Expected Behavior

Use eager loading or batch lookup:

$deps = AgentPhase::whereIn('id', $dependencies)->get();

Acceptance Criteria

Replace individual find() with whereIn
Add tests for dependency checking
Measure performance improvement
Update related documentation

References

TODO.md: PERF-001

## Issue `Models/AgentPhase.php::checkDependencies()` performs N+1 queries. ## Current Behavior Method loops through dependencies with individual `find()` calls: ```php foreach ($dependencies as $depId) { $dep = AgentPhase::find($depId); // ... } ``` ## Expected Behavior Use eager loading or batch lookup: ```php $deps = AgentPhase::whereIn('id', $dependencies)->get(); ``` ## Acceptance Criteria - [ ] Replace individual `find()` with `whereIn` - [ ] Add tests for dependency checking - [ ] Measure performance improvement - [ ] Update related documentation ## References - TODO.md: PERF-001