core/php-agentic
8
0
Fork 0
Code Issues 36 Pull requests Projects Releases Packages Wiki Activity Actions 1

security: add rate limiting on MCP tool execution #4

New issue
Open
opened 2026-02-20 03:01:51 +00:00 by Clotho · 0 comments
Clotho commented 2026-02-20 03:01:51 +00:00
Member
Copy link

Issue

Location: Services/AgentToolRegistry.php::execute()
Risk: API key rate limits apply to auth, not individual tool calls

Current Behavior

Rate limiting is only enforced at authentication level, not per-tool execution. This allows authenticated clients to overwhelm the system with tool calls.

Expected Behavior

Tool execution should respect rate limits per workspace/API key.

Acceptance Criteria

  • Add per-tool rate limiting in execute() method
  • Tool execution respects rate limits per workspace
  • Return 429 Too Many Requests when limit exceeded
  • Add tests for rate limiting behavior

References

  • TODO.md: SEC-004
  • Related: AgentApiKeyService has auth-level rate limiting
## Issue **Location:** `Services/AgentToolRegistry.php::execute()` **Risk:** API key rate limits apply to auth, not individual tool calls ## Current Behavior Rate limiting is only enforced at authentication level, not per-tool execution. This allows authenticated clients to overwhelm the system with tool calls. ## Expected Behavior Tool execution should respect rate limits per workspace/API key. ## Acceptance Criteria - [ ] Add per-tool rate limiting in `execute()` method - [ ] Tool execution respects rate limits per workspace - [ ] Return 429 Too Many Requests when limit exceeded - [ ] Add tests for rate limiting behavior ## References - TODO.md: SEC-004 - Related: `AgentApiKeyService` has auth-level rate limiting
Clotho added the
review
discovery
 labels 2026-02-20 03:01:51 +00:00
Charon added the
clotho
 label 2026-02-20 10:57:36 +00:00
Charon added
PHP
security
P1
 and removed
clotho
review
discovery
 labels 2026-02-20 12:17:05 +00:00
Clotho was assigned by Charon 2026-02-20 12:20:52 +00:00
Snider added the
clotho
 label 2026-02-21 00:39:09 +00:00
Charon added the
agent-ready
 label 2026-02-21 01:31:38 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
feat/phase-0-assessment
dev
No results found.
Labels
Clear labels   
P1

Priority 1 - Critical

  
P2

Priority 2 - Important

  
P3

Priority 3 - Nice to have

  
PHP

PHP codebase

  
agent-ready

   
bug

Bug fix

  
clotho

Assigned to Clotho AI agent

  
discovery

Auto-discovered by agent

  
docs

Documentation

  
refactor

Code quality refactoring

  
review

Needs human review

  
security

Security hardening

  
testing

Test coverage

  
athena

Assign to Athena AI agent (M3 Ultra)

  
athena-gemini

Dispatch to Gemini CLI on M3 Ultra

  
audit

Code audit task

  
clotho

Assign to Clotho AI agent for processing

  
clotho-gemini

Dispatch to Gemini CLI on darbs (AU)

  
codex

Dispatch to Codex CLI on gateway for analysis

  
darbs-claude

Dispatch to Claude on darbs (AU)

  
security

Security review task

  
wiki

Documentation/wiki update

No labels
P1
P2
P3
PHP
agent-ready
bug
clotho
discovery
docs
refactor
review
security
testing
athena
athena-gemini
audit
clotho
clotho-gemini
codex
darbs-claude
security
wiki
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
Clotho
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: core/php-agentic#4
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?