refactor(jobs): remove processOutput stub from ProcessContentTask #47

Merged

Snider merged 1 commit from refactor/remove-process-content-task-stub into main

2026-02-23 06:09:22 +00:00

Clotho commented

2026-02-23 05:47:11 +00:00

Member

Summary

Removes the processOutput() stub method and its ContentProcessingService dependency from ProcessContentTask — the method body was empty (comments only) and the external service's API is not available in this package
Content is already persisted via markCompleted() so no additional output processing is needed
Adds 11 unit tests covering: prompt validation, entitlement checks, provider availability, task completion metadata, usage recording, and template variable interpolation

Test plan

Review Jobs/ProcessContentTask.php — confirm stub and unused import are removed
Review tests/Unit/ProcessContentTaskTest.php — confirm all test scenarios are meaningful
Confirm no other callers pass a ContentProcessingService to ProcessContentTask::handle()

Closes #17

🤖 Generated with Claude Code

## Summary - Removes the `processOutput()` stub method and its `ContentProcessingService` dependency from `ProcessContentTask` — the method body was empty (comments only) and the external service's API is not available in this package - Content is already persisted via `markCompleted()` so no additional output processing is needed - Adds 11 unit tests covering: prompt validation, entitlement checks, provider availability, task completion metadata, usage recording, and template variable interpolation ## Test plan - [ ] Review `Jobs/ProcessContentTask.php` — confirm stub and unused import are removed - [ ] Review `tests/Unit/ProcessContentTaskTest.php` — confirm all test scenarios are meaningful - [ ] Confirm no other callers pass a `ContentProcessingService` to `ProcessContentTask::handle()` Closes #17 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Clotho added 1 commit 2026-02-23 05:47:11 +00:00

refactor(jobs): remove processOutput stub from ProcessContentTask

CI / PHP 8.3 (pull_request) Failing after 1m1s

Details

CI / PHP 8.4 (pull_request) Failing after 59s

Details

003c16c1cd

The processOutput() method was a stub with no implementation. The
ContentProcessingService dependency it accepted is from the external
host-uk/core package and its API is not available here. Content
is already persisted via markCompleted() so no output processing
was ever performed.

Removes:
- processOutput() stub method
- ContentProcessingService import and handle() parameter
- target_type/target_id guard block that called the stub

Adds unit tests covering: prompt validation, entitlement checks,
provider availability, task completion metadata, usage recording,
and template variable interpolation.

Closes #17

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>