php-agentic/Mcp/Tools/Agent/State/StateGet.php
Snider a2a9423ad6 security: fix SQL injection and add workspace scoping to MCP tools
- Replace orderByRaw with parameterised CASE statements
- Add Task::scopeOrderByPriority() and scopeOrderByStatus()
- Add AgentPlan::scopeOrderByStatus()
- Add workspace validation to StateSet, StateGet, StateList tools
- Add workspace validation to PlanGet, PlanList tools
- Add SecurityTest.php with comprehensive isolation tests

Fixes SEC-002, SEC-003 from security audit.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-29 12:21:01 +00:00

99 lines
2.6 KiB
PHP

<?php
declare(strict_types=1);
namespace Core\Mod\Agentic\Mcp\Tools\Agent\State;
use Core\Mcp\Dependencies\ToolDependency;
use Core\Mod\Agentic\Models\AgentPlan;
use Core\Mod\Agentic\Mcp\Tools\Agent\AgentTool;
/**
* Get a workspace state value.
*/
class StateGet extends AgentTool
{
protected string $category = 'state';
protected array $scopes = ['read'];
/**
* Get the dependencies for this tool.
*
* Workspace context is required to ensure tenant isolation.
*
* @return array<ToolDependency>
*/
public function dependencies(): array
{
return [
ToolDependency::contextExists('workspace_id', 'Workspace context required for state operations'),
];
}
public function name(): string
{
return 'state_get';
}
public function description(): string
{
return 'Get a workspace state value';
}
public function inputSchema(): array
{
return [
'type' => 'object',
'properties' => [
'plan_slug' => [
'type' => 'string',
'description' => 'Plan slug identifier',
],
'key' => [
'type' => 'string',
'description' => 'State key',
],
],
'required' => ['plan_slug', 'key'],
];
}
public function handle(array $args, array $context = []): array
{
try {
$planSlug = $this->require($args, 'plan_slug');
$key = $this->require($args, 'key');
} catch (\InvalidArgumentException $e) {
return $this->error($e->getMessage());
}
// Validate workspace context for tenant isolation
$workspaceId = $context['workspace_id'] ?? null;
if ($workspaceId === null) {
return $this->error('workspace_id is required for state operations');
}
// Query plan with workspace scope to prevent cross-tenant access
$plan = AgentPlan::forWorkspace($workspaceId)
->where('slug', $planSlug)
->first();
if (! $plan) {
return $this->error("Plan not found: {$planSlug}");
}
$state = $plan->states()->where('key', $key)->first();
if (! $state) {
return $this->error("State not found: {$key}");
}
return $this->success([
'key' => $state->key,
'value' => $state->value,
'category' => $state->category,
'updated_at' => $state->updated_at->toIso8601String(),
]);
}
}