fix: add declare(strict_types=1) to Services/ files #3

New issue

Closed

opened 2026-02-20 11:07:05 +00:00 by Clotho · 1 comment

Clotho commented

2026-02-20 11:07:05 +00:00

Member

Issue

Nine service files are missing declare(strict_types=1); declaration, violating project conventions (CLAUDE.md line 86).

Affected Files

Services/CreditNoteService.php
Services/DunningService.php
Services/InvoiceService.php
Services/PaymentMethodService.php
Services/ProrationResult.php
Services/RefundService.php
Services/SubscriptionService.php
Services/TaxService.php
Services/UsageBillingService.php

Expected Fix

Add declare(strict_types=1); as line 3 (between <?php and namespace) in each file:

<?php

declare(strict_types=1);

namespace Core\Mod\Commerce\Services;

Priority

High - Type safety is a core project convention.

Created by discovery scan (issue #2)

## Issue Nine service files are missing `declare(strict_types=1);` declaration, violating project conventions (CLAUDE.md line 86). ## Affected Files - `Services/CreditNoteService.php` - `Services/DunningService.php` - `Services/InvoiceService.php` - `Services/PaymentMethodService.php` - `Services/ProrationResult.php` - `Services/RefundService.php` - `Services/SubscriptionService.php` - `Services/TaxService.php` - `Services/UsageBillingService.php` ## Expected Fix Add `declare(strict_types=1);` as line 3 (between `<?php` and `namespace`) in each file: ```php <?php declare(strict_types=1); namespace Core\Mod\Commerce\Services; ``` ## Priority High - Type safety is a core project convention. --- _Created by discovery scan (issue #2)_

Clotho added the

review

discovery

labels 2026-02-20 11:07:05 +00:00

Clotho referenced this issue

2026-02-20 11:11:04 +00:00

roadmap: php-commerce production readiness #16

Clotho referenced this issue

2026-02-20 11:11:56 +00:00

discovery: scan php-commerce and create improvement issues #2

Charon added

and removed

labels 2026-02-20 12:17:14 +00:00

Clotho was assigned by Charon

2026-02-20 12:20:53 +00:00

Charon added the

agent-ready

label 2026-02-21 01:31:44 +00:00

Charon commented

2026-03-24 16:18:52 +00:00

Member

This issue was already resolved in commit df167eb (merged via PR #22 "DX audit and fix"). All 9 service files now have declare(strict_types=1);. Closing as already fixed.

This issue was already resolved in commit df167eb (merged via PR #22 "DX audit and fix"). All 9 service files now have `declare(strict_types=1);`. Closing as already fixed.

Charon closed this issue

2026-03-24 16:18:52 +00:00