fix: add declare(strict_types=1) to Services/ files #3

New issue

Open

opened 2026-02-20 11:07:05 +00:00 by Clotho · 0 comments

Clotho commented

2026-02-20 11:07:05 +00:00

Member

Issue

Nine service files are missing declare(strict_types=1); declaration, violating project conventions (CLAUDE.md line 86).

Affected Files

Services/CreditNoteService.php
Services/DunningService.php
Services/InvoiceService.php
Services/PaymentMethodService.php
Services/ProrationResult.php
Services/RefundService.php
Services/SubscriptionService.php
Services/TaxService.php
Services/UsageBillingService.php

Expected Fix

Add declare(strict_types=1); as line 3 (between <?php and namespace) in each file:

<?php

declare(strict_types=1);

namespace Core\Mod\Commerce\Services;

Priority

High - Type safety is a core project convention.

Created by discovery scan (issue #2)

## Issue Nine service files are missing `declare(strict_types=1);` declaration, violating project conventions (CLAUDE.md line 86). ## Affected Files - `Services/CreditNoteService.php` - `Services/DunningService.php` - `Services/InvoiceService.php` - `Services/PaymentMethodService.php` - `Services/ProrationResult.php` - `Services/RefundService.php` - `Services/SubscriptionService.php` - `Services/TaxService.php` - `Services/UsageBillingService.php` ## Expected Fix Add `declare(strict_types=1);` as line 3 (between `<?php` and `namespace`) in each file: ```php <?php declare(strict_types=1); namespace Core\Mod\Commerce\Services; ``` ## Priority High - Type safety is a core project convention. --- _Created by discovery scan (issue #2)_